fix clippy checks

Implement From instead of Into as this offers a default Into
implementation as well.

Use ..Default::default() when initializing structs.

Signed-off-by: Andreea Florescu <fandree@amazon.com>

Author: andreeaflorescu

src/cmdline/mod.rs

@@ -331,9 +331,9 @@ impl Cmdline {
     }
 }
 
-impl Into<Vec<u8>> for Cmdline {
-    fn into(self) -> Vec<u8> {
-        self.line.into_bytes()
+impl From<Cmdline> for Vec<u8> {
+    fn from(cmdline: Cmdline) -> Vec<u8> {
+        cmdline.line.into_bytes()
     }
 }
 

src/loader/x86_64/bzimage/mod.rs

@@ -159,9 +159,11 @@ impl KernelLoader for BzImage {
 
         boot_header.code32_start = mem_offset.raw_value() as u32;
 
-        let mut loader_result: KernelLoaderResult = Default::default();
-        loader_result.setup_header = Some(boot_header);
-        loader_result.kernel_load = mem_offset;
+        let mut loader_result = KernelLoaderResult {
+            setup_header: Some(boot_header),
+            kernel_load: mem_offset,
+            ..Default::default()
+        };
 
         // Seek the compressed `vmlinux.bin` and read it to memory.
         kernel_image

src/loader/x86_64/elf/mod.rs

@@ -219,17 +219,17 @@ impl KernelLoader for Elf {
             }
         }
 
-        let mut loader_result: KernelLoaderResult = Default::default();
-
-        // Address where the kernel will be loaded.
-        loader_result.kernel_load = match kernel_offset {
-            Some(k_offset) => GuestAddress(
-                k_offset
-                    .raw_value()
-                    .checked_add(ehdr.e_entry as u64)
-                    .ok_or(Error::Overflow)?,
-            ),
-            None => GuestAddress(ehdr.e_entry as u64),
+        let mut loader_result = KernelLoaderResult {
+            kernel_load: match kernel_offset {
+                Some(k_offset) => GuestAddress(
+                    k_offset
+                        .raw_value()
+                        .checked_add(ehdr.e_entry as u64)
+                        .ok_or(Error::Overflow)?,
+                ),
+                None => GuestAddress(ehdr.e_entry as u64),
+            },
+            ..Default::default()
         };
 
         kernel_image