Skip to content

Commit b597cf9

Browse files
author
Alexandra Iordache
committed
loader: reorganize imports
Export elf and bzimage specific features as `elf::<feature>` and `bzimage::<feature>` respectively, to further simplify loader/mod.rs. Signed-off-by: Alexandra Iordache <aghecen@amazon.com>
1 parent 272f3b9 commit b597cf9

File tree

3 files changed

+12
-16
lines changed

3 files changed

+12
-16
lines changed

src/loader/mod.rs

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -42,26 +42,22 @@ mod x86_64;
4242
#[cfg(target_arch = "aarch64")]
4343
mod aarch64;
4444

45-
#[cfg(all(feature = "bzimage", any(target_arch = "x86", target_arch = "x86_64")))]
46-
pub use x86_64::bzimage::BzImage;
47-
#[cfg(all(feature = "bzimage", any(target_arch = "x86", target_arch = "x86_64")))]
48-
pub use x86_64::bzimage::Error as BzImageError;
45+
#[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
46+
pub use x86_64::*;
4947

50-
#[cfg(all(feature = "elf", any(target_arch = "x86", target_arch = "x86_64")))]
51-
pub use x86_64::elf::Elf;
52-
#[cfg(all(feature = "elf", any(target_arch = "x86", target_arch = "x86_64")))]
53-
pub use x86_64::elf::Error as ElfError;
48+
#[cfg(target_arch = "aarch64")]
49+
pub use aarch64::*;
5450

5551
#[derive(Debug, PartialEq)]
5652
/// Kernel loader errors.
5753
pub enum Error {
5854
/// Failed to load bzimage.
5955
#[cfg(all(feature = "bzimage", any(target_arch = "x86", target_arch = "x86_64")))]
60-
Bzimage(BzImageError),
56+
Bzimage(bzimage::Error),
6157

6258
/// Failed to load elf image.
6359
#[cfg(all(feature = "elf", any(target_arch = "x86", target_arch = "x86_64")))]
64-
Elf(ElfError),
60+
Elf(elf::Error),
6561

6662
/// Failed writing command line to guest memory.
6763
CommandLineCopy,
@@ -99,15 +95,15 @@ impl Display for Error {
9995
}
10096

10197
#[cfg(all(feature = "elf", any(target_arch = "x86", target_arch = "x86_64")))]
102-
impl From<ElfError> for Error {
103-
fn from(err: ElfError) -> Self {
98+
impl From<elf::Error> for Error {
99+
fn from(err: elf::Error) -> Self {
104100
Error::Elf(err)
105101
}
106102
}
107103

108104
#[cfg(all(feature = "bzimage", any(target_arch = "x86", target_arch = "x86_64")))]
109-
impl From<BzImageError> for Error {
110-
fn from(err: BzImageError) -> Self {
105+
impl From<bzimage::Error> for Error {
106+
fn from(err: bzimage::Error) -> Self {
111107
Error::Bzimage(err)
112108
}
113109
}

src/loader/x86_64/bzimage/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ impl KernelLoader for BzImage {
8686
/// let gm = GuestMemoryMmap::from_ranges(&[(GuestAddress(0x0), mem_size)]).unwrap();
8787
/// let mut kernel_image = vec![];
8888
/// kernel_image.extend_from_slice(include_bytes!("bzimage"));
89-
/// assert!(BzImage::load(
89+
/// assert!(bzimage::BzImage::load(
9090
/// &gm,
9191
/// Some(kernel_addr),
9292
/// &mut Cursor::new(&kernel_image),

src/loader/x86_64/elf/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ impl KernelLoader for Elf {
150150
/// let gm = GuestMemoryMmap::from_ranges(&[(GuestAddress(0x0), mem_size)]).unwrap();
151151
/// let mut kernel_image = vec![];
152152
/// kernel_image.extend_from_slice(include_bytes!("test_elf.bin"));
153-
/// assert!(Elf::load(
153+
/// assert!(elf::Elf::load(
154154
/// &gm,
155155
/// Some(kernel_addr),
156156
/// &mut Cursor::new(&kernel_image),

0 commit comments

Comments
 (0)