Skip to content

Commit 11a0719

Browse files
lauraltandreeaflorescu
authored andcommitted
upgrade to latest vm-memory (v0.6.0)
Tests were failing because of a breaking change in GuestMemoryMmap interface. Fixed them and increased the minimum version of vm-memory dependency. Fixes #83. Signed-off-by: Laura Loghin <lauralg@amazon.com>
1 parent 0c6c958 commit 11a0719

File tree

5 files changed

+19
-12
lines changed

5 files changed

+19
-12
lines changed

Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,11 @@ elf = []
1818
pe = []
1919

2020
[dependencies]
21-
vm-memory = ">=0.2.0"
21+
vm-memory = ">=0.6.0"
2222

2323
[dev-dependencies]
2424
criterion = "=0.3.0"
25-
vm-memory = { version = ">=0.2.0", features = ["backend-mmap"] }
25+
vm-memory = { version = ">=0.6.0", features = ["backend-mmap"] }
2626

2727
[[bench]]
2828
name = "main"

src/loader/aarch64/pe/mod.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,8 @@ where
202202
mod tests {
203203
use super::*;
204204
use std::io::Cursor;
205-
use vm_memory::{Address, GuestAddress, GuestMemoryMmap};
205+
use vm_memory::{Address, GuestAddress};
206+
type GuestMemoryMmap = vm_memory::GuestMemoryMmap<()>;
206207

207208
const MEM_SIZE: u64 = 0x100_0000;
208209

src/loader/mod.rs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -193,10 +193,11 @@ unsafe impl ByteValued for bootparam::boot_params {}
193193
/// # Examples
194194
///
195195
/// ```rust
196+
/// # use std::ffi::CStr;
196197
/// # extern crate vm_memory;
197198
/// # use linux_loader::loader::*;
198-
/// # use vm_memory::{Bytes, GuestAddress, GuestMemoryMmap};
199-
/// # use std::ffi::CStr;
199+
/// # use vm_memory::{Bytes, GuestAddress};
200+
/// # type GuestMemoryMmap = vm_memory::GuestMemoryMmap<()>;
200201
/// let mem_size: usize = 0x1000000;
201202
/// let gm = GuestMemoryMmap::from_ranges(&[(GuestAddress(0x0), mem_size)]).unwrap();
202203
/// let mut cl = Cmdline::new(10);
@@ -233,7 +234,8 @@ pub fn load_cmdline<M: GuestMemory>(
233234
#[cfg(test)]
234235
mod tests {
235236
use super::*;
236-
use vm_memory::{Address, GuestAddress, GuestMemoryMmap};
237+
use vm_memory::{Address, GuestAddress};
238+
type GuestMemoryMmap = vm_memory::GuestMemoryMmap<()>;
237239

238240
const MEM_SIZE: u64 = 0x100_0000;
239241

src/loader/x86_64/bzimage/mod.rs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,10 @@ impl KernelLoader for BzImage {
8181
///
8282
/// ```rust
8383
/// # extern crate vm_memory;
84-
/// # use linux_loader::loader::*;
85-
/// # use vm_memory::{Address, GuestAddress, GuestMemoryMmap};
8684
/// # use std::io::Cursor;
85+
/// # use linux_loader::loader::*;
86+
/// # use vm_memory::{Address, GuestAddress};
87+
/// # type GuestMemoryMmap = vm_memory::GuestMemoryMmap<()>;
8788
/// let mem_size: usize = 0x1000000;
8889
/// let himem_start = GuestAddress(0x0);
8990
/// let kernel_addr = GuestAddress(0x200000);
@@ -189,7 +190,8 @@ mod tests {
189190
use std::fs::File;
190191
use std::io::Cursor;
191192
use std::process::Command;
192-
use vm_memory::{Address, GuestAddress, GuestMemoryMmap};
193+
use vm_memory::{Address, GuestAddress};
194+
type GuestMemoryMmap = vm_memory::GuestMemoryMmap<()>;
193195

194196
const MEM_SIZE: u64 = 0x100_0000;
195197

src/loader/x86_64/elf/mod.rs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -175,9 +175,10 @@ impl KernelLoader for Elf {
175175
///
176176
/// ```rust
177177
/// # extern crate vm_memory;
178-
/// # use linux_loader::loader::*;
179-
/// # use vm_memory::{Address, GuestAddress, GuestMemoryMmap};
180178
/// # use std::io::Cursor;
179+
/// # use linux_loader::loader::*;
180+
/// # use vm_memory::{Address, GuestAddress};
181+
/// # type GuestMemoryMmap = vm_memory::GuestMemoryMmap<()>;
181182
/// let mem_size: usize = 0x1000000;
182183
/// let himem_start = GuestAddress(0x0);
183184
/// let kernel_addr = GuestAddress(0x200000);
@@ -421,7 +422,8 @@ fn align_up(addr: u64, align: u64) -> result::Result<u64, Error> {
421422
mod tests {
422423
use super::*;
423424
use std::io::Cursor;
424-
use vm_memory::{Address, GuestAddress, GuestMemoryMmap};
425+
use vm_memory::{Address, GuestAddress};
426+
type GuestMemoryMmap = vm_memory::GuestMemoryMmap<()>;
425427

426428
const MEM_SIZE: u64 = 0x100_0000;
427429

0 commit comments

Comments
 (0)