Merge pull request #476 from mkroening/clippy-fix

fix and detect warnings

Author: phil-opp

.github/workflows/build.yml

@@ -14,6 +14,7 @@ permissions:
   contents: read
 
 env:
+  RUSTFLAGS: -Dwarnings
   RUSTDOCFLAGS: -Dwarnings
 
 jobs:

src/addr.rs

@@ -240,6 +240,7 @@ impl VirtAddr {
     }
 
     // FIXME: Move this into the `Step` impl, once `Step` is stabilized.
+    #[cfg(any(feature = "instructions", feature = "step_trait"))]
     pub(crate) fn steps_between_impl(start: &Self, end: &Self) -> Option<usize> {
         let mut steps = end.0.checked_sub(start.0)?;
 

src/instructions/random.rs

@@ -65,7 +65,7 @@ impl RdRand {
     }
 }
 
-#[cfg(all(test))]
+#[cfg(test)]
 mod tests {
     use super::*;
 

src/registers/control.rs

@@ -296,7 +296,7 @@ mod x86_64 {
         #[inline]
         pub fn read_pcid() -> (PhysFrame, Pcid) {
             let (frame, value) = Cr3::read_raw();
-            (frame, Pcid::new(value as u16).unwrap())
+            (frame, Pcid::new(value).unwrap())
         }
 
         /// Write a new P4 table address into the CR3 register.

src/registers/model_specific.rs

@@ -6,6 +6,7 @@ use bitflags::bitflags;
 use crate::registers::segmentation::{FS, GS};
 
 /// A model specific register.
+#[cfg_attr(not(feature = "instructions"), allow(dead_code))] // FIXME
 #[derive(Debug)]
 pub struct Msr(u32);
 

src/structures/gdt.rs

@@ -117,6 +117,13 @@ impl GlobalDescriptorTable {
     }
 }
 
+impl Default for GlobalDescriptorTable {
+    #[inline]
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl<const MAX: usize> GlobalDescriptorTable<MAX> {
     /// Creates an empty GDT which can hold `MAX` number of [`Entry`]s.
     #[inline]

src/structures/idt.rs

@@ -565,6 +565,13 @@ impl InterruptDescriptorTable {
     }
 }
 
+impl Default for InterruptDescriptorTable {
+    #[inline]
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl Index<u8> for InterruptDescriptorTable {
     type Output = Entry<HandlerFunc>;
 

src/structures/paging/mapper/mapped_page_table.rs

@@ -1,9 +1,7 @@
 use crate::structures::paging::{
-    frame::PhysFrame,
-    frame_alloc::{FrameAllocator, FrameDeallocator},
     mapper::*,
-    page::{AddressNotAligned, Page, PageRangeInclusive, Size1GiB, Size2MiB, Size4KiB},
-    page_table::{FrameError, PageTable, PageTableEntry, PageTableFlags, PageTableLevel},
+    page::AddressNotAligned,
+    page_table::{FrameError, PageTable, PageTableEntry, PageTableLevel},
 };
 
 /// A Mapper implementation that relies on a PhysAddr to VirtAddr conversion function.
@@ -549,6 +547,7 @@ impl<'a, P: PageTableFrameMapping> Translate for MappedPageTable<'a, P> {
             Err(PageTableWalkError::MappedToHugePage) => {
                 let entry = &p3[addr.p3_index()];
                 let frame = PhysFrame::containing_address(entry.addr());
+                #[allow(clippy::unusual_byte_groupings)]
                 let offset = addr.as_u64() & 0o_777_777_7777;
                 let flags = entry.flags();
                 return TranslateResult::Mapped {
@@ -564,6 +563,7 @@ impl<'a, P: PageTableFrameMapping> Translate for MappedPageTable<'a, P> {
             Err(PageTableWalkError::MappedToHugePage) => {
                 let entry = &p2[addr.p2_index()];
                 let frame = PhysFrame::containing_address(entry.addr());
+                #[allow(clippy::unusual_byte_groupings)]
                 let offset = addr.as_u64() & 0o_777_7777;
                 let flags = entry.flags();
                 return TranslateResult::Mapped {

src/structures/paging/mapper/mod.rs

@@ -383,6 +383,7 @@ pub trait Mapper<S: PageSize> {
 /// changed the mapping of a page to ensure that the TLB flush is not forgotten.
 #[derive(Debug)]
 #[must_use = "Page Table changes must be flushed or ignored."]
+#[cfg_attr(not(feature = "instructions"), allow(dead_code))] // FIXME
 pub struct MapperFlush<S: PageSize>(Page<S>);
 
 impl<S: PageSize> MapperFlush<S> {

src/structures/paging/mapper/offset_page_table.rs

@@ -1,9 +1,6 @@
 #![cfg(target_pointer_width = "64")]
 
-use crate::structures::paging::{
-    frame::PhysFrame, mapper::*, page::PageRangeInclusive, page_table::PageTable, FrameDeallocator,
-    Page, PageTableFlags,
-};
+use crate::structures::paging::{mapper::*, page_table::PageTable};
 
 /// A Mapper implementation that requires that the complete physically memory is mapped at some
 /// offset in the virtual address space.