Skip to content

Commit 3740ac3

Browse files
committed
Disable OpenXR examples in CI for now
We don't currently build the OpenXR examples on Android because I haven't found a nice nice way to pull in libopenxr_loader binaries that we can link against. Normally I would use the binaries as part of the Oculus SDK TODO: maybe we can look at using the 'prefab' `.aar`s from Khronos here: https://search.maven.org/artifact/org.khronos.openxr/openxr_loader_for_android
1 parent 95c47f2 commit 3740ac3

File tree

1 file changed

+21
-13
lines changed

1 file changed

+21
-13
lines changed

.github/workflows/ci.yml

Lines changed: 21 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -125,19 +125,27 @@ jobs:
125125
./gradlew build &&
126126
find $GITHUB_WORKSPACE/shared-target -iname '*.so' -exec rm {} \;
127127
128-
- name: Build na-openxr-info example
129-
working-directory: na-openxr-info
130-
run: >
131-
CARGO_TARGET_DIR=$GITHUB_WORKSPACE/shared-target cargo ndk ${{ matrix.cargo_ndk_args }} build --features=android &&
132-
./gradlew build &&
133-
find $GITHUB_WORKSPACE/shared-target -iname '*.so' -exec rm {} \;
134-
135-
- name: Build na-openxr-wgpu
136-
working-directory: na-openxr-wgpu
137-
run: >
138-
CARGO_TARGET_DIR=$GITHUB_WORKSPACE/shared-target cargo ndk ${{ matrix.cargo_ndk_args }} build &&
139-
./gradlew build &&
140-
find $GITHUB_WORKSPACE/shared-target -iname '*.so' -exec rm {} \;
128+
# We don't currently build the OpenXR examples on Android because I
129+
# haven't found a nice nice way to pull in libopenxr_loader binaries that
130+
# we can link against. Normally I would use the binaries as part of the
131+
# Oculus SDK
132+
#
133+
# TODO: maybe we can look at using the 'prefab' `.aar`s from Khronos here:
134+
# https://search.maven.org/artifact/org.khronos.openxr/openxr_loader_for_android
135+
#
136+
#- name: Build na-openxr-info example
137+
# working-directory: na-openxr-info
138+
# run: >
139+
# CARGO_TARGET_DIR=$GITHUB_WORKSPACE/shared-target cargo ndk ${{ matrix.cargo_ndk_args }} build --features=android &&
140+
# ./gradlew build &&
141+
# find $GITHUB_WORKSPACE/shared-target -iname '*.so' -exec rm {} \;
142+
143+
#- name: Build na-openxr-wgpu
144+
# working-directory: na-openxr-wgpu
145+
# run: >
146+
# CARGO_TARGET_DIR=$GITHUB_WORKSPACE/shared-target cargo ndk ${{ matrix.cargo_ndk_args }} build &&
147+
# ./gradlew build &&
148+
# find $GITHUB_WORKSPACE/shared-target -iname '*.so' -exec rm {} \;
141149

142150

143151
format:

0 commit comments

Comments
 (0)