Skip to content

Commit 499d095

Browse files
committed
Upgrade to ndk-sys 0.5.0-beta.0, ndk-0.8.0 beta.0
1 parent 2654c96 commit 499d095

File tree

7 files changed

+20
-25
lines changed

7 files changed

+20
-25
lines changed

Cargo.toml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,4 @@
11
[workspace]
2-
members = [
3-
"android-activity"
4-
]
2+
members = ["android-activity"]
53

6-
exclude = [
7-
"examples",
8-
]
4+
exclude = ["examples"]

android-activity/Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ log = "0.4"
3939
jni-sys = "0.3"
4040
cesu8 = "1"
4141
jni = "0.21"
42-
ndk = "0.7"
43-
ndk-sys = "0.4"
42+
ndk-sys = "0.5.0-beta.0"
43+
ndk = "0.8.0-beta.0"
4444
ndk-context = "0.1"
4545
android-properties = "0.2"
4646
num_enum = "0.7"

android-activity/src/lib.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -537,14 +537,14 @@ impl AndroidApp {
537537
/// [`ALooper_pollAll`]: ndk::looper::ThreadLooper::poll_all
538538
pub fn poll_events<F>(&self, timeout: Option<Duration>, callback: F)
539539
where
540-
F: FnMut(PollEvent),
540+
F: FnMut(PollEvent<'_>),
541541
{
542542
self.inner.read().unwrap().poll_events(timeout, callback);
543543
}
544544

545545
/// Creates a means to wake up the main loop while it is blocked waiting for
546546
/// events within [`AndroidApp::poll_events()`].
547-
pub fn create_waker(&self) -> activity_impl::AndroidAppWaker {
547+
pub fn create_waker(&self) -> AndroidAppWaker {
548548
self.inner.read().unwrap().create_waker()
549549
}
550550

android-activity/src/native_activity/glue.rs

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ pub enum NativeThreadState {
216216
pub struct NativeActivityState {
217217
pub msg_read: libc::c_int,
218218
pub msg_write: libc::c_int,
219-
pub config: super::ConfigurationRef,
219+
pub config: ConfigurationRef,
220220
pub saved_state: Vec<u8>,
221221
pub input_queue: *mut ndk_sys::AInputQueue,
222222
pub window: Option<NativeWindow>,
@@ -343,9 +343,8 @@ impl WaitableNativeActivityState {
343343
}
344344
}
345345

346-
let saved_state = unsafe {
347-
std::slice::from_raw_parts(saved_state_in as *const u8, saved_state_size as _)
348-
};
346+
let saved_state =
347+
unsafe { std::slice::from_raw_parts(saved_state_in as *const u8, saved_state_size) };
349348

350349
let config = unsafe {
351350
let config = ndk_sys::AConfiguration_new();
@@ -517,7 +516,7 @@ impl WaitableNativeActivityState {
517516
// given via a `malloc()` allocated pointer since it will automatically
518517
// `free()` the state after it has been converted to a buffer for the JVM.
519518
if !guard.saved_state.is_empty() {
520-
let saved_state_size = guard.saved_state.len() as _;
519+
let saved_state_size = guard.saved_state.len();
521520
let saved_state_src_ptr = guard.saved_state.as_ptr();
522521
unsafe {
523522
let saved_state = libc::malloc(saved_state_size);
@@ -681,15 +680,15 @@ unsafe extern "C" fn on_resume(activity: *mut ndk_sys::ANativeActivity) {
681680

682681
unsafe extern "C" fn on_save_instance_state(
683682
activity: *mut ndk_sys::ANativeActivity,
684-
out_len: *mut ndk_sys::size_t,
683+
out_len: *mut usize,
685684
) -> *mut libc::c_void {
686685
abort_on_panic(|| {
687686
log::debug!("SaveInstanceState: {:p}\n", activity);
688687
*out_len = 0;
689688
let mut ret = ptr::null_mut();
690689
try_with_waitable_activity_ref(activity, |waitable_activity| {
691690
let (state, len) = waitable_activity.request_save_state();
692-
*out_len = len as ndk_sys::size_t;
691+
*out_len = len;
693692
ret = state
694693
});
695694

android-activity/src/native_activity/mod.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -185,14 +185,14 @@ impl AndroidAppInner {
185185

186186
pub fn poll_events<F>(&self, timeout: Option<Duration>, mut callback: F)
187187
where
188-
F: FnMut(PollEvent),
188+
F: FnMut(PollEvent<'_>),
189189
{
190190
trace!("poll_events");
191191

192192
unsafe {
193193
let mut fd: i32 = 0;
194194
let mut events: i32 = 0;
195-
let mut source: *mut core::ffi::c_void = ptr::null_mut();
195+
let mut source: *mut c_void = ptr::null_mut();
196196

197197
let timeout_milliseconds = if let Some(timeout) = timeout {
198198
timeout.as_millis() as i32
@@ -209,7 +209,7 @@ impl AndroidAppInner {
209209
timeout_milliseconds,
210210
&mut fd,
211211
&mut events,
212-
&mut source as *mut *mut core::ffi::c_void,
212+
&mut source as *mut *mut c_void,
213213
);
214214
trace!("pollAll id = {id}");
215215
match id {

examples/agdk-mainloop/Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ edition = "2021"
99
log = "0.4"
1010
android_logger = "0.11.0"
1111
android-activity = { path="../../android-activity", features = ["game-activity"] }
12-
ndk-sys = "0.4"
13-
ndk = "0.7"
12+
ndk-sys = "0.5.0-beta.0"
13+
ndk = "0.8.0-beta.0"
1414

1515
[lib]
1616
name="main"

examples/na-mainloop/Cargo.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ edition = "2021"
99
log = "0.4"
1010
android_logger = "0.11.0"
1111
android-activity = { path="../../android-activity", features = [ "native-activity" ] }
12-
ndk-sys = "0.4"
13-
ndk = "0.7"
12+
ndk-sys = "0.5.0-beta.0"
13+
ndk = "0.8.0-beta.0"
1414

1515
[lib]
1616
#name="na_mainloop"
@@ -181,4 +181,4 @@ label = "Application Name"
181181
#port = "8080"
182182
#path = "/rust-windowing/android-ndk-rs/tree/master/cargo-apk"
183183
#path_prefix = "/rust-windowing/"
184-
#mime_type = "image/jpeg"
184+
#mime_type = "image/jpeg"

0 commit comments

Comments
 (0)