Skip to content

Commit 1a51dc2

Browse files
committed
Revert "GameActivity PATCH: rename C symbols that need export"
This reverts commit d6345ab.
1 parent 7597e9a commit 1a51dc2

File tree

3 files changed

+5
-12
lines changed

3 files changed

+5
-12
lines changed

android-activity/game-activity-csrc/game-activity/GameActivity.cpp

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -485,7 +485,7 @@ static jlong initializeNativeCode_native(
485485

486486
readConfigurationValues(code, javaConfig);
487487

488-
GameActivity_onCreate_C(code, rawSavedState, rawSavedSize);
488+
GameActivity_onCreate(code, rawSavedState, rawSavedSize);
489489

490490
code->gameTextInput = GameTextInput_init(env, 0);
491491
GameTextInput_setEventCallback(code->gameTextInput,
@@ -1130,12 +1130,8 @@ extern "C" int GameActivity_register(JNIEnv *env) {
11301130
NELEM(g_methods));
11311131
}
11321132

1133-
// XXX: This symbol is renamed with a _C suffix and then re-exported from
1134-
// Rust because Rust/Cargo don't give us a way to directly export symbols
1135-
// from C/C++ code: https://github.com/rust-lang/rfcs/issues/2771
1136-
//
11371133
extern "C" JNIEXPORT jlong JNICALL
1138-
Java_com_google_androidgamesdk_GameActivity_initializeNativeCode_C(
1134+
Java_com_google_androidgamesdk_GameActivity_initializeNativeCode(
11391135
JNIEnv *env, jobject javaGameActivity, jstring internalDataDir,
11401136
jstring obbDir, jstring externalDataDir, jobject jAssetMgr,
11411137
jbyteArray savedState, jobject javaConfig) {

android-activity/game-activity-csrc/game-activity/GameActivity.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,7 @@ typedef void GameActivity_createFunc(GameActivity* activity, void* savedState,
296296
* "android.app.func_name" string meta-data in your manifest to use a different
297297
* function.
298298
*/
299-
extern GameActivity_createFunc GameActivity_onCreate_C;
299+
extern GameActivity_createFunc GameActivity_onCreate;
300300

301301
/**
302302
* Finish the given activity. Its finish() method will be called, causing it

android-activity/game-activity-csrc/game-activity/native_app_glue/android_native_app_glue.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -616,12 +616,9 @@ static void onContentRectChanged(GameActivity* activity, const ARect *rect) {
616616
pthread_mutex_unlock(&android_app->mutex);
617617
}
618618

619-
// XXX: This symbol is renamed with a _C suffix and then re-exported from
620-
// Rust because Rust/Cargo don't give us a way to directly export symbols
621-
// from C/C++ code: https://github.com/rust-lang/rfcs/issues/2771
622-
//
619+
623620
JNIEXPORT
624-
void GameActivity_onCreate_C(GameActivity* activity, void* savedState,
621+
void GameActivity_onCreate(GameActivity* activity, void* savedState,
625622
size_t savedStateSize) {
626623
LOGV("Creating: %p", activity);
627624
activity->callbacks->onDestroy = onDestroy;

0 commit comments

Comments
 (0)