Skip to content

Commit d5fbc0f

Browse files
Urgauapiraino
andauthored
Remove (disable-by-default) mentions until formal decision
Co-authored-by: apiraino <apiraino@users.noreply.github.com>
1 parent 0205e14 commit d5fbc0f

File tree

1 file changed

+3
-12
lines changed

1 file changed

+3
-12
lines changed

src/github.rs

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1755,18 +1755,9 @@ impl<'q> IssuesQuery for Query<'q> {
17551755
.get_comment(&client, fk_initiating_comment.try_into()?)
17561756
.await?;
17571757

1758-
// To avoid constant (and counter-productive) pings we will only ping when
1759-
// - we are 2 weeks into the FCP
1760-
// - or when there are no concerns and we are at least 4 weeks into the FCP.
1761-
//
1762-
// FIXME: This should get T-compiler approval before being enabled by default
1763-
let should_mention = std::env::var("TRIAGEBOT_COMPILER_MENTION").is_ok() && {
1764-
let now = chrono::offset::Utc::now();
1765-
let time_diff = now - init_comment.created_at;
1766-
time_diff.num_weeks() == 2
1767-
|| (time_diff.num_weeks() >= 4 && fcp.concerns.is_empty())
1768-
};
1769-
1758+
// TODO: agree with the team(s) a policy to emit actual mentions to remind FCP
1759+
// voting member to cast their vote
1760+
let should_mention = false;
17701761
Some(crate::actions::FCPDetails {
17711762
bot_tracking_comment_html_url,
17721763
bot_tracking_comment_content,

0 commit comments

Comments
 (0)