&String to &str

Author: jackh726

src/db/jobs.rs

@@ -7,7 +7,7 @@ use tokio_postgres::Client as DbClient;
 use uuid::Uuid;
 
 pub struct JobSchedule {
-    pub name: String,
+    pub name: &'static str,
     pub schedule: Schedule,
     pub metadata: serde_json::Value,
 }
@@ -24,7 +24,7 @@ pub struct Job {
 
 pub async fn insert_job(
     db: &DbClient,
-    name: &String,
+    name: &str,
     scheduled_at: &DateTime<Utc>,
     metadata: &serde_json::Value,
 ) -> Result<()> {
@@ -76,7 +76,7 @@ pub async fn update_job_executed_at(db: &DbClient, id: &Uuid) -> Result<()> {
 
 pub async fn get_job_by_name_and_scheduled_at(
     db: &DbClient,
-    name: &String,
+    name: &str,
     scheduled_at: &DateTime<Utc>,
 ) -> Result<Job> {
     tracing::trace!(

src/handlers/docs_update.rs

@@ -30,7 +30,7 @@ const TITLE: &str = "Update books";
 
 pub fn job() -> JobSchedule {
     JobSchedule {
-        name: "docs_update".to_string(),
+        name: "docs_update",
         // Around 9am Pacific time on every Monday.
         schedule: Schedule::from_str("0 00 17 * * Mon *").unwrap(),
         metadata: serde_json::Value::Null,

src/handlers/jobs.rs

@@ -8,20 +8,20 @@ use super::Context;
 
 pub async fn handle_job(
     ctx: &Context,
-    name: &String,
+    name: &str,
     metadata: &serde_json::Value,
 ) -> anyhow::Result<()> {
-    match name.as_str() {
+    match name {
         "docs_update" => super::docs_update::handle_job().await,
         "rustc_commits" => {
             super::rustc_commits::synchronize_commits_inner(ctx, None).await;
             Ok(())
         }
-        _ => default(&name, &metadata),
+        _ => default(name, &metadata),
     }
 }
 
-fn default(name: &String, metadata: &serde_json::Value) -> anyhow::Result<()> {
+fn default(name: &str, metadata: &serde_json::Value) -> anyhow::Result<()> {
     tracing::trace!(
         "handle_job fell into default case: (name={:?}, metadata={:?})",
         name,

src/handlers/rustc_commits.rs

@@ -155,7 +155,7 @@ pub async fn synchronize_commits_inner(ctx: &Context, starter: Option<(String, u
 
 pub fn job() -> JobSchedule {
     JobSchedule {
-        name: "rustc_commits".to_string(),
+        name: "rustc_commits",
         // Every 30 minutes...
         schedule: Schedule::from_str("* 0,30 * * * * *").unwrap(),
         metadata: serde_json::Value::Null,