Skip to content

Commit 402d4f8

Browse files
committed
Use rfcbot-ishy style for fcps in the prioritization agenda
1 parent 03d9c84 commit 402d4f8

File tree

2 files changed

+18
-2
lines changed

2 files changed

+18
-2
lines changed

templates/_issues_rfcbot.tt

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
{% import "_issue.tt" as issue %}
2+
3+
{% macro render(issues, indent="", empty="None.") %}
4+
{%- for issue in issues %}
5+
{%- if issue.fcp_details is object %}
6+
{{indent}}- {{issue.fcp_details.disposition}}: [{{issue.title}} ({{issue.repo_name}}#{{issue.number}})]({{issue.fcp_details.bot_tracking_comment_html_url}})
7+
{{indent}}{{indent}}-{% for reviewer in issue.fcp_details.pending_reviewers %} @**{{reviewer.login}}**{%else%} no pending checkboxs{% endfor %}
8+
{{indent}}{{indent}}-{% for concern in issue.fcp_details.concerns %} [{{concern.name}} (by {{concern.reviewer_login}})]({{concern.concern_url}}){%else%} no pending concerns{% endfor -%}
9+
{% else %}
10+
{{indent}}- "{{issue.title}}" {{issue.repo_name}}#{{issue.number}}
11+
{%endif-%}
12+
{%else%}
13+
{{empty}}
14+
{%endfor-%}
15+
{% endmacro %}

templates/prioritization_agenda.tt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{% import "_issues.tt" as issues %}
22
{% import "_meetings.tt" as meetings %}
3+
{% import "_issues_rfcbot.tt" as issues_rfcbot %}
34

45
---
56
tags: weekly, rustc
@@ -28,9 +29,9 @@ note_id: xxx
2829
- Old MCPs (not seconded, take a look)
2930
{{-issues::render(issues=mcp_old_not_seconded, indent=" ", with_age=true, empty="No old proposals this time.")}}
3031
- Pending FCP requests (check your boxes!)
31-
{{-issues::render(issues=in_pre_fcp, indent=" ", empty="No pending FCP requests this time.")}}
32+
{{-issues_rfcbot::render(issues=in_pre_fcp, indent=" ", empty="No pending FCP requests this time.")}}
3233
- Things in FCP (make sure you're good with it)
33-
{{-issues::render(issues=in_fcp, indent=" ", empty="No FCP requests this time.")}}
34+
{{-issues_rfcbot::render(issues=in_fcp, indent=" ", empty="No FCP requests this time.")}}
3435
- Accepted MCPs
3536
{{-issues::render(issues=mcp_accepted, indent=" ", empty="No new accepted proposals this time.")}}
3637
- MCPs blocked on unresolved concerns

0 commit comments

Comments
 (0)