Merge pull request #1754 from rust-lang/archived-repo-validation

validate archived repositories have no teams

Author: marcoieni

src/validate.rs

@@ -51,6 +51,7 @@ static CHECKS: &[Check<fn(&Data, &mut Vec<String>)>] = checks![
     validate_zulip_stream_ids,
     validate_zulip_stream_extra_people,
     validate_repos,
+    validate_archived_repos,
     validate_branch_protections,
     validate_member_roles,
     validate_admin_access,
@@ -891,6 +892,15 @@ fn validate_repos(data: &Data, errors: &mut Vec<String>) {
     });
 }
 
+fn validate_archived_repos(data: &Data, errors: &mut Vec<String>) {
+    wrapper(data.archived_repos(), errors, |repo, _| {
+        if !repo.access.teams.is_empty() {
+            bail!("archived repo '{}' should not have any teams", repo.name);
+        }
+        Ok(())
+    });
+}
+
 /// Validate that branch protections make sense in combination with used bots.
 fn validate_branch_protections(data: &Data, errors: &mut Vec<String>) {
     let github_teams = data.github_teams();

tests/static-api/_expected/v1/repos.json

@@ -6,12 +6,7 @@
       "description": "An archived repo!",
       "homepage": null,
       "bots": [],
-      "teams": [
-        {
-          "name": "foo",
-          "permission": "maintain"
-        }
-      ],
+      "teams": [],
       "members": [],
       "branch_protections": [
         {

tests/static-api/_expected/v1/repos/archived_repo.json

@@ -4,12 +4,7 @@
   "description": "An archived repo!",
   "homepage": null,
   "bots": [],
-  "teams": [
-    {
-      "name": "foo",
-      "permission": "maintain"
-    }
-  ],
+  "teams": [],
   "members": [],
   "branch_protections": [
     {

tests/static-api/repos/archive/test-org/archived_repo.toml

@@ -4,7 +4,6 @@ description = "An archived repo!"
 bots = []
 
 [access.teams]
-foo = "maintain"
 
 [[branch-protections]]
 pattern = "master"