Work around missing permissions for rust-lang/rust branch protections

Author: Kobzol

sync-team/src/github/api/mod.rs

@@ -47,6 +47,10 @@ impl HttpClient {
         })
     }
 
+    pub fn uses_pat(&self) -> bool {
+        matches!(self.github_tokens, GitHubTokens::Pat(_))
+    }
+
     fn auth_header(&self, org: &str) -> anyhow::Result<HeaderValue> {
         let token = self.github_tokens.get_token(org)?;
         let mut auth = HeaderValue::from_str(&format!("token {}", token.expose_secret()))?;

sync-team/src/github/api/read.rs

@@ -7,6 +7,8 @@ use reqwest::Method;
 use std::collections::{HashMap, HashSet};
 
 pub(crate) trait GithubRead {
+    fn uses_pat(&self) -> bool;
+
     /// Get user names by user ids
     fn usernames(&self, ids: &[u64]) -> anyhow::Result<HashMap<u64, String>>;
 
@@ -58,6 +60,10 @@ impl GitHubApiRead {
 }
 
 impl GithubRead for GitHubApiRead {
+    fn uses_pat(&self) -> bool {
+        self.client.uses_pat()
+    }
+
     fn usernames(&self, ids: &[u64]) -> anyhow::Result<HashMap<u64, String>> {
         #[derive(serde::Deserialize)]
         #[serde(rename_all = "camelCase")]

sync-team/src/github/mod.rs

@@ -315,6 +315,13 @@ impl SyncGitHub {
         actual_repo: &api::Repo,
         expected_repo: &rust_team_data::v1::Repo,
     ) -> anyhow::Result<Vec<BranchProtectionDiff>> {
+        // The rust-lang/rust repository uses GitHub apps push allowance actors for its branch
+        // protections, which cannot be read without a PAT.
+        // To avoid errors, we simply return an empty diff here.
+        if !self.github.uses_pat() && actual_repo.org == "rust-lang" && actual_repo.name == "rust" {
+            return Ok(vec![]);
+        }
+
         let mut branch_protection_diffs = Vec::new();
         let mut actual_protections = self
             .github

sync-team/src/github/tests/test_utils.rs

@@ -438,6 +438,10 @@ impl GithubMock {
 }
 
 impl GithubRead for GithubMock {
+    fn uses_pat(&self) -> bool {
+        true
+    }
+
     fn usernames(&self, ids: &[UserId]) -> anyhow::Result<HashMap<UserId, String>> {
         Ok(self
             .users