Adjustments based on feedback

Author: sfackler

Cargo.toml

@@ -12,6 +12,9 @@ Utilities for handling networking sockets with a maximal amount of configuration
 possible intended.
 """
 
+[package.metadata.docs.rs]
+all-features = true
+
 [target."cfg(windows)".dependencies]
 ws2_32-sys = "0.2"
 winapi = "0.2"
@@ -21,6 +24,9 @@ kernel32-sys = "0.2"
 cfg-if = "0.1"
 libc = "0.2.14"
 
+[dev-dependencies]
+tempdir = "0.3"
+
 [features]
 reuseport = []
 pair = []

src/lib.rs

@@ -44,6 +44,8 @@
 #[cfg(windows)] extern crate winapi;
 #[cfg(windows)] extern crate ws2_32;
 
+#[cfg(test)] extern crate tempdir;
+
 use utils::NetInt;
 
 #[cfg(unix)] use libc::{sockaddr_storage, socklen_t};

src/socket.rs

@@ -43,7 +43,9 @@ impl Socket {
     /// This function is only available on Unix when the `pair` feature is
     /// enabled.
     #[cfg(all(unix, feature = "pair"))]
-    pub fn pair(domain: Domain, type_: Type, protocol: Option<Protocol>) -> io::Result<(Socket, Socket)> {
+    pub fn pair(domain: Domain,
+                type_: Type,
+                protocol: Option<Protocol>) -> io::Result<(Socket, Socket)> {
         let protocol = protocol.map(|p| p.0).unwrap_or(0);
         let sockets = sys::Socket::pair(domain.0, type_.0, protocol)?;
         Ok((Socket { inner: sockets.0 }, Socket { inner: sockets.1 }))
@@ -640,6 +642,15 @@ impl Domain {
     pub fn ipv6() -> Domain {
         Domain(c::AF_INET6)
     }
+
+    /// Domain for Unix socket communication, corresponding to `AF_UNIX`.
+    ///
+    /// This function is only available on Unix when the `unix` feature is
+    /// activated.
+    #[cfg(all(unix, feature = "unix"))]
+    pub fn unix() -> Domain {
+        Domain(c::AF_UNIX)
+    }
 }
 
 impl From<i32> for Domain {
@@ -734,4 +745,37 @@ mod test {
         let socket = Socket::new(Domain::ipv4(), Type::stream(), None).unwrap();
         socket.connect_timeout(&addr, Duration::from_millis(250)).unwrap();
     }
+
+    #[test]
+    #[cfg(all(unix, feature = "pair", feature = "unix"))]
+    fn pair() {
+        let (mut a, mut b) = Socket::pair(Domain::unix(), Type::stream(), None).unwrap();
+        a.write_all(b"hello world").unwrap();
+        let mut buf = [0; 11];
+        b.read_exact(&mut buf).unwrap();
+        assert_eq!(buf, &b"hello world"[..]);
+    }
+
+    #[test]
+    #[cfg(all(unix, feature = "unix"))]
+    fn unix() {
+        use tempdir::TempDir;
+
+        let dir = TempDir::new("unix").unwrap();
+        let addr = SockAddr::unix(dir.path().join("sock")).unwrap();
+
+        let listener = Socket::new(Domain::unix(), Type::stream(), None).unwrap();
+        listener.bind(&addr).unwrap();
+        listener.listen(10).unwrap();
+
+        let mut a = Socket::new(Domain::unix(), Type::stream(), None).unwrap();
+        a.connect(&addr).unwrap();
+
+        let mut b = listener.accept().unwrap().0;
+
+        a.write_all(b"hello world").unwrap();
+        let mut buf = [0; 11];
+        b.read_exact(&mut buf).unwrap();
+        assert_eq!(buf, &b"hello world"[..]);
+    }
 }