Skip to content

Commit fbbbc8f

Browse files
committed
detect another case of invalid manifest
1 parent 392d979 commit fbbbc8f

File tree

4 files changed

+26
-2
lines changed

4 files changed

+26
-2
lines changed

src/prepare.rs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,9 @@ impl<'a> Prepare<'a> {
124124
|| line.contains("no matching package named")
125125
{
126126
missing_deps = true;
127-
} else if line.contains("failed to parse manifest at") {
127+
} else if line.contains("failed to parse manifest at")
128+
|| line.contains("error: invalid table header")
129+
{
128130
broken_deps = true;
129131
}
130132
})
@@ -175,7 +177,9 @@ pub(crate) fn fetch_deps(
175177
if line.contains("failed to load source for dependency") {
176178
missing_deps = true;
177179
}
178-
if line.contains("failed to parse manifest at") {
180+
if line.contains("failed to parse manifest at")
181+
|| line.contains("error: invalid table header")
182+
{
179183
broken_deps = true;
180184
}
181185
})
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
[package]
2+
name = "invalid-cargotoml-content-deps"
3+
version = "0.1.0"
4+
authors = ["Pietro Albini <pietro@pietroalbini.org>"]
5+
edition = "2018"
6+
7+
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
8+
9+
[dependencies]
10+
url = "=0.5.9"
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
fn main() {
2+
println!("Hello, world!");
3+
}

tests/buildtest/mod.rs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,13 @@ test_prepare_error_stderr!(
195195
"failed to parse the version requirement `0.11\t` for dependency `parking_lot`"
196196
);
197197

198+
test_prepare_error_stderr!(
199+
test_invalid_cargotoml_syntax_deps,
200+
"invalid-cargotoml-syntax-deps",
201+
InvalidCargoTomlSyntaxInDependencies,
202+
"error: invalid table header"
203+
);
204+
198205
test_prepare_error_stderr!(
199206
test_yanked_deps,
200207
"yanked-deps",

0 commit comments

Comments
 (0)