fix clippy errors

Author: syphar

src/cmd/mod.rs

@@ -439,7 +439,7 @@ impl<'w, 'pl> Command<'w, 'pl> {
                 }
             };
 
-            let mut cmd = AsyncCommand::new(&binary);
+            let mut cmd = AsyncCommand::new(binary);
             cmd.args(&self.args);
 
             if managed_by_rustwide {

src/crates/git.rs

@@ -23,7 +23,7 @@ impl GitRepo {
 
         match res {
             Ok(out) => {
-                if let Some(shaline) = out.stdout_lines().get(0) {
+                if let Some(shaline) = out.stdout_lines().first() {
                     if !shaline.is_empty() {
                         return Some(shaline.to_string());
                     }

src/toolchain.rs

@@ -526,7 +526,7 @@ pub(crate) fn list_installed_toolchains(rustup_home: &Path) -> Result<Vec<Toolch
     let update_hashes = rustup_home.join("update-hashes");
 
     let mut result = Vec::new();
-    for entry in std::fs::read_dir(&rustup_home.join("toolchains"))? {
+    for entry in std::fs::read_dir(rustup_home.join("toolchains"))? {
         let entry = entry?;
         let name = entry
             .file_name()

src/utils.rs

@@ -30,6 +30,7 @@ pub(crate) fn file_lock<T>(
         .read(true)
         .write(true)
         .create(true)
+        .truncate(true)
         .open(path)?;
 
     let mut message_displayed = false;
@@ -108,26 +109,6 @@ fn improve_remove_error(error: std::io::Error, path: &Path) -> std::io::Error {
     )
 }
 
-#[cfg(test)]
-mod tests {
-    use super::*;
-
-    #[test]
-    fn custom_remove_error() {
-        let path = "test/path".as_ref();
-
-        let expected = "failed to remove 'test/path' : Kind(PermissionDenied)";
-        let tested = format!(
-            "{}",
-            improve_remove_error(
-                std::io::Error::from(std::io::ErrorKind::PermissionDenied),
-                path
-            )
-        );
-        assert_eq!(expected, tested);
-    }
-}
-
 pub(crate) fn normalize_path(path: &Path) -> PathBuf {
     let mut p = std::fs::canonicalize(path).unwrap_or_else(|_| path.to_path_buf());
 
@@ -163,6 +144,26 @@ pub(crate) fn normalize_path(path: &Path) -> PathBuf {
     p
 }
 
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    #[test]
+    fn custom_remove_error() {
+        let path = "test/path".as_ref();
+
+        let expected = "failed to remove 'test/path' : Kind(PermissionDenied)";
+        let tested = format!(
+            "{}",
+            improve_remove_error(
+                std::io::Error::from(std::io::ErrorKind::PermissionDenied),
+                path
+            )
+        );
+        assert_eq!(expected, tested);
+    }
+}
+
 #[cfg(test)]
 #[cfg(windows)]
 mod windows_tests {

tests/buildtest/inside_docker.rs

@@ -36,7 +36,7 @@ fn execute(test: &str) -> Result<(), Error> {
     let target_prefix = Path::new(TARGET_PREFIX);
     let container_exe = target_prefix.join(
         current_exe
-            .strip_prefix(&target_parent_dir)
+            .strip_prefix(target_parent_dir)
             .with_context(|_| "could not determine cargo target dir")?,
     );
     let src_mount = os_string!(&current_dir, ":", &container_prefix);