Take owned LocalToolchainName in Toolchain::from_local()

Author: djc

src/cli/proxy_mode.rs

@@ -40,7 +40,7 @@ pub async fn main(arg0: &str, current_dir: PathBuf, process: &Process) -> Result
 
     let toolchain = match toolchain {
         None => cfg.find_or_install_active_toolchain().await?.0,
-        Some(tc) => Toolchain::from_local(&tc, false, &cfg).await?,
+        Some(tc) => Toolchain::from_local(tc, false, &cfg).await?,
     };
 
     let cmd = toolchain.command(arg0)?;

src/cli/rustup_mode.rs

@@ -907,7 +907,7 @@ async fn run(
     install: bool,
 ) -> Result<ExitStatus> {
     let toolchain = toolchain.resolve(&cfg.get_default_host_triple()?)?;
-    let toolchain = Toolchain::from_local(&toolchain, install, cfg).await?;
+    let toolchain = Toolchain::from_local(toolchain, install, cfg).await?;
     let cmd = toolchain.command(&command[0])?;
     command::run_command_for_dir(cmd, &command[0], &command[1..])
 }

src/toolchain/toolchain.rs

@@ -39,11 +39,11 @@ pub(crate) struct Toolchain<'a> {
 
 impl<'a> Toolchain<'a> {
     pub(crate) async fn from_local(
-        toolchain_name: &LocalToolchainName,
+        name: LocalToolchainName,
         install_if_missing: bool,
         cfg: &'a Cfg<'a>,
     ) -> anyhow::Result<Toolchain<'a>> {
-        match Self::new(cfg, toolchain_name.clone()) {
+        match Self::new(cfg, name) {
             Ok(tc) => Ok(tc),
             Err(RustupError::ToolchainNotInstalled(ToolchainName::Official(desc)))
                 if install_if_missing =>