Make unnecessary_to_owned clippy happy

Signed-off-by: hi-rustin <rustin.liu@gmail.com>

Author: 0xPoe

download/src/lib.rs

@@ -162,7 +162,7 @@ pub mod curl {
         EASY.with(|handle| {
             let mut handle = handle.borrow_mut();
 
-            handle.url(&url.to_string())?;
+            handle.url(url.as_ref())?;
             handle.follow_location(true)?;
 
             if resume_from > 0 {

src/dist/dist.rs

@@ -822,7 +822,7 @@ fn try_update_from_dist_<'a>(
             let rust_package = m.get_package("rust")?;
             let rust_target_package = rust_package.get_target(Some(&toolchain.target.clone()))?;
 
-            for component in components.iter().copied() {
+            for component in components {
                 let mut component =
                     Component::new(component.to_string(), Some(toolchain.target.clone()), false);
                 if let Some(renamed) = m.rename_component(&component) {

src/dist/download.rs

@@ -52,7 +52,7 @@ impl<'a> DownloadCfg<'a> {
             let cached_result = file_hash(&target_file, self.notify_handler)?;
             if hash == cached_result {
                 (self.notify_handler)(Notification::FileAlreadyDownloaded);
-                (self.notify_handler)(Notification::ChecksumValid(&url.to_string()));
+                (self.notify_handler)(Notification::ChecksumValid(url.as_ref()));
                 return Ok(File { path: target_file });
             } else {
                 (self.notify_handler)(Notification::CachedFileChecksumFailed);
@@ -93,7 +93,7 @@ impl<'a> DownloadCfg<'a> {
         if hash != actual_hash {
             // Incorrect hash
             if partial_file_existed {
-                self.clean(&[hash.to_string() + &".partial".to_string()])?;
+                self.clean(&[hash.to_string() + ".partial"])?;
                 Err(anyhow!(RustupError::BrokenPartialFile))
             } else {
                 Err(RustupError::ChecksumFailed {
@@ -104,7 +104,7 @@ impl<'a> DownloadCfg<'a> {
                 .into())
             }
         } else {
-            (self.notify_handler)(Notification::ChecksumValid(&url.to_string()));
+            (self.notify_handler)(Notification::ChecksumValid(url.as_ref()));
 
             utils::rename_file(
                 "downloaded",

tests/cli-misc.rs

@@ -325,7 +325,7 @@ fn rustup_failed_path_search() {
         expect_err(
             config,
             broken,
-            &"unknown proxy name: 'fake_proxy'; valid proxy names are 'rustc', 'rustdoc', 'cargo', 'rust-lldb', 'rust-gdb', 'rust-gdbgui', 'rls', 'cargo-clippy', 'clippy-driver', 'cargo-miri', 'rustfmt', 'cargo-fmt'".to_string(),
+            "unknown proxy name: 'fake_proxy'; valid proxy names are 'rustc', 'rustdoc', 'cargo', 'rust-lldb', 'rust-gdb', 'rust-gdbgui', 'rls', 'cargo-clippy', 'clippy-driver', 'cargo-miri', 'rustfmt', 'cargo-fmt'",
         );
 
         // Hardlink will be automatically cleaned up by test setup code