Skip to content

Commit 6a5951b

Browse files
committed
notifications: list all missing components when skipping nightlies
Currently when updating and skipping nightlies due to missing required components only one such missing component is shown. Users might consider removing the requirement for the component and updating to the specific nightly that was missing it, only to find out that there is another, newly discovered missing component. With this change all required and missing components are shown when a nightly is skipped, so users might be able to quickly identify which nightly version, if any, has an acceptable set of missing components. Signed-off-by: Alejandro Martinez Ruiz <amr@redhat.com>
1 parent 201e71f commit 6a5951b

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

src/dist/notifications.rs

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,8 +176,13 @@ impl<'a> Display for Notification<'a> {
176176
),
177177
SkippingNightlyMissingComponent(components) => write!(
178178
f,
179-
"skipping nightly which is missing installed component '{}'",
180-
components[0].short_name_in_manifest()
179+
"skipping nightly which is missing installed component{} '{}'",
180+
if components.len() > 1 { "s" } else { "" },
181+
components
182+
.iter()
183+
.map(|component| component.short_name_in_manifest().to_owned())
184+
.collect::<Vec<_>>()
185+
.join("', '")
181186
),
182187
ForcingUnavailableComponent(component) => {
183188
write!(f, "Force-skipping unavailable component '{}'", component)

0 commit comments

Comments
 (0)