Skip to content

Commit e336d04

Browse files
committed
Auto merge of #144 - yvan-sraka:patch-0, r=komaeda
Add errors to exercises that compile without user changes Hi ! I played a bit with rustlings, and I felt that some exercises were incorrect because they passed the tests without me needing to edit the files! This gave me the feeling that the exercise was skiped! Especially when I use `rustlings watch`, it is easy to miss an exercise because the compilation error that is displayed is the one of the next exercise ... It is easy to identify "broken" exercises with: ```bash % find exercises -name "*.rs" | xargs -n 1 rustlings run ... ✅ Successfully ran exercises/move_semantics/move_semantics4.rs ✅ Successfully tested exercises/test2.rs ``` My suggestion is to make sure that these files trigger a compilation error by adding a simple syntax error (e.g. with `???` in the code that must change) so that our Rustacean can then play with it!
2 parents 4b0b709 + a71bc62 commit e336d04

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

exercises/move_semantics/move_semantics4.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ fn main() {
1616

1717
}
1818

19-
fn fill_vec(vec: Vec<i32>) -> Vec<i32> {
19+
// `fill_vec()` no longer take `vec: Vec<i32>` as argument
20+
fn fill_vec() -> Vec<i32> {
2021
let mut vec = vec;
2122

2223
vec.push(22);

exercises/test2.rs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,11 @@ mod tests {
1717

1818
#[test]
1919
fn returns_twice_of_positive_numbers() {
20-
assert_eq!(4, 4);
20+
assert_eq!(times_two(4), ???);
21+
}
22+
23+
#[test]
24+
fn returns_twice_of_negative_numbers() {
25+
// TODO write an assert for `times_two(-4)`
2126
}
2227
}

0 commit comments

Comments
 (0)