Skip to content

Commit c228a06

Browse files
committed
Auto merge of #272 - QuintenJohnson:fix/installation-warning-messages, r=fmoko
fix(installation): make fatal errors more obvious I initially ran the installation script without rust installed. The fact that the error message was labeled with WARNING made me unsure whether installation was successful or I needed to re-run after installing rust. There's an error code returned on fatal errors, but this change will make things clearer.
2 parents 83bbd9e + 17d0951 commit c228a06

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

install.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ if [ -x "$(command -v git)" ]
77
then
88
echo "SUCCESS: Git is installed"
99
else
10-
echo "WARNING: Git does not seem to be installed."
10+
echo "ERROR: Git does not seem to be installed."
1111
echo "Please download Git using your package manager or over https://git-scm.com/!"
1212
exit 1
1313
fi
@@ -16,7 +16,7 @@ if [ -x "$(command -v rustc)" ]
1616
then
1717
echo "SUCCESS: Rust is installed"
1818
else
19-
echo "WARNING: Rust does not seem to be installed."
19+
echo "ERROR: Rust does not seem to be installed."
2020
echo "Please download Rust using https://rustup.rs!"
2121
exit 1
2222
fi
@@ -25,7 +25,7 @@ if [ -x "$(command -v cargo)" ]
2525
then
2626
echo "SUCCESS: Cargo is installed"
2727
else
28-
echo "WARNING: Cargo does not seem to be installed."
28+
echo "ERROR: Cargo does not seem to be installed."
2929
echo "Please download Rust and Cargo using https://rustup.rs!"
3030
exit 1
3131
fi
@@ -75,7 +75,7 @@ MinRustVersion=1.31
7575
vercomp $RustVersion $MinRustVersion
7676
if [ $? -eq 2 ]
7777
then
78-
echo "WARNING: Rust version is too old: $RustVersion - needs at least $MinRustVersion"
78+
echo "ERROR: Rust version is too old: $RustVersion - needs at least $MinRustVersion"
7979
echo "Please update Rust with 'rustup update'"
8080
exit 1
8181
else

0 commit comments

Comments
 (0)