Skip to content

Commit ff58ac0

Browse files
authored
Merge pull request #1633 from Kobzol/doc-tendril
Add explanation why `tendril-0.2.4` is patched in `html5ever`
2 parents 183b954 + 24f376b commit ff58ac0

File tree

15 files changed

+6
-1
lines changed

15 files changed

+6
-1
lines changed

collector/compile-benchmarks/html5ever/Cargo.toml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,12 @@ log = "0"
2020
phf = "0.7"
2121
string_cache = "0.2.0"
2222
mac = "0"
23-
tendril = { path = "tendril-0.2.4" }
23+
24+
# Tendril 0.2.4 stopped compiling on stable as of Rust 1.69, because of UB caused by unaligned
25+
# references to packed structs fields.
26+
# The `tendril-0.2.4-patched` directory contains a patched version of tendril 0.2.4, which removes
27+
# the #[packed] attribute from several structs, thus making this benchmark compilable.
28+
tendril = { path = "tendril-0.2.4-patched" }
2429
heapsize = { version = ">=0.1.1, <0.4", optional = true }
2530
heapsize_plugin = { version = "0.1.0", optional = true }
2631

0 commit comments

Comments
 (0)