Skip to content

Commit fc69e44

Browse files
pnkfelixpnkfelix
committed
Initial triage report template.
1 parent c96118c commit fc69e44

File tree

1 file changed

+218
-0
lines changed

1 file changed

+218
-0
lines changed

‎triage/2024-06-03.md

Lines changed: 218 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,218 @@
1+
# 2024-06-03 Triage Log
2+
3+
TODO: Summary
4+
5+
Triage done by **@???**.
6+
Revision range: [a59072ec..1d52972d](https://perf.rust-lang.org/?start=a59072ec4fb6824213df5e9de8cae4812fd4fe97&end=1d52972dd8592edf4026aa577c8ce69acc0ac2d1&absolute=false&stat=instructions%3Au)
7+
8+
**Summary**:
9+
10+
| (instructions:u) | mean | range | count |
11+
|:----------------------------------:|:-----:|:--------------:|:-----:|
12+
| Regressions ❌ <br /> (primary) | 0.9% | [0.2%, 2.0%] | 28 |
13+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.2%, 0.6%] | 6 |
14+
| Improvements ✅ <br /> (primary) | -0.4% | [-1.2%, -0.2%] | 30 |
15+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.9%, -0.2%] | 24 |
16+
| All ❌✅ (primary) | 0.2% | [-1.2%, 2.0%] | 58 |
17+
18+
19+
3 Regressions, 5 Improvements, 6 Mixed; 4 of them in rollups
20+
57 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
Rollup of 5 pull requests [#125649](https://github.com/rust-lang/rust/pull/125649) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=c0d600385bb96cc23d3de8615ee37c01abba6c8a&end=f989d2f62500df1696eb797d8800a705293b43b9&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:-----:|:--------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | 1.3% | [0.5%, 2.1%] | 12 |
29+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.3%, 0.4%] | 3 |
30+
| Improvements ✅ <br /> (primary) | -0.1% | [-0.1%, -0.1%] | 1 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | 1.2% | [-0.1%, 2.1%] | 13 |
33+
34+
35+
Rollup of 5 pull requests [#125665](https://github.com/rust-lang/rust/pull/125665) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=8c4db851a7bb64173832e6602638204ebbd373a8&end=274499dd0ff53b81e93b80520f7afe25adaa2812&stat=instructions:u)
36+
37+
| (instructions:u) | mean | range | count |
38+
|:----------------------------------:|:----:|:------------:|:-----:|
39+
| Regressions ❌ <br /> (primary) | 0.5% | [0.5%, 0.5%] | 1 |
40+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.2%, 0.5%] | 7 |
41+
| Improvements ✅ <br /> (primary) | - | - | 0 |
42+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
43+
| All ❌✅ (primary) | 0.5% | [0.5%, 0.5%] | 1 |
44+
45+
46+
fn_arg_sanity_check: fix panic message [#125695](https://github.com/rust-lang/rust/pull/125695) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=5870f1ccbbb2661c92cdc356231386210a64d723&end=4cf5723dbe471ef0a32857b968b91498551f5e38&stat=instructions:u)
47+
48+
| (instructions:u) | mean | range | count |
49+
|:----------------------------------:|:----:|:------------:|:-----:|
50+
| Regressions ❌ <br /> (primary) | 0.8% | [0.8%, 0.9%] | 4 |
51+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.2%, 1.5%] | 19 |
52+
| Improvements ✅ <br /> (primary) | - | - | 0 |
53+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
54+
| All ❌✅ (primary) | 0.8% | [0.8%, 0.9%] | 4 |
55+
56+
57+
#### Improvements
58+
59+
Omit non-needs_drop drop_in_place in vtables [#122662](https://github.com/rust-lang/rust/pull/122662) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=7717a306b2678ba9ece19b723c76a6b3a89ba931&end=8c4db851a7bb64173832e6602638204ebbd373a8&stat=instructions:u)
60+
61+
| (instructions:u) | mean | range | count |
62+
|:----------------------------------:|:-----:|:--------------:|:-----:|
63+
| Regressions ❌ <br /> (primary) | - | - | 0 |
64+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
65+
| Improvements ✅ <br /> (primary) | -0.6% | [-1.5%, -0.2%] | 9 |
66+
| Improvements ✅ <br /> (secondary) | -0.5% | [-1.0%, -0.2%] | 18 |
67+
| All ❌✅ (primary) | -0.6% | [-1.5%, -0.2%] | 9 |
68+
69+
70+
Update cargo [#125682](https://github.com/rust-lang/rust/pull/125682) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=274499dd0ff53b81e93b80520f7afe25adaa2812&end=da159eb331b27df528185c616b394bb0e1d2a4bd&stat=instructions:u)
71+
72+
| (instructions:u) | mean | range | count |
73+
|:----------------------------------:|:-----:|:--------------:|:-----:|
74+
| Regressions ❌ <br /> (primary) | - | - | 0 |
75+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
76+
| Improvements ✅ <br /> (primary) | -0.5% | [-0.6%, -0.5%] | 3 |
77+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.5%, -0.2%] | 12 |
78+
| All ❌✅ (primary) | -0.5% | [-0.6%, -0.5%] | 3 |
79+
80+
81+
Stabilize `custom_code_classes_in_docs` feature [#124577](https://github.com/rust-lang/rust/pull/124577) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=466be510af95d377a4e9997a6ab7c4db5f91e9ec&end=05965ae238403d8c141170b411245a62aa046240&stat=instructions:u)
82+
83+
| (instructions:u) | mean | range | count |
84+
|:----------------------------------:|:-----:|:--------------:|:-----:|
85+
| Regressions ❌ <br /> (primary) | - | - | 0 |
86+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
87+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.8%, -0.2%] | 9 |
88+
| Improvements ✅ <br /> (secondary) | -0.7% | [-0.9%, -0.5%] | 2 |
89+
| All ❌✅ (primary) | -0.4% | [-0.8%, -0.2%] | 9 |
90+
91+
92+
Increase vtable layout size [#123572](https://github.com/rust-lang/rust/pull/123572) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=acaf0aeed0dfbfc4be9f996344e2c5f294cf5794&end=f2208b32971faba7fa6bf09bd0821adbf3db0c00&stat=instructions:u)
93+
94+
| (instructions:u) | mean | range | count |
95+
|:----------------------------------:|:-----:|:--------------:|:-----:|
96+
| Regressions ❌ <br /> (primary) | - | - | 0 |
97+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
98+
| Improvements ✅ <br /> (primary) | - | - | 0 |
99+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.6%, -0.2%] | 10 |
100+
| All ❌✅ (primary) | - | - | 0 |
101+
102+
103+
Avoid checking the edition as much as possible [#125828](https://github.com/rust-lang/rust/pull/125828) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=eda9d7f987de76b9d61c633a6ac328936e1b94f0&end=a6416d8907bc94ef1a032d54cb0443cde963e455&stat=instructions:u)
104+
105+
| (instructions:u) | mean | range | count |
106+
|:----------------------------------:|:-----:|:--------------:|:-----:|
107+
| Regressions ❌ <br /> (primary) | - | - | 0 |
108+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
109+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.4%, -0.3%] | 6 |
110+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.5%, -0.3%] | 4 |
111+
| All ❌✅ (primary) | -0.4% | [-0.4%, -0.3%] | 6 |
112+
113+
114+
#### Mixed
115+
116+
Create const block DefIds in typeck instead of ast lowering [#124650](https://github.com/rust-lang/rust/pull/124650) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=f989d2f62500df1696eb797d8800a705293b43b9&end=7717a306b2678ba9ece19b723c76a6b3a89ba931&stat=instructions:u)
117+
118+
| (instructions:u) | mean | range | count |
119+
|:----------------------------------:|:-----:|:--------------:|:-----:|
120+
| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.2%] | 2 |
121+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.2%, 0.2%] | 3 |
122+
| Improvements ✅ <br /> (primary) | -0.5% | [-0.6%, -0.3%] | 6 |
123+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.3%] | 1 |
124+
| All ❌✅ (primary) | -0.3% | [-0.6%, 0.2%] | 8 |
125+
126+
127+
Rollup of 8 pull requests [#125691](https://github.com/rust-lang/rust/pull/125691) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=da159eb331b27df528185c616b394bb0e1d2a4bd&end=751691271d76b8435559200b84d1947c2bd735bd&stat=instructions:u)
128+
129+
| (instructions:u) | mean | range | count |
130+
|:----------------------------------:|:-----:|:--------------:|:-----:|
131+
| Regressions ❌ <br /> (primary) | 0.4% | [0.4%, 0.4%] | 1 |
132+
| Regressions ❌ <br /> (secondary) | 1.2% | [1.2%, 1.2%] | 1 |
133+
| Improvements ✅ <br /> (primary) | -0.5% | [-0.6%, -0.4%] | 2 |
134+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.3%] | 1 |
135+
| All ❌✅ (primary) | -0.2% | [-0.6%, 0.4%] | 3 |
136+
137+
138+
don't inhibit random field reordering on repr(packed(1)) [#125360](https://github.com/rust-lang/rust/pull/125360) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=4cf5723dbe471ef0a32857b968b91498551f5e38&end=f2e1a3a80ae54734e1a3d306f31c2caebb05de9b&stat=instructions:u)
139+
140+
| (instructions:u) | mean | range | count |
141+
|:----------------------------------:|:-----:|:--------------:|:-----:|
142+
| Regressions ❌ <br /> (primary) | 0.9% | [0.6%, 1.3%] | 13 |
143+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.4%, 0.4%] | 2 |
144+
| Improvements ✅ <br /> (primary) | -0.7% | [-0.8%, -0.7%] | 4 |
145+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.7%, -0.3%] | 13 |
146+
| All ❌✅ (primary) | 0.5% | [-0.8%, 1.3%] | 17 |
147+
148+
149+
Enable DestinationPropagation by default. [#115105](https://github.com/rust-lang/rust/pull/115105) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=91c0823ee63e793d990bb9fed898dc95b5d6db51&end=cfb730450f847bb622243eaaab15e77e58d91767&stat=instructions:u)
150+
151+
| (instructions:u) | mean | range | count |
152+
|:----------------------------------:|:-----:|:--------------:|:-----:|
153+
| Regressions ❌ <br /> (primary) | 1.0% | [0.3%, 3.4%] | 18 |
154+
| Regressions ❌ <br /> (secondary) | 1.3% | [0.3%, 3.3%] | 22 |
155+
| Improvements ✅ <br /> (primary) | -0.5% | [-4.0%, -0.2%] | 23 |
156+
| Improvements ✅ <br /> (secondary) | -0.8% | [-1.6%, -0.2%] | 18 |
157+
| All ❌✅ (primary) | 0.2% | [-4.0%, 3.4%] | 41 |
158+
159+
160+
Revert "Auto merge of #115105 - cjgillot:dest-prop-default, r=oli-obk" [#125794](https://github.com/rust-lang/rust/pull/125794) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=434999efe6e9aa61afbd8b4ae86864d3ce91c533&end=366da30d554719e7490950aeea5d3f3a5927e313&stat=instructions:u)
161+
162+
| (instructions:u) | mean | range | count |
163+
|:----------------------------------:|:-----:|:--------------:|:-----:|
164+
| Regressions ❌ <br /> (primary) | 0.5% | [0.2%, 4.2%] | 18 |
165+
| Regressions ❌ <br /> (secondary) | 0.8% | [0.1%, 1.5%] | 20 |
166+
| Improvements ✅ <br /> (primary) | -1.0% | [-3.2%, -0.3%] | 15 |
167+
| Improvements ✅ <br /> (secondary) | -1.5% | [-3.1%, -0.4%] | 18 |
168+
| All ❌✅ (primary) | -0.2% | [-3.2%, 4.2%] | 33 |
169+
170+
171+
Rollup of 7 pull requests [#125824](https://github.com/rust-lang/rust/pull/125824) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=2a2c29aafa50bf6fe53d66b32070eba59f860ac3&end=ada5e2c7b5427a591e30baeeee2698a5eb6db0bd&stat=instructions:u)
172+
173+
| (instructions:u) | mean | range | count |
174+
|:----------------------------------:|:-----:|:--------------:|:-----:|
175+
| Regressions ❌ <br /> (primary) | 0.7% | [0.5%, 1.1%] | 3 |
176+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
177+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.4%, -0.4%] | 1 |
178+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
179+
| All ❌✅ (primary) | 0.4% | [-0.4%, 1.1%] | 4 |
180+
181+
182+
#### Untriaged Pull Requests
183+
184+
- [#125824 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/125824)
185+
- [#125794 Revert "Auto merge of #115105 - cjgillot:dest-prop-default, r=oli-obk"](https://github.com/rust-lang/rust/pull/125794)
186+
- [#125691 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/125691)
187+
- [#125665 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/125665)
188+
- [#125649 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/125649)
189+
- [#125360 don't inhibit random field reordering on repr(packed(1))](https://github.com/rust-lang/rust/pull/125360)
190+
- [#125144 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/125144)
191+
- [#125120 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/125120)
192+
- [#124700 Remove an unnecessary cast](https://github.com/rust-lang/rust/pull/124700)
193+
- [#124650 Create const block DefIds in typeck instead of ast lowering](https://github.com/rust-lang/rust/pull/124650)
194+
- [#124417 Make early lints translatable](https://github.com/rust-lang/rust/pull/124417)
195+
- [#124241 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/124241)
196+
- [#123909 Stabilize `Utf8Chunks`](https://github.com/rust-lang/rust/pull/123909)
197+
- [#123865 Update `expr` matcher for Edition 2024 and add `expr_2021` nonterminal](https://github.com/rust-lang/rust/pull/123865)
198+
- [#123812 Follow-up fixes to `report_return_mismatched_types`](https://github.com/rust-lang/rust/pull/123812)
199+
- [#123147 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/123147)
200+
- [#122976 Remove len argument from RawVec::reserve_for_push](https://github.com/rust-lang/rust/pull/122976)
201+
- [#122900 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/122900)
202+
- [#122671 Codegen const panic messages as function calls](https://github.com/rust-lang/rust/pull/122671)
203+
- [#122396 Less generic code for Vec allocations](https://github.com/rust-lang/rust/pull/122396)
204+
- [#121955 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/121955)
205+
- [#121804 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/121804)
206+
- [#121752 Detect unused struct impls pub trait](https://github.com/rust-lang/rust/pull/121752)
207+
- [#121462 Combine `Sub` and `Equate`](https://github.com/rust-lang/rust/pull/121462)
208+
- [#121345 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/121345)
209+
- [#120985 Update host LLVM on x64 Linux to LLVM 18](https://github.com/rust-lang/rust/pull/120985)
210+
- [#120863 Use intrinsics::debug_assertions in debug_assert_nounwind](https://github.com/rust-lang/rust/pull/120863)
211+
- [#120862 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/120862)
212+
- [#120809 Use `transmute_unchecked` in `NonZero::new`.](https://github.com/rust-lang/rust/pull/120809)
213+
- [#120588 wasm: Store rlib metadata in wasm object files](https://github.com/rust-lang/rust/pull/120588)
214+
215+
#### Nags requiring follow up
216+
217+
TODO: Nags
218+

0 commit comments

Comments
 (0)