Skip to content

Commit f6a1eb2

Browse files
committed
Fix bug in grouping
1 parent ad750fa commit f6a1eb2

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

site/static/compare.html

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,8 @@
177177

178178
#benches th {
179179
border-right: dotted 1px;
180+
text-align: left;
181+
word-break: break-word;
180182
}
181183

182184
.benchmark-name {
@@ -325,7 +327,7 @@ <h2>Comparing <span id="stat-header">{{stat}}</span> between <span id="before">{
325327
<tbody>
326328
<template v-for="run in bench.variants">
327329
<tr>
328-
<th v-if="run.index === 0" v-bind:rowspan="bench.variants.length"> {{bench.name}}</th>
330+
<th v-if="run.first" v-bind:rowspan="bench.variants.length">{{bench.name}}</th>
329331
<td>{{ run.casename }}</td>
330332
<td>
331333
<a v-bind:href="detailedQueryLink(data.a.commit, bench.name, run.casename)">
@@ -440,7 +442,6 @@ <h2>Comparing <span id="stat-header">{{stat}}</span> between <span id="before">{
440442
}
441443
function toVariants(name) {
442444
let variants = [];
443-
let index = 0;
444445
for (let d of data.a.data[name]) {
445446
const key = d[0];
446447
const datumA = d[1];
@@ -461,13 +462,11 @@ <h2>Comparing <span id="stat-header">{{stat}}</span> between <span id="before">{
461462
if (shouldShowBuild(key)) {
462463
variants.push({
463464
casename: key,
464-
index,
465465
datumA,
466466
datumB,
467467
percent,
468468
isDodgy,
469469
});
470-
index += 1;
471470
}
472471
}
473472

@@ -483,6 +482,10 @@ <h2>Comparing <span id="stat-header">{{stat}}</span> between <span id="before">{
483482
const maxPct = Math.max(...pcts).toFixed(1);
484483
const minPct = Math.min(...pcts).toFixed(1);
485484
const maxCasenameLen = Math.max(...variants.map(f => f.casename.length));
485+
if (variants.length > 0) {
486+
variants[0].first = true;
487+
}
488+
486489
return {
487490
name,
488491
variants,

0 commit comments

Comments
 (0)