Skip to content

Commit ddad887

Browse files
pnkfelixpnkfelix
committed
Initial triage report template.
1 parent 19bcdda commit ddad887

File tree

1 file changed

+251
-0
lines changed

1 file changed

+251
-0
lines changed

‎triage/2023-11-07.md

Lines changed: 251 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,251 @@
1+
# 2023-11-07 Triage Log
2+
3+
TODO: Summary
4+
5+
Triage done by **@???**.
6+
Revision range: [650991d62c3a2c80ba27009d06839adbb038bf5e..7b97a5ca8422d1495a8918106d3249aa405812d4](https://perf.rust-lang.org/?start=650991d62c3a2c80ba27009d06839adbb038bf5e&end=7b97a5ca8422d1495a8918106d3249aa405812d4&absolute=false&stat=instructions%3Au)
7+
8+
**Summary**:
9+
10+
| (instructions:u) | mean | range | count |
11+
|:----------------------------------:|:----:|:--------------:|:-----:|
12+
| Regressions ❌ <br /> (primary) | 5.8% | [0.3%, 104.7%] | 234 |
13+
| Regressions ❌ <br /> (secondary) | 2.7% | [0.5%, 11.6%] | 219 |
14+
| Improvements ✅ <br /> (primary) | - | - | 0 |
15+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
16+
| All ❌✅ (primary) | 5.8% | [0.3%, 104.7%] | 234 |
17+
18+
19+
10 Regressions, 4 Improvements, 3 Mixed; ??? of them in rollups
20+
68 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
Accept less invalid Rust in rustdoc [#117450](https://github.com/rust-lang/rust/pull/117450) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=d7d9f15be205b45d44700e7ac33b4f79b91f9680&end=50be22964035027398754e54cd3a497efb00f83e&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:----:|:-------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | 4.1% | [0.6%, 21.0%] | 17 |
29+
| Regressions ❌ <br /> (secondary) | 3.0% | [1.0%, 7.7%] | 6 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | 4.1% | [0.6%, 21.0%] | 17 |
33+
34+
35+
Fix order of implementations in the "implementations on foreign types" section [#117521](https://github.com/rust-lang/rust/pull/117521) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=c5afe0a61e39bdd912803eae8d1887a513bdd172&end=b20f40dba9feabf4b446d9b09d15996f0c046eff&stat=instructions:u)
36+
37+
| (instructions:u) | mean | range | count |
38+
|:----------------------------------:|:----:|:------------:|:-----:|
39+
| Regressions ❌ <br /> (primary) | 2.4% | [0.7%, 3.3%] | 3 |
40+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
41+
| Improvements ✅ <br /> (primary) | - | - | 0 |
42+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
43+
| All ❌✅ (primary) | 2.4% | [0.7%, 3.3%] | 3 |
44+
45+
46+
dropck_outlives check whether generator witness needs_drop [#117134](https://github.com/rust-lang/rust/pull/117134) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=e8418e092a643ef87019192af7ed6bbd23cc4a63&end=a2f5f9691b6ce64c1703feaf9363710dfd7a56cf&stat=instructions:u)
47+
48+
| (instructions:u) | mean | range | count |
49+
|:----------------------------------:|:----:|:------------:|:-----:|
50+
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.3%] | 5 |
51+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
52+
| Improvements ✅ <br /> (primary) | - | - | 0 |
53+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
54+
| All ❌✅ (primary) | 0.3% | [0.2%, 0.3%] | 5 |
55+
56+
57+
Add track_caller to transmute_copy [#117510](https://github.com/rust-lang/rust/pull/117510) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=1d6f05fd3735efc8f5af2f6278a3391543c2790b&end=49112241e96aaca646b1aa8ef704e494f56feed4&stat=instructions:u)
58+
59+
| (instructions:u) | mean | range | count |
60+
|:----------------------------------:|:----:|:------------:|:-----:|
61+
| Regressions ❌ <br /> (primary) | 0.4% | [0.4%, 0.4%] | 3 |
62+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
63+
| Improvements ✅ <br /> (primary) | - | - | 0 |
64+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
65+
| All ❌✅ (primary) | 0.4% | [0.4%, 0.4%] | 3 |
66+
67+
68+
Guarantee representation of None in NPO [#115333](https://github.com/rust-lang/rust/pull/115333) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=9c20ddd956426d577d77cb3f57a7db2227a3c6e9&end=1bb6553b967b69eed9ed8147e78b4f65cfc48e11&stat=instructions:u)
69+
70+
| (instructions:u) | mean | range | count |
71+
|:----------------------------------:|:-----:|:-------------:|:-----:|
72+
| Regressions ❌ <br /> (primary) | 12.2% | [0.9%, 30.1%] | 8 |
73+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
74+
| Improvements ✅ <br /> (primary) | - | - | 0 |
75+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
76+
| All ❌✅ (primary) | 12.2% | [0.9%, 30.1%] | 8 |
77+
78+
79+
clone less [#117540](https://github.com/rust-lang/rust/pull/117540) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=5020f7c3b8bd8bf57077389bca5c19f7911fde7a&end=f1b104f52350c800f78d4372aec52080bd6f9164&stat=instructions:u)
80+
81+
| (instructions:u) | mean | range | count |
82+
|:----------------------------------:|:-----:|:-------------:|:-----:|
83+
| Regressions ❌ <br /> (primary) | 16.5% | [1.1%, 30.2%] | 3 |
84+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
85+
| Improvements ✅ <br /> (primary) | - | - | 0 |
86+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
87+
| All ❌✅ (primary) | 16.5% | [1.1%, 30.2%] | 3 |
88+
89+
90+
Run tidy license checker on more workspaces [#115274](https://github.com/rust-lang/rust/pull/115274) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=f1b104f52350c800f78d4372aec52080bd6f9164&end=3aaa0f57b7b877ef58532a8de075d1e5a79142bf&stat=instructions:u)
91+
92+
| (instructions:u) | mean | range | count |
93+
|:----------------------------------:|:----:|:-------------:|:-----:|
94+
| Regressions ❌ <br /> (primary) | 8.8% | [3.3%, 17.8%] | 3 |
95+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
96+
| Improvements ✅ <br /> (primary) | - | - | 0 |
97+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
98+
| All ❌✅ (primary) | 8.8% | [3.3%, 17.8%] | 3 |
99+
100+
101+
Warn users who set `non_exhaustive_omitted_patterns` lint level on a match arm [#117094](https://github.com/rust-lang/rust/pull/117094) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=2db26d3d55387930f1b1dfb84810bcde5a787a09&end=f81d6f0cb00b1e314107b81bcb9aa72b9df9f564&stat=instructions:u)
102+
103+
| (instructions:u) | mean | range | count |
104+
|:----------------------------------:|:----:|:------------:|:-----:|
105+
| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.3%] | 3 |
106+
| Regressions ❌ <br /> (secondary) | 0.1% | [0.1%, 0.1%] | 4 |
107+
| Improvements ✅ <br /> (primary) | - | - | 0 |
108+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
109+
| All ❌✅ (primary) | 0.2% | [0.2%, 0.3%] | 3 |
110+
111+
112+
Rollup of 6 pull requests [#117590](https://github.com/rust-lang/rust/pull/117590) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=a42d94ebb883116f2867cbe3016d9bde9ca6d3f7&end=4b85902b438f791c5bfcb6b1c5b476d5b88e2bef&stat=instructions:u)
113+
114+
| (instructions:u) | mean | range | count |
115+
|:----------------------------------:|:-----:|:-------------:|:-----:|
116+
| Regressions ❌ <br /> (primary) | 12.7% | [0.4%, 30.9%] | 6 |
117+
| Regressions ❌ <br /> (secondary) | 16.2% | [8.1%, 24.2%] | 2 |
118+
| Improvements ✅ <br /> (primary) | - | - | 0 |
119+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
120+
| All ❌✅ (primary) | 12.7% | [0.4%, 30.9%] | 6 |
121+
122+
123+
enable parallel rustc front end in nightly builds [#117435](https://github.com/rust-lang/rust/pull/117435) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=fcca978aa0c9a7443649305dd0ed48c4691a1e89&end=f9b644636f8c74d1d9a3283dc65a6a6f02a97718&stat=instructions:u)
124+
125+
| (instructions:u) | mean | range | count |
126+
|:----------------------------------:|:----:|:------------:|:-----:|
127+
| Regressions ❌ <br /> (primary) | 2.9% | [0.4%, 5.1%] | 209 |
128+
| Regressions ❌ <br /> (secondary) | 2.7% | [0.4%, 9.1%] | 219 |
129+
| Improvements ✅ <br /> (primary) | - | - | 0 |
130+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
131+
| All ❌✅ (primary) | 2.9% | [0.4%, 5.1%] | 209 |
132+
133+
134+
#### Improvements
135+
136+
bootstrap: do not purge docs on CI environment [#117471](https://github.com/rust-lang/rust/pull/117471) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=b20f40dba9feabf4b446d9b09d15996f0c046eff&end=e8418e092a643ef87019192af7ed6bbd23cc4a63&stat=instructions:u)
137+
138+
| (instructions:u) | mean | range | count |
139+
|:----------------------------------:|:-----:|:--------------:|:-----:|
140+
| Regressions ❌ <br /> (primary) | - | - | 0 |
141+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
142+
| Improvements ✅ <br /> (primary) | -3.0% | [-3.0%, -3.0%] | 1 |
143+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
144+
| All ❌✅ (primary) | -3.0% | [-3.0%, -3.0%] | 1 |
145+
146+
147+
Remove support for compiler plugins. [#116412](https://github.com/rust-lang/rust/pull/116412) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=1bb6553b967b69eed9ed8147e78b4f65cfc48e11&end=5020f7c3b8bd8bf57077389bca5c19f7911fde7a&stat=instructions:u)
148+
149+
| (instructions:u) | mean | range | count |
150+
|:----------------------------------:|:------:|:---------------:|:-----:|
151+
| Regressions ❌ <br /> (primary) | - | - | 0 |
152+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
153+
| Improvements ✅ <br /> (primary) | -10.1% | [-23.2%, -0.9%] | 8 |
154+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
155+
| All ❌✅ (primary) | -10.1% | [-23.2%, -0.9%] | 8 |
156+
157+
158+
Rollup of 3 pull requests [#117564](https://github.com/rust-lang/rust/pull/117564) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=3aaa0f57b7b877ef58532a8de075d1e5a79142bf&end=a9b03ffe9b23a0832c897e25f246439d99d3026d&stat=instructions:u)
159+
160+
| (instructions:u) | mean | range | count |
161+
|:----------------------------------:|:-----:|:---------------:|:-----:|
162+
| Regressions ❌ <br /> (primary) | - | - | 0 |
163+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
164+
| Improvements ✅ <br /> (primary) | -9.6% | [-15.4%, -3.0%] | 4 |
165+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
166+
| All ❌✅ (primary) | -9.6% | [-15.4%, -3.0%] | 4 |
167+
168+
169+
Hint optimizer about try-reserved capacity [#117503](https://github.com/rust-lang/rust/pull/117503) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=4b85902b438f791c5bfcb6b1c5b476d5b88e2bef&end=f5ca57e153afaed818f8be88abf5ce46715c0f9a&stat=instructions:u)
170+
171+
| (instructions:u) | mean | range | count |
172+
|:----------------------------------:|:------:|:---------------:|:-----:|
173+
| Regressions ❌ <br /> (primary) | - | - | 0 |
174+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
175+
| Improvements ✅ <br /> (primary) | -10.4% | [-23.6%, -0.4%] | 6 |
176+
| Improvements ✅ <br /> (secondary) | -13.5% | [-19.5%, -7.5%] | 2 |
177+
| All ❌✅ (primary) | -10.4% | [-23.6%, -0.4%] | 6 |
178+
179+
180+
#### Mixed
181+
182+
Update cargo [#117462](https://github.com/rust-lang/rust/pull/117462) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=50be22964035027398754e54cd3a497efb00f83e&end=9d83ac217957eece2189eccf4a7232caec7232ee&stat=instructions:u)
183+
184+
| (instructions:u) | mean | range | count |
185+
|:----------------------------------:|:-----:|:--------------:|:-----:|
186+
| Regressions ❌ <br /> (primary) | 0.9% | [0.8%, 1.1%] | 2 |
187+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
188+
| Improvements ✅ <br /> (primary) | -0.5% | [-0.6%, -0.4%] | 2 |
189+
| Improvements ✅ <br /> (secondary) | -1.5% | [-1.5%, -1.5%] | 1 |
190+
| All ❌✅ (primary) | 0.2% | [-0.6%, 1.1%] | 4 |
191+
192+
193+
Rollup of 5 pull requests [#117459](https://github.com/rust-lang/rust/pull/117459) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=9d83ac217957eece2189eccf4a7232caec7232ee&end=09ac6e4b6dbec74dc4718191a6650a1b7e04a7a6&stat=instructions:u)
194+
195+
| (instructions:u) | mean | range | count |
196+
|:----------------------------------:|:-----:|:--------------:|:-----:|
197+
| Regressions ❌ <br /> (primary) | - | - | 0 |
198+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.3%, 0.5%] | 4 |
199+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.3%, -0.1%] | 3 |
200+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
201+
| All ❌✅ (primary) | -0.2% | [-0.3%, -0.1%] | 3 |
202+
203+
204+
Add all RPITITs when augmenting param-env with GAT bounds in `check_type_bounds` [#117131](https://github.com/rust-lang/rust/pull/117131) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=a2f5f9691b6ce64c1703feaf9363710dfd7a56cf&end=2520ca8566e596b10b0a163d31d9ce216876fafc&stat=instructions:u)
205+
206+
| (instructions:u) | mean | range | count |
207+
|:----------------------------------:|:-----:|:--------------:|:-----:|
208+
| Regressions ❌ <br /> (primary) | 32.3% | [0.3%, 99.8%] | 19 |
209+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
210+
| Improvements ✅ <br /> (primary) | - | - | 0 |
211+
| Improvements ✅ <br /> (secondary) | -1.4% | [-1.7%, -1.0%] | 6 |
212+
| All ❌✅ (primary) | 32.3% | [0.3%, 99.8%] | 19 |
213+
214+
215+
#### Untriaged Pull Requests
216+
217+
- [#117590 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/117590)
218+
- [#117540 clone less](https://github.com/rust-lang/rust/pull/117540)
219+
- [#117521 Fix order of implementations in the "implementations on foreign types" section](https://github.com/rust-lang/rust/pull/117521)
220+
- [#117510 Add track_caller to transmute_copy](https://github.com/rust-lang/rust/pull/117510)
221+
- [#117462 Update cargo](https://github.com/rust-lang/rust/pull/117462)
222+
- [#117459 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/117459)
223+
- [#117450 Accept less invalid Rust in rustdoc](https://github.com/rust-lang/rust/pull/117450)
224+
- [#117435 enable parallel rustc front end in nightly builds](https://github.com/rust-lang/rust/pull/117435)
225+
- [#117180 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/117180)
226+
- [#117134 dropck_outlives check whether generator witness needs_drop](https://github.com/rust-lang/rust/pull/117134)
227+
- [#117131 Add all RPITITs when augmenting param-env with GAT bounds in `check_type_bounds`](https://github.com/rust-lang/rust/pull/117131)
228+
- [#117094 Warn users who set `non_exhaustive_omitted_patterns` lint level on a match arm](https://github.com/rust-lang/rust/pull/117094)
229+
- [#116940 Rollup of 4 pull requests](https://github.com/rust-lang/rust/pull/116940)
230+
- [#116889 Eat close paren if capture_cfg to avoid unbalanced parens](https://github.com/rust-lang/rust/pull/116889)
231+
- [#116492 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/116492)
232+
- [#116391 exhaustiveness: Rework constructor splitting](https://github.com/rust-lang/rust/pull/116391)
233+
- [#116183 Always preserve DebugInfo in DeadStoreElimination.](https://github.com/rust-lang/rust/pull/116183)
234+
- [#116033 report `unused_import` for empty reexports even it is pub](https://github.com/rust-lang/rust/pull/116033)
235+
- [#115762 Explain revealing of opaque types in layout_of ParamEnv](https://github.com/rust-lang/rust/pull/115762)
236+
- [#115751 some inspect improvements](https://github.com/rust-lang/rust/pull/115751)
237+
- [#115740 Cache reachable_set on disk](https://github.com/rust-lang/rust/pull/115740)
238+
- [#115252 Represent MIR composite debuginfo as projections instead of aggregates](https://github.com/rust-lang/rust/pull/115252)
239+
- [#115082 Fix races conditions with `SyntaxContext` decoding](https://github.com/rust-lang/rust/pull/115082)
240+
- [#115025 Make subtyping explicit in MIR](https://github.com/rust-lang/rust/pull/115025)
241+
- [#114892 Remove conditional use of `Sharded` from query caches](https://github.com/rust-lang/rust/pull/114892)
242+
- [#114481 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/114481)
243+
- [#114459 Do not run ConstProp on mir_for_ctfe.](https://github.com/rust-lang/rust/pull/114459)
244+
- [#114321 get auto traits for parallel rustc](https://github.com/rust-lang/rust/pull/114321)
245+
- [#114023 Warn on inductive cycle in coherence leading to impls being considered not overlapping](https://github.com/rust-lang/rust/pull/114023)
246+
- [#114004 Add `riscv64gc-unknown-hermit` target](https://github.com/rust-lang/rust/pull/114004)
247+
248+
#### Nags requiring follow up
249+
250+
TODO: Nags
251+

0 commit comments

Comments
 (0)