Skip to content

Commit cd5b340

Browse files
committed
Do not show backend column when comparing backends
1 parent 69a77e6 commit cd5b340

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

site/frontend/src/pages/compare/compile/benchmarks.vue

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ export interface BenchmarkProps {
1616
benchmarkMap: CompileBenchmarkMap;
1717
filter: CompileBenchmarkFilter;
1818
stat: string;
19+
showBackend: boolean;
1920
}
2021
2122
const props = defineProps<BenchmarkProps>();
@@ -77,6 +78,7 @@ const secondaryHasNonRelevant = computed(
7778
:commit-b="data.b"
7879
:stat="stat"
7980
:benchmark-map="benchmarkMap"
81+
:show-backend="showBackend"
8082
>
8183
<template #header>
8284
<Section title="Primary" link="secondary" :linkUp="false"></Section>
@@ -92,6 +94,7 @@ const secondaryHasNonRelevant = computed(
9294
:commit-b="data.b"
9395
:stat="stat"
9496
:benchmark-map="benchmarkMap"
97+
:show-backend="showBackend"
9598
>
9699
<template #header>
97100
<Section title="Secondary" link="primary" :linkUp="true"></Section>

site/frontend/src/pages/compare/compile/compile-page.vue

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -260,6 +260,7 @@ const filteredSummary = computed(() => computeSummary(comparisons.value));
260260
:filter="filter"
261261
:stat="selector.stat"
262262
:benchmark-map="benchmarkMap"
263+
:show-backend="!selfCompareBackend"
263264
></Benchmarks>
264265
</template>
265266
<style lang="scss" scoped>

site/frontend/src/pages/compare/compile/table/comparisons-table.vue

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ const props = defineProps<{
1818
commitA: ArtifactDescription;
1919
commitB: ArtifactDescription;
2020
stat: string;
21+
showBackend: boolean;
2122
}>();
2223
2324
function prettifyRawNumber(number: number): string {
@@ -56,7 +57,7 @@ const unit = computed(() => {
5657
<th>Benchmark</th>
5758
<th>Profile</th>
5859
<th>Scenario</th>
59-
<th>Backend</th>
60+
<th v-if="showBackend">Backend</th>
6061
<th>% Change</th>
6162
<th class="narrow">
6263
Significance Threshold
@@ -95,7 +96,7 @@ const unit = computed(() => {
9596
{{ comparison.testCase.profile }}
9697
</td>
9798
<td>{{ comparison.testCase.scenario }}</td>
98-
<td>{{ comparison.testCase.backend }}</td>
99+
<td v-if="showBackend">{{ comparison.testCase.backend }}</td>
99100
<td>
100101
<div class="numeric-aligned">
101102
<span v-bind:class="percentClass(comparison.percent)">

0 commit comments

Comments
 (0)