Skip to content

Commit ca85215

Browse files
pnkfelixpnkfelix
committed
Initial triage report template.
1 parent dc2ac6a commit ca85215

File tree

1 file changed

+262
-0
lines changed

1 file changed

+262
-0
lines changed

‎triage/2023-12-18.md

Lines changed: 262 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,262 @@
1+
# 2023-12-19 Triage Log
2+
3+
TODO: Summary
4+
5+
Triage done by **@???**.
6+
Revision range: [57010939ed1d00076b4af0ed06a81ec69ea5e4a8..bf9229a2e366b4c311f059014a4aa08af16de5d8](https://perf.rust-lang.org/?start=57010939ed1d00076b4af0ed06a81ec69ea5e4a8&end=bf9229a2e366b4c311f059014a4aa08af16de5d8&absolute=false&stat=instructions%3Au)
7+
8+
**Summary**:
9+
10+
| (instructions:u) | mean | range | count |
11+
|:----------------------------------:|:-----:|:---------------:|:-----:|
12+
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.4%] | 9 |
13+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.2%, 0.9%] | 21 |
14+
| Improvements ✅ <br /> (primary) | -1.8% | [-10.8%, -0.1%] | 103 |
15+
| Improvements ✅ <br /> (secondary) | -1.2% | [-2.6%, -0.2%] | 93 |
16+
| All ❌✅ (primary) | -1.6% | [-10.8%, 0.4%] | 112 |
17+
18+
19+
6 Regressions, 9 Improvements, 3 Mixed; ??? of them in rollups
20+
67 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
rustc_passes: Enforce `rustc::potential_query_instability` lint [#118870](https://github.com/rust-lang/rust/pull/118870) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=56d25ba5ea3515ba2b361b6c4636373734eb27cc&end=c3def263a44e07e09ae6d57abfc8650227fb4972&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:-----:|:-------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | 13.5% | [0.5%, 44.5%] | 8 |
29+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | 13.5% | [0.5%, 44.5%] | 8 |
33+
34+
35+
fix --dry-run when the change-id warning is printed [#118789](https://github.com/rust-lang/rust/pull/118789) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=1aa6aefdc92555b3fbc5ae4c99365df9845a3e31&end=529047cfc3f4f7b3ea5aaac054408f368d153727&stat=instructions:u)
36+
37+
| (instructions:u) | mean | range | count |
38+
|:----------------------------------:|:----:|:------------:|:-----:|
39+
| Regressions ❌ <br /> (primary) | 0.9% | [0.8%, 1.0%] | 4 |
40+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.3%, 0.8%] | 18 |
41+
| Improvements ✅ <br /> (primary) | - | - | 0 |
42+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
43+
| All ❌✅ (primary) | 0.9% | [0.8%, 1.0%] | 4 |
44+
45+
46+
Rollup of 3 pull requests [#118982](https://github.com/rust-lang/rust/pull/118982) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=4d1bd0db7f489b22c6d8aa2385937a95412c015b&end=e6707df0de337976dce7577e68fc57adcd5e4842&stat=instructions:u)
47+
48+
| (instructions:u) | mean | range | count |
49+
|:----------------------------------:|:----:|:------------:|:-----:|
50+
| Regressions ❌ <br /> (primary) | 0.8% | [0.8%, 0.9%] | 4 |
51+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.0%, 0.8%] | 32 |
52+
| Improvements ✅ <br /> (primary) | - | - | 0 |
53+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
54+
| All ❌✅ (primary) | 0.8% | [0.8%, 0.9%] | 4 |
55+
56+
57+
Rollup of 5 pull requests [#119002](https://github.com/rust-lang/rust/pull/119002) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=a96d57bdb6d2bb6d233d7d5aaefc2995ab99be01&end=ca5c68a110099b17c3537e6e5840dbcc21b0e3ca&stat=instructions:u)
58+
59+
| (instructions:u) | mean | range | count |
60+
|:----------------------------------:|:-----:|:--------------:|:-----:|
61+
| Regressions ❌ <br /> (primary) | 0.2% | [0.1%, 0.5%] | 40 |
62+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.1%, 0.7%] | 36 |
63+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.3%, -0.3%] | 1 |
64+
| Improvements ✅ <br /> (secondary) | -0.1% | [-0.1%, -0.1%] | 2 |
65+
| All ❌✅ (primary) | 0.2% | [-0.3%, 0.5%] | 41 |
66+
67+
68+
More unescaping cleanups [#118897](https://github.com/rust-lang/rust/pull/118897) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=1c6a06183a1452c2772db370b572e38bac9c5d86&end=3ad8e2d129a67b0dc450d6ef1100ae41d2cd4b8a&stat=instructions:u)
69+
70+
| (instructions:u) | mean | range | count |
71+
|:----------------------------------:|:----:|:------------:|:-----:|
72+
| Regressions ❌ <br /> (primary) | 0.6% | [0.1%, 0.8%] | 5 |
73+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.2%, 0.7%] | 26 |
74+
| Improvements ✅ <br /> (primary) | - | - | 0 |
75+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
76+
| All ❌✅ (primary) | 0.6% | [0.1%, 0.8%] | 5 |
77+
78+
79+
coverage: Regression test for `assert!(!false)` [#119011](https://github.com/rust-lang/rust/pull/119011) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=445177724ac2beebf4faa5a3ffacb2adbe7e7846&end=9022e6a39c2714d2f447285c4ee7513bf153e3a9&stat=instructions:u)
80+
81+
| (instructions:u) | mean | range | count |
82+
|:----------------------------------:|:----:|:------------:|:-----:|
83+
| Regressions ❌ <br /> (primary) | 0.7% | [0.7%, 0.8%] | 4 |
84+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.3%, 0.6%] | 2 |
85+
| Improvements ✅ <br /> (primary) | - | - | 0 |
86+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
87+
| All ❌✅ (primary) | 0.7% | [0.7%, 0.8%] | 4 |
88+
89+
90+
#### Improvements
91+
92+
Rollup of 8 pull requests [#118838](https://github.com/rust-lang/rust/pull/118838) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=57010939ed1d00076b4af0ed06a81ec69ea5e4a8&end=21cce21d8c012f14cf74d5afddd795d324600dac&stat=instructions:u)
93+
94+
| (instructions:u) | mean | range | count |
95+
|:----------------------------------:|:-----:|:--------------:|:-----:|
96+
| Regressions ❌ <br /> (primary) | - | - | 0 |
97+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
98+
| Improvements ✅ <br /> (primary) | - | - | 0 |
99+
| Improvements ✅ <br /> (secondary) | -0.9% | [-1.0%, -0.9%] | 6 |
100+
| All ❌✅ (primary) | - | - | 0 |
101+
102+
103+
fix: stop emitting `.debug_pubnames` and `.debug_pubtypes` [#117962](https://github.com/rust-lang/rust/pull/117962) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=21cce21d8c012f14cf74d5afddd795d324600dac&end=e2a3c9b3f0895c866c104bd2fff2a8bf16eaf964&stat=instructions:u)
104+
105+
| (instructions:u) | mean | range | count |
106+
|:----------------------------------:|:-----:|:--------------:|:-----:|
107+
| Regressions ❌ <br /> (primary) | - | - | 0 |
108+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
109+
| Improvements ✅ <br /> (primary) | -2.1% | [-5.2%, -0.3%] | 24 |
110+
| Improvements ✅ <br /> (secondary) | -1.6% | [-3.1%, -0.2%] | 61 |
111+
| All ❌✅ (primary) | -2.1% | [-5.2%, -0.3%] | 24 |
112+
113+
114+
Unbreak non-unix non-windows bootstrap [#118894](https://github.com/rust-lang/rust/pull/118894) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=c3def263a44e07e09ae6d57abfc8650227fb4972&end=7176b8babdc55d68a485ab61940b10611cfa6c57&stat=instructions:u)
115+
116+
| (instructions:u) | mean | range | count |
117+
|:----------------------------------:|:------:|:---------------:|:-----:|
118+
| Regressions ❌ <br /> (primary) | - | - | 0 |
119+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
120+
| Improvements ✅ <br /> (primary) | -10.4% | [-30.8%, -0.6%] | 8 |
121+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
122+
| All ❌✅ (primary) | -10.4% | [-30.8%, -0.6%] | 8 |
123+
124+
125+
cache param env canonicalization [#117749](https://github.com/rust-lang/rust/pull/117749) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=e6d1b0ec9859e6f5c29aaa3b6525fb625bf354ad&end=d23e1a689426638a5146c204e09278433c509610&stat=instructions:u)
126+
127+
| (instructions:u) | mean | range | count |
128+
|:----------------------------------:|:-----:|:--------------:|:-----:|
129+
| Regressions ❌ <br /> (primary) | - | - | 0 |
130+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
131+
| Improvements ✅ <br /> (primary) | -2.0% | [-4.8%, -0.2%] | 32 |
132+
| Improvements ✅ <br /> (secondary) | -1.3% | [-1.4%, -1.3%] | 2 |
133+
| All ❌✅ (primary) | -2.0% | [-4.8%, -0.2%] | 32 |
134+
135+
136+
`-Ztrait-solver=next` to `-Znext-solver` [#118937](https://github.com/rust-lang/rust/pull/118937) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=529047cfc3f4f7b3ea5aaac054408f368d153727&end=2ecba0fa00b75e7291978c50bece407f17296f45&stat=instructions:u)
137+
138+
| (instructions:u) | mean | range | count |
139+
|:----------------------------------:|:-----:|:--------------:|:-----:|
140+
| Regressions ❌ <br /> (primary) | - | - | 0 |
141+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
142+
| Improvements ✅ <br /> (primary) | -0.9% | [-1.0%, -0.9%] | 4 |
143+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.8%, -0.3%] | 21 |
144+
| All ❌✅ (primary) | -0.9% | [-1.0%, -0.9%] | 4 |
145+
146+
147+
Use the LLVM option NoTrapAfterNoreturn [#110494](https://github.com/rust-lang/rust/pull/110494) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=e223c41028def5123ffd2a4a51a9109b1aae2c2e&end=02ad6676ddc7ea7bc3acd73f383180bc80185aeb&stat=instructions:u)
148+
149+
| (instructions:u) | mean | range | count |
150+
|:----------------------------------:|:-----:|:--------------:|:-----:|
151+
| Regressions ❌ <br /> (primary) | - | - | 0 |
152+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
153+
| Improvements ✅ <br /> (primary) | -0.9% | [-0.9%, -0.8%] | 4 |
154+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.8%, -0.3%] | 25 |
155+
| All ❌✅ (primary) | -0.9% | [-0.9%, -0.8%] | 4 |
156+
157+
158+
Add support for `--env` on `tracked_env::var` [#118830](https://github.com/rust-lang/rust/pull/118830) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=9022e6a39c2714d2f447285c4ee7513bf153e3a9&end=5e7025419d1b1359e4cb7cd365ba5900c8299089&stat=instructions:u)
159+
160+
| (instructions:u) | mean | range | count |
161+
|:----------------------------------:|:-----:|:--------------:|:-----:|
162+
| Regressions ❌ <br /> (primary) | - | - | 0 |
163+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
164+
| Improvements ✅ <br /> (primary) | -0.7% | [-0.8%, -0.7%] | 3 |
165+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.7%, -0.3%] | 7 |
166+
| All ❌✅ (primary) | -0.7% | [-0.8%, -0.7%] | 3 |
167+
168+
169+
don't fold ParamEnv in register_predicate_obligation [#119048](https://github.com/rust-lang/rust/pull/119048) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=d14e52b47ab27bcc3c3e083ed5f009a57db63eff&end=4283aeaca5c0c14864d4af3369a42c6b8b21f80f&stat=instructions:u)
170+
171+
| (instructions:u) | mean | range | count |
172+
|:----------------------------------:|:-----:|:--------------:|:-----:|
173+
| Regressions ❌ <br /> (primary) | - | - | 0 |
174+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
175+
| Improvements ✅ <br /> (primary) | -2.1% | [-7.3%, -0.2%] | 23 |
176+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.3%] | 1 |
177+
| All ❌✅ (primary) | -2.1% | [-7.3%, -0.2%] | 23 |
178+
179+
180+
resolve: Replace visibility table in resolver outputs with query feeding [#118657](https://github.com/rust-lang/rust/pull/118657) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=43dcc9b786c922251c3fbe75a0142f50f07053ca&end=321b6565a5f8ebf6f23622fc91ea1191a54f2a38&stat=instructions:u)
181+
182+
| (instructions:u) | mean | range | count |
183+
|:----------------------------------:|:-----:|:--------------:|:-----:|
184+
| Regressions ❌ <br /> (primary) | - | - | 0 |
185+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
186+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.5%, -0.1%] | 70 |
187+
| Improvements ✅ <br /> (secondary) | -0.6% | [-1.2%, -0.1%] | 42 |
188+
| All ❌✅ (primary) | -0.3% | [-0.5%, -0.1%] | 70 |
189+
190+
191+
#### Mixed
192+
193+
codegen_llvm: set `DW_AT_accessibility` [#115165](https://github.com/rust-lang/rust/pull/115165) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=e6707df0de337976dce7577e68fc57adcd5e4842&end=3f39cae1199a2a0217c3646a16d1ae7fa599130b&stat=instructions:u)
194+
195+
| (instructions:u) | mean | range | count |
196+
|:----------------------------------:|:-----:|:--------------:|:-----:|
197+
| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.3%] | 4 |
198+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
199+
| Improvements ✅ <br /> (primary) | -0.7% | [-0.7%, -0.6%] | 4 |
200+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.7%, -0.2%] | 22 |
201+
| All ❌✅ (primary) | -0.2% | [-0.7%, 0.3%] | 8 |
202+
203+
204+
Rollup of 6 pull requests [#119009](https://github.com/rust-lang/rust/pull/119009) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=5c927ab99946c312eed65f28aea15d2a035441f0&end=1c6a06183a1452c2772db370b572e38bac9c5d86&stat=instructions:u)
205+
206+
| (instructions:u) | mean | range | count |
207+
|:----------------------------------:|:-----:|:--------------:|:-----:|
208+
| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.2%] | 1 |
209+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.2%, 1.2%] | 8 |
210+
| Improvements ✅ <br /> (primary) | -1.3% | [-1.9%, -0.9%] | 8 |
211+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
212+
| All ❌✅ (primary) | -1.1% | [-1.9%, 0.2%] | 9 |
213+
214+
215+
Rollup of 5 pull requests [#119069](https://github.com/rust-lang/rust/pull/119069) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=cda4736f1eaad8af6f49388baa9b7e480df8e329&end=e004adb5561b724ac18f5b24584648ca4e42b6ad&stat=instructions:u)
216+
217+
| (instructions:u) | mean | range | count |
218+
|:----------------------------------:|:-----:|:--------------:|:-----:|
219+
| Regressions ❌ <br /> (primary) | - | - | 0 |
220+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.3%, 0.3%] | 2 |
221+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.3%, -0.1%] | 12 |
222+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.5%, -0.2%] | 13 |
223+
| All ❌✅ (primary) | -0.2% | [-0.3%, -0.1%] | 12 |
224+
225+
226+
#### Untriaged Pull Requests
227+
228+
- [#119069 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/119069)
229+
- [#119011 coverage: Regression test for `assert!(!false)`](https://github.com/rust-lang/rust/pull/119011)
230+
- [#119009 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/119009)
231+
- [#119002 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/119002)
232+
- [#118897 More unescaping cleanups](https://github.com/rust-lang/rust/pull/118897)
233+
- [#118661 Restore `const PartialEq`](https://github.com/rust-lang/rust/pull/118661)
234+
- [#118473 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/118473)
235+
- [#118420 Introduce support for `async gen` blocks](https://github.com/rust-lang/rust/pull/118420)
236+
- [#118405 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/118405)
237+
- [#118319 Rollup of 4 pull requests](https://github.com/rust-lang/rust/pull/118319)
238+
- [#118308 Don't warn an empty pattern unreachable if we're not sure the data is valid](https://github.com/rust-lang/rust/pull/118308)
239+
- [#117769 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/117769)
240+
- [#117736 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/117736)
241+
- [#117180 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/117180)
242+
- [#116940 Rollup of 4 pull requests](https://github.com/rust-lang/rust/pull/116940)
243+
- [#116915 Add an assume that the index is inbounds to slice::get_unchecked](https://github.com/rust-lang/rust/pull/116915)
244+
- [#116889 Eat close paren if capture_cfg to avoid unbalanced parens](https://github.com/rust-lang/rust/pull/116889)
245+
- [#116492 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/116492)
246+
- [#116391 exhaustiveness: Rework constructor splitting](https://github.com/rust-lang/rust/pull/116391)
247+
- [#116183 Always preserve DebugInfo in DeadStoreElimination.](https://github.com/rust-lang/rust/pull/116183)
248+
- [#116033 report `unused_import` for empty reexports even it is pub](https://github.com/rust-lang/rust/pull/116033)
249+
- [#115762 Explain revealing of opaque types in layout_of ParamEnv](https://github.com/rust-lang/rust/pull/115762)
250+
- [#115751 some inspect improvements](https://github.com/rust-lang/rust/pull/115751)
251+
- [#115740 Cache reachable_set on disk](https://github.com/rust-lang/rust/pull/115740)
252+
- [#115252 Represent MIR composite debuginfo as projections instead of aggregates](https://github.com/rust-lang/rust/pull/115252)
253+
- [#115165 codegen_llvm: set `DW_AT_accessibility`](https://github.com/rust-lang/rust/pull/115165)
254+
- [#115082 Fix races conditions with `SyntaxContext` decoding](https://github.com/rust-lang/rust/pull/115082)
255+
- [#115025 Make subtyping explicit in MIR](https://github.com/rust-lang/rust/pull/115025)
256+
- [#114892 Remove conditional use of `Sharded` from query caches](https://github.com/rust-lang/rust/pull/114892)
257+
- [#114571 Improve `print_tts`](https://github.com/rust-lang/rust/pull/114571)
258+
259+
#### Nags requiring follow up
260+
261+
TODO: Nags
262+

0 commit comments

Comments
 (0)