Skip to content

Commit bd27e5d

Browse files
authored
Merge pull request #1001 from rylev/change-IQR-multiplier
Change the amount by which we multiply the IQR to calculate significance
2 parents 8a0f901 + 5ea5172 commit bd27e5d

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

site/src/comparison.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -640,6 +640,8 @@ impl BenchmarkVariance {
640640
const SIGNFICANT_CHANGE_THRESHOLD: f64 = 5.0;
641641
/// The ratio of change that constitutes noisy data
642642
const NOISE_THRESHOLD: f64 = 0.001;
643+
/// The multiple of the IQR above Q3 that signifies significance
644+
const IQR_MULTIPLIER: f64 = 3.0;
643645

644646
fn push(&mut self, value: f64) {
645647
self.data.push(value);
@@ -677,7 +679,7 @@ impl BenchmarkVariance {
677679
let q1 = median(&pcs[..=h1_end]);
678680
let q3 = median(&pcs[h2_begin..]);
679681
let iqr = q3 - q1;
680-
q3 + (iqr * 1.5)
682+
q3 + (iqr * Self::IQR_MULTIPLIER)
681683
}
682684

683685
fn calculate_description(&mut self) {

0 commit comments

Comments
 (0)