Do not panic if no commits loaded on status page

Author: Mark-Simulacrum

site/src/api.rs

@@ -190,7 +190,7 @@ pub mod status {
 
     #[derive(Serialize, Debug)]
     pub struct Response {
-        pub last_commit: Commit,
+        pub last_commit: Option<Commit>,
         pub benchmarks: Vec<BenchmarkStatus>,
         pub missing: Vec<(Commit, MissingReason)>,
         pub current: Option<CurrentState>,

site/src/server.rs

@@ -249,30 +249,7 @@ fn prettify_log(log: &str) -> Option<String> {
 
 pub async fn handle_status_page(data: Arc<InputData>) -> status::Response {
     let idx = data.index.load();
-    let last_commit = idx.commits().last().unwrap().clone();
-
-    let mut benchmark_state = data
-        .conn()
-        .await
-        .get_error(ArtifactId::from(last_commit.clone()).lookup(&idx).unwrap())
-        .await
-        .into_iter()
-        .map(|(name, error)| {
-            let msg = if let Some(error) = error {
-                Some(prettify_log(&error).unwrap_or(error))
-            } else {
-                None
-            };
-            status::BenchmarkStatus {
-                name,
-                success: msg.is_none(),
-                error: msg,
-            }
-        })
-        .collect::<Vec<_>>();
-
-    benchmark_state.sort_by_key(|s| s.error.is_some());
-    benchmark_state.reverse();
+    let last_commit = idx.commits().last().cloned();
 
     let missing = data.missing_commits().await;
     // FIXME: no current builds
@@ -298,6 +275,33 @@ pub async fn handle_status_page(data: Arc<InputData>) -> status::Response {
         None
     };
 
+    let errors = if let Some(last) = &last_commit {
+        data.conn()
+            .await
+            .get_error(ArtifactId::from(last.clone()).lookup(&idx).unwrap())
+            .await
+    } else {
+        Default::default()
+    };
+    let mut benchmark_state = errors
+        .into_iter()
+        .map(|(name, error)| {
+            let msg = if let Some(error) = error {
+                Some(prettify_log(&error).unwrap_or(error))
+            } else {
+                None
+            };
+            status::BenchmarkStatus {
+                name,
+                success: msg.is_none(),
+                error: msg,
+            }
+        })
+        .collect::<Vec<_>>();
+
+    benchmark_state.sort_by_key(|s| s.error.is_some());
+    benchmark_state.reverse();
+
     status::Response {
         last_commit,
         benchmarks: benchmark_state,