Skip to content

Commit 8bfc52a

Browse files
authored
Merge pull request #2045 from Kobzol/compare-page-no-results
Make compare page slightly less misleading when there are no relevant results
2 parents 5343180 + 5c27a55 commit 8bfc52a

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

site/frontend/src/pages/compare/compile/table/comparisons-table.vue

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,11 @@ const unit = computed(() => {
4848
<div class="bench-table" :id="id">
4949
<slot name="header"></slot>
5050
<div v-if="comparisons.length === 0" style="text-align: center">
51-
{{ hasNonRelevant ? "No relevant results" : "No results" }}
51+
{{
52+
hasNonRelevant
53+
? "No relevant results (enable Filters -> Show non-relevant results to see all)"
54+
: "No results"
55+
}}
5256
</div>
5357
<table v-else class="benches compare">
5458
<thead>

site/frontend/src/pages/compare/summary/overall-summary.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ const summary = computed(() => props.summary);
1111
</script>
1212

1313
<template>
14-
<div class="main-summary">
14+
<div class="main-summary" v-if="summary.all.count > 0">
1515
<SummaryTable :summary="summary"></SummaryTable>
1616
<div style="position: absolute; right: 5px; top: 5px">
1717
<Tooltip style="margin-right: 1em">

0 commit comments

Comments
 (0)