Skip to content

Commit 88049ae

Browse files
rylevrylev
committed
Add perf triage for 2025-02-04
Signed-off-by: Ryan Levick <me@ryanlevick.com>
1 parent 0580064 commit 88049ae

File tree

1 file changed

+166
-0
lines changed

1 file changed

+166
-0
lines changed

‎triage/2025-02-04.md

Lines changed: 166 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,166 @@
1+
# 2025-02-04 Triage Log
2+
3+
A very quiet week with performance of primary benchmarks showing no change over all.
4+
5+
Triage done by **@rylev**.
6+
Revision range: [f7538506..01e4f19c](https://perf.rust-lang.org/?start=f753850659bdf5788332525f3fe395685929c682&end=01e4f19cc8027925ffe0885a86388b700e46bfab&absolute=false&stat=instructions%3Au)
7+
8+
**Summary**:
9+
10+
| (instructions:u) | mean | range | count |
11+
|:----------------------------------:|:-----:|:---------------:|:-----:|
12+
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.6%] | 32 |
13+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.1%, 1.1%] | 65 |
14+
| Improvements ✅ <br /> (primary) | -0.5% | [-1.0%, -0.2%] | 17 |
15+
| Improvements ✅ <br /> (secondary) | -3.1% | [-10.3%, -0.2%] | 20 |
16+
| All ❌✅ (primary) | 0.0% | [-1.0%, 0.6%] | 49 |
17+
18+
19+
5 Regressions, 2 Improvements, 5 Mixed; 6 of them in rollups
20+
49 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
Rollup of 10 pull requests [#136135](https://github.com/rust-lang/rust/pull/136135) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=0cffe5cb95e36d45a3e61f7b1f5a9b21eddd77b4&end=ebcf860e7345e3387b4c6961338c77424b43cbd5&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:----:|:------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.3%] | 2 |
29+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.2%, 0.3%] | 9 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | 0.3% | [0.2%, 0.3%] | 2 |
33+
34+
35+
Rollup of 9 pull requests [#136227](https://github.com/rust-lang/rust/pull/136227) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=61cc3e51f8bf5c12595a4d61a5ee9de812974b43&end=a1d7676d6a8c6ff13f9165e98cc25eeec66cb592&stat=instructions:u)
36+
37+
| (instructions:u) | mean | range | count |
38+
|:----------------------------------:|:----:|:------------:|:-----:|
39+
| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.2%] | 1 |
40+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.2%, 0.2%] | 6 |
41+
| Improvements ✅ <br /> (primary) | - | - | 0 |
42+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
43+
| All ❌✅ (primary) | 0.2% | [0.2%, 0.2%] | 1 |
44+
- Addressed by https://github.com/rust-lang/rust/pull/136253
45+
46+
47+
Merge `PatKind::Path` into `PatKind::Expr` [#134248](https://github.com/rust-lang/rust/pull/134248) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=0cc4f4f7b81f88df6bdd54b41d4a0b1703fd014d&end=ae5de6c759cd337ecdb2de4e94f47eaafb5d4606&stat=instructions:u)
48+
49+
| (instructions:u) | mean | range | count |
50+
|:----------------------------------:|:----:|:------------:|:-----:|
51+
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.4%] | 8 |
52+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.1%, 0.5%] | 9 |
53+
| Improvements ✅ <br /> (primary) | - | - | 0 |
54+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
55+
| All ❌✅ (primary) | 0.3% | [0.2%, 0.4%] | 8 |
56+
- https://github.com/rust-lang/rust/pull/134248#issuecomment-2610453075
57+
58+
59+
Insert null checks for pointer dereferences when debug assertions are enabled [#134424](https://github.com/rust-lang/rust/pull/134424) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=7f36543a48e52912ac6664a70c0a5b9d86509eaf&end=aa4cfd0809064503c69795e8e83ad067ad9e11a1&stat=instructions:u)
60+
61+
| (instructions:u) | mean | range | count |
62+
|:----------------------------------:|:----:|:------------:|:-----:|
63+
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.5%] | 7 |
64+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.2%, 0.5%] | 5 |
65+
| Improvements ✅ <br /> (primary) | - | - | 0 |
66+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
67+
| All ❌✅ (primary) | 0.3% | [0.2%, 0.5%] | 7 |
68+
- https://github.com/rust-lang/rust/pull/134424#issuecomment-2628695885
69+
70+
71+
Add a couple of missing `ensure_sufficient_stacks` [#136352](https://github.com/rust-lang/rust/pull/136352) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=a5db378dc14a40dd1580c27fb8362156446382c3&end=f2c4ccd852f68fb36dedc033239cb7c0fb1921ef&stat=instructions:u)
72+
73+
| (instructions:u) | mean | range | count |
74+
|:----------------------------------:|:----:|:------------:|:-----:|
75+
| Regressions ❌ <br /> (primary) | - | - | 0 |
76+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.2%, 0.3%] | 12 |
77+
| Improvements ✅ <br /> (primary) | - | - | 0 |
78+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
79+
| All ❌✅ (primary) | - | - | 0 |
80+
- https://github.com/rust-lang/rust/pull/136352#issuecomment-2633158239
81+
82+
83+
#### Improvements
84+
85+
Apply LTO config to rustdoc [#135832](https://github.com/rust-lang/rust/pull/135832) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=fdd1a3b02687817cea41f6bacae3d5fbed2b2cd0&end=77a455303bf08da8eef6236b2b4422a77cd25c42&stat=instructions:u)
86+
87+
| (instructions:u) | mean | range | count |
88+
|:----------------------------------:|:-----:|:--------------:|:-----:|
89+
| Regressions ❌ <br /> (primary) | - | - | 0 |
90+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
91+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.6%, -0.2%] | 9 |
92+
| Improvements ✅ <br /> (secondary) | -0.6% | [-1.4%, -0.2%] | 4 |
93+
| All ❌✅ (primary) | -0.3% | [-0.6%, -0.2%] | 9 |
94+
95+
96+
fix autodiff compile time regression [#136413](https://github.com/rust-lang/rust/pull/136413) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=7daf4cf911c30e48c78f5e155c029397fdd82392&end=a5db378dc14a40dd1580c27fb8362156446382c3&stat=instructions:u)
97+
98+
| (instructions:u) | mean | range | count |
99+
|:----------------------------------:|:------:|:----------------:|:-----:|
100+
| Regressions ❌ <br /> (primary) | - | - | 0 |
101+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
102+
| Improvements ✅ <br /> (primary) | -30.3% | [-30.6%, -29.7%] | 4 |
103+
| Improvements ✅ <br /> (secondary) | -30.1% | [-32.0%, -28.2%] | 2 |
104+
| All ❌✅ (primary) | -30.3% | [-30.6%, -29.7%] | 4 |
105+
106+
107+
#### Mixed
108+
109+
Rollup of 8 pull requests [#136185](https://github.com/rust-lang/rust/pull/136185) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=aa6f5ab18e67cb815f73e0d53d217bc54b0da924&end=fdd1a3b02687817cea41f6bacae3d5fbed2b2cd0&stat=instructions:u)
110+
111+
| (instructions:u) | mean | range | count |
112+
|:----------------------------------:|:-----:|:--------------:|:-----:|
113+
| Regressions ❌ <br /> (primary) | - | - | 0 |
114+
| Regressions ❌ <br /> (secondary) | 0.7% | [0.2%, 1.6%] | 3 |
115+
| Improvements ✅ <br /> (primary) | - | - | 0 |
116+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.8%, -0.4%] | 6 |
117+
| All ❌✅ (primary) | - | - | 0 |
118+
* https://github.com/rust-lang/rust/pull/136185#issuecomment-2635291385
119+
120+
121+
Revert #135914: Remove usages of `QueryNormalizer` in the compiler [#136011](https://github.com/rust-lang/rust/pull/136011) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=aeba3c60f506218396883cb57812de2f3e067112&end=122fb29eb639aae852b9dcba0fd7aefc691be118&stat=instructions:u)
122+
123+
| (instructions:u) | mean | range | count |
124+
|:----------------------------------:|:-----:|:---------------:|:-----:|
125+
| Regressions ❌ <br /> (primary) | - | - | 0 |
126+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.2%, 0.3%] | 16 |
127+
| Improvements ✅ <br /> (primary) | -0.4% | [-1.1%, -0.2%] | 24 |
128+
| Improvements ✅ <br /> (secondary) | -5.9% | [-10.4%, -0.9%] | 10 |
129+
| All ❌✅ (primary) | -0.4% | [-1.1%, -0.2%] | 24 |
130+
- https://github.com/rust-lang/rust/pull/136011#issuecomment-2635292874
131+
132+
133+
Rollup of 9 pull requests [#136318](https://github.com/rust-lang/rust/pull/136318) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=a730edcd67c7cb29d4458e170d4eb290387c27c3&end=6c1d960d88dd3755548b3818630acb63fa98187e&stat=instructions:u)
134+
135+
| (instructions:u) | mean | range | count |
136+
|:----------------------------------:|:-----:|:--------------:|:-----:|
137+
| Regressions ❌ <br /> (primary) | 0.3% | [0.1%, 0.4%] | 8 |
138+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.2%, 0.2%] | 1 |
139+
| Improvements ✅ <br /> (primary) | - | - | 0 |
140+
| Improvements ✅ <br /> (secondary) | -0.1% | [-0.1%, -0.1%] | 2 |
141+
| All ❌✅ (primary) | 0.3% | [0.1%, 0.4%] | 8 |
142+
- It appears that #136180 is the culprit for this regression. I'm not sure it's worth addressing though.
143+
144+
145+
Rollup of 9 pull requests [#136332](https://github.com/rust-lang/rust/pull/136332) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=25a16572a36321deae83546b63f5595d75361179&end=7f36543a48e52912ac6664a70c0a5b9d86509eaf&stat=instructions:u)
146+
147+
| (instructions:u) | mean | range | count |
148+
|:----------------------------------:|:-----:|:--------------:|:-----:|
149+
| Regressions ❌ <br /> (primary) | 43.3% | [42.1%, 44.0%] | 4 |
150+
| Regressions ❌ <br /> (secondary) | 42.8% | [39.0%, 46.6%] | 2 |
151+
| Improvements ✅ <br /> (primary) | - | - | 0 |
152+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.2%] | 4 |
153+
| All ❌✅ (primary) | 43.3% | [42.1%, 44.0%] | 4 |
154+
- Fixed by https://github.com/rust-lang/rust/pull/136413
155+
156+
157+
Rollup of 6 pull requests [#136389](https://github.com/rust-lang/rust/pull/136389) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=e08cd3cf05e5bfa3323cc21ea8f81f4a15a2f969&end=8239a37f9c0951a037cfc51763ea52a20e71e6bd&stat=instructions:u)
158+
159+
| (instructions:u) | mean | range | count |
160+
|:----------------------------------:|:-----:|:--------------:|:-----:|
161+
| Regressions ❌ <br /> (primary) | 0.1% | [0.1%, 0.1%] | 1 |
162+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.3%, 0.5%] | 2 |
163+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.3%, -0.3%] | 1 |
164+
| Improvements ✅ <br /> (secondary) | -0.2% | [-0.3%, -0.1%] | 2 |
165+
| All ❌✅ (primary) | -0.1% | [-0.3%, 0.1%] | 2 |
166+
- Perf is a wash so I don't think it's worth investigating.

0 commit comments

Comments
 (0)