Display more compile benchmark metadata in the compare dashboard

Author: Kobzol

collector/src/compile/benchmark/mod.rs

@@ -72,6 +72,10 @@ impl BenchmarkConfig {
     pub fn artifact(&self) -> ArtifactType {
         self.artifact
     }
+
+    pub fn iterations(&self) -> usize {
+        self.runs
+    }
 }
 
 #[derive(Ord, PartialOrd, Eq, PartialEq, Clone, Hash)]

site/frontend/src/pages/compare/compile/benchmarks.vue

@@ -3,12 +3,17 @@ import {computed, h} from "vue";
 import ComparisonsTable from "./comparisons-table.vue";
 import {TestCaseComparison} from "../data";
 import {CompareResponse} from "../types";
-import {CompileBenchmarkFilter, CompileTestCase} from "./common";
+import {
+  CompileBenchmarkFilter,
+  CompileBenchmarkMap,
+  CompileTestCase,
+} from "./common";
 
 export interface BenchmarkProps {
   data: CompareResponse;
   testCases: TestCaseComparison<CompileTestCase>[];
   allTestCases: TestCaseComparison<CompileTestCase>[];
+  benchmarkMap: CompileBenchmarkMap;
   filter: CompileBenchmarkFilter;
   stat: string;
 }
@@ -71,6 +76,7 @@ const secondaryHasNonRelevant = computed(
       :commit-a="data.a"
       :commit-b="data.b"
       :stat="stat"
+      :benchmark-map="benchmarkMap"
     >
       <template #header>
         <Section title="Primary" link="secondary" :linkUp="false"></Section>
@@ -85,6 +91,7 @@ const secondaryHasNonRelevant = computed(
       :commit-a="data.a"
       :commit-b="data.b"
       :stat="stat"
+      :benchmark-map="benchmarkMap"
     >
       <template #header>
         <Section title="Secondary" link="primary" :linkUp="true"></Section>

site/frontend/src/pages/compare/compile/common.ts

@@ -54,10 +54,18 @@ export type Category = "primary" | "secondary";
 
 export type CompileBenchmarkMap = Dict<CompileBenchmarkMetadata>;
 
+export interface CargoProfileMetadata {
+  debug: string | null;
+  lto: string | null;
+  codegen_units: number | null;
+}
+
 export interface CompileBenchmarkMetadata {
   name: string;
   category: Category;
   binary: boolean | null;
+  iterations: number | null;
+  release_profile: CargoProfileMetadata;
 }
 
 export interface CompileBenchmarkComparison {

site/frontend/src/pages/compare/compile/comparisons-table.vue

@@ -3,11 +3,12 @@ import {TestCaseComparison} from "../data";
 import Tooltip from "../tooltip.vue";
 import {ArtifactDescription} from "../types";
 import {percentClass} from "../shared";
-import {CompileTestCase} from "./common";
+import {CompileBenchmarkMap, CompileTestCase} from "./common";
 
 const props = defineProps<{
   id: string;
   comparisons: TestCaseComparison<CompileTestCase>[];
+  benchmarkMap: CompileBenchmarkMap;
   hasNonRelevant: boolean;
   showRawData: boolean;
   commitA: ArtifactDescription;
@@ -57,6 +58,36 @@ function detailedQueryRawDataLink(
 function prettifyRawNumber(number: number): string {
   return number.toLocaleString();
 }
+
+function generateBenchmarkTooltip(testCase: CompileTestCase): string {
+  const metadata = props.benchmarkMap[testCase.benchmark] ?? null;
+  if (metadata === null) {
+    return "<No metadata found>";
+  }
+  let tooltip = `Benchmark: ${testCase.benchmark}
+Category: ${metadata.category}
+`;
+  if (metadata.binary !== null) {
+    tooltip += `Artifact: ${metadata.binary ? "binary" : "library"}\n`;
+  }
+  if (metadata.iterations !== null) {
+    tooltip += `Iterations: ${metadata.iterations}\n`;
+  }
+  if (testCase.profile === "opt" && metadata.release_profile !== null) {
+    const {lto, debug, codegen_units} = metadata.release_profile;
+    if (lto !== null) {
+      tooltip += `LTO: ${lto}\n`;
+    }
+    if (debug !== null) {
+      tooltip += `Debuginfo: ${debug}\n`;
+    }
+    if (codegen_units !== null) {
+      tooltip += `Codegen units: ${codegen_units}\n`;
+    }
+  }
+
+  return tooltip;
+}
 </script>
 
 <template>
@@ -101,7 +132,7 @@ function prettifyRawNumber(number: number): string {
       <tbody>
         <template v-for="comparison in comparisons">
           <tr>
-            <td>
+            <td :title="generateBenchmarkTooltip(comparison.testCase)">
               <a
                 v-bind:href="benchmarkLink(comparison.testCase.benchmark)"
                 class="silent-link"

site/frontend/src/pages/compare/compile/compile-page.vue

@@ -184,5 +184,6 @@ const filteredSummary = computed(() => computeSummary(comparisons.value));
     :all-test-cases="allComparisons"
     :filter="filter"
     :stat="selector.stat"
+    :benchmark-map="benchmarkMap"
   ></Benchmarks>
 </template>

site/src/api.rs

@@ -131,6 +131,7 @@ pub mod bootstrap {
 }
 
 pub mod comparison {
+    use crate::benchmark_metadata::ProfileMetadata;
     use crate::comparison::Metric;
     use collector::Bound;
     use database::Date;
@@ -153,6 +154,8 @@ pub mod comparison {
         // benchmark, the metadata for it will no longer be available, so we might not always have
         // access to the metadata.
         pub binary: Option<bool>,
+        pub iterations: Option<u32>,
+        pub release_profile: Option<ProfileMetadata>,
     }
 
     #[derive(Debug, Clone, Serialize)]

site/src/benchmark_metadata/mod.rs

@@ -4,9 +4,10 @@ use rust_embed::RustEmbed;
 use collector::compile::benchmark::category::Category;
 use collector::compile::benchmark::BenchmarkConfig;
 
-use crate::benchmark_metadata::metadata::{ProfileMetadata, SERIALIZED_SUITE_NAME};
+use crate::benchmark_metadata::metadata::SERIALIZED_SUITE_NAME;
 
 mod metadata;
+pub use metadata::ProfileMetadata;
 
 #[derive(Debug, Clone)]
 pub struct CompileBenchmarkMetadata {

site/src/comparison.rs

@@ -183,6 +183,8 @@ pub async fn handle_compare(
                 name,
                 category,
                 binary: metadata.map(|m| m.perf_config.artifact() == ArtifactType::Binary),
+                iterations: metadata.map(|m| m.perf_config.iterations() as u32),
+                release_profile: metadata.map(|m| m.release_metadata.clone()),
             }
         })
         .collect();