Merge pull request #920 from rylev/fix-compare-page

Fix compare page when no query params supplied

Author: Mark-Simulacrum

site/static/compare.html

@@ -376,11 +376,8 @@ <h2>Comparing <span id="stat-header">{{stat}}</span> between <span id="before">{
     <script src="shared.js"></script>
     <script>
         function findQueryParam(name) {
-            if (!window.location.search) {
-                return null;
-            }
-            let urlParams = window.location.search.substring(1).split("&").map(x => x.split("="));
-            let pair = urlParams.find(x => x[0] === name)
+            let urlParams = window.location.search?.substring(1).split("&").map(x => x.split("="));
+            let pair = urlParams?.find(x => x[0] === name)
             if (pair) {
                 return unescape(pair[1]);
             }
@@ -436,7 +433,10 @@ <h2>Comparing <span id="stat-header">{{stat}}</span> between <span id="before">{
                         for (let d of data.a.data[name]) {
                             const key = d[0];
                             const datumA = d[1];
-                            const datumB = data.b.data[name].find(x => x[0] == key)[1];
+                            const datumB = data.b.data[name]?.find(x => x[0] == key)?.[1];
+                            if (!datumB) {
+                                continue;
+                            }
                             let percent = (100 * (datumB - datumA) / datumA).toFixed(1);
                             if (percent === "-0.0") {
                                 percent = "0.0";
@@ -445,7 +445,7 @@ <h2>Comparing <span id="stat-header">{{stat}}</span> between <span id="before">{
                             let isDodgy = false;
                             if (data.variance) {
                                 let variance = data.variance[name + "-" + key];
-                                isDodgy = !!(variance && variance.description && variance.description.type != "Normal");
+                                isDodgy = (variance?.description?.type ?? "Normal") != "Normal";
                             }
                             if (shouldShowBuild(key)) {
                                 variants.push({