Skip to content

Commit 4a9046b

Browse files
committed
Use click.prevent instead of event.preventDefault();
1 parent 74c7411 commit 4a9046b

File tree

1 file changed

+9
-12
lines changed
  • site/frontend/src/pages/detailed-query

1 file changed

+9
-12
lines changed

site/frontend/src/pages/detailed-query/page.vue

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -163,8 +163,7 @@ const tableData = computed(() => {
163163
});
164164
const artifactData = computed(() => createArtifactData(data.value));
165165
166-
function handlePerfettoClick(event: Event, link: string, title: string) {
167-
event.preventDefault();
166+
function handlePerfettoClick(link: string, title: string) {
168167
openTraceInPerfetto(link, title);
169168
}
170169
@@ -316,16 +315,15 @@ function DeltaComponent({delta}: {delta: DeltaData | null}) {
316315
<a :href="downloadLinksData.baseLinks.crox">crox</a>,
317316
<a :href="downloadLinksData.baseLinks.codegen">codegen-schedule</a>
318317
(<a
319-
href="#"
320-
@click="
318+
href="#"
319+
@click.prevent="
321320
handlePerfettoClick(
322-
$event,
323321
downloadLinksData.baseLinks.perfetto.link,
324322
downloadLinksData.baseLinks.perfetto.traceTitle
325323
)
326324
"
327-
>Perfetto</a
328-
>,
325+
>Perfetto</a
326+
>,
329327
<a :href="downloadLinksData.baseLinks.firefox">Firefox profiler</a>)
330328
results for {{ selector?.base_commit?.substring(0, 10) }} (base
331329
commit)
@@ -338,16 +336,15 @@ function DeltaComponent({delta}: {delta: DeltaData | null}) {
338336
<a :href="downloadLinksData.newLinks.crox">crox</a>,
339337
<a :href="downloadLinksData.newLinks.codegen">codegen-schedule</a>
340338
(<a
341-
href="#"
342-
@click="
339+
href="#"
340+
@click.prevent="
343341
handlePerfettoClick(
344-
$event,
345342
downloadLinksData.newLinks.perfetto.link,
346343
downloadLinksData.newLinks.perfetto.traceTitle
347344
)
348345
"
349-
>Perfetto</a
350-
>, <a :href="downloadLinksData.newLinks.firefox">Firefox profiler</a>)
346+
>Perfetto</a
347+
>, <a :href="downloadLinksData.newLinks.firefox">Firefox profiler</a>)
351348
results for {{ selector?.commit?.substring(0, 10) }} (new commit)
352349

353350
<template v-if="downloadLinksData.diffLink">

0 commit comments

Comments
 (0)