Skip to content

Commit 3df7408

Browse files
Merge pull request #822 from rylev/2021-01-05-update
Update 2021-01-05 with results of investigations into rollup
2 parents 9c4eebf + b8973fb commit 3df7408

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

triage/2021-01-05.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,14 @@ rustc_serialize: specialize opaque encoding and decoding of some u8 sequences [#
2323
Rollup of 9 pull requests [#80530](https://github.com/rust-lang/rust/issues/80530)
2424
- Moderate regression in [instruction counts](https://perf.rust-lang.org/compare.html?start=e2267046859c9ceb932abc983561d53a117089f6&end=9775ffef2a4c3a36cadb58b72ea60cefb92c86ae&stat=instructions:u) (up to 2.6% on `full` builds of `ripgrep-opt`)
2525
- Moderate improvement in [instruction counts](https://perf.rust-lang.org/compare.html?start=e2267046859c9ceb932abc983561d53a117089f6&end=9775ffef2a4c3a36cadb58b72ea60cefb92c86ae&stat=instructions:u) (up to -1.5% on `incr-patched: println` builds of `cargo-debug`)
26-
- Unsure which PRs were responsible for the performance impact, but we suspect [#80458](https://github.com/rust-lang/rust/pull/80458).
26+
- [#78934](https://github.com/rust-lang/rust/issues/78934) was responsible for the issue. An investigation into what exactly is the cause will happen, but the regression is not severe enough to warrant a revert.
2727

2828
Rollup of 12 pull requests [#80708](https://github.com/rust-lang/rust/issues/80708)
2929
- Large regression in [instruction counts](https://perf.rust-lang.org/compare.html?start=9919ad6e9ed113557c68c430de2e0f434e4f5b6e&end=f412fb56b8d11c168e7ee49ee74e79c4ab2e5637&stat=instructions:u) (up to 5.9% on `incr-unchanged` builds of `deeply-nested-async-check`)
3030
- Moderate improvement in [instruction counts](https://perf.rust-lang.org/compare.html?start=9919ad6e9ed113557c68c430de2e0f434e4f5b6e&end=f412fb56b8d11c168e7ee49ee74e79c4ab2e5637&stat=instructions:u) (up to -1.4% on `full` builds of `coercions-debug`)
3131
- The regression outweighs the improvement
32-
- Unsure which PR is the cause of the regression, but [#80637](https://github.com/rust-lang/rust/pull/80637) is our best guess.
32+
- [#80538](https://github.com/rust-lang/rust/issues/80538) was responsible for the issue. An investigation into what exactly is the cause will happen, but the regression is not severe enough to warrant a revert.
3333

3434
#### Nags requiring follow up
3535

3636
- stdarch is still a major contributor to libcore compile times.
37-
- Investigate the two rollups that had perf impacts [#80530](https://github.com/rust-lang/rust/issues/80530) and [#80708](https://github.com/rust-lang/rust/pull/80708).

0 commit comments

Comments
 (0)