Skip to content

Commit 3605985

Browse files
pnkfelixpnkfelix
committed
Initial triage report template.
1 parent fcd48e1 commit 3605985

File tree

1 file changed

+240
-0
lines changed

1 file changed

+240
-0
lines changed

‎triage/2024-03-11.md

Lines changed: 240 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,240 @@
1+
# 2024-03-11 Triage Log
2+
3+
TODO: Summary
4+
5+
Triage done by **@???**.
6+
Revision range: [41d97c8a5dea2731b0e56fe97cd7cb79e21cff79..e919669d42dfb8950866d4cb268c5359eb3f7c54](https://perf.rust-lang.org/?start=41d97c8a5dea2731b0e56fe97cd7cb79e21cff79&end=e919669d42dfb8950866d4cb268c5359eb3f7c54&absolute=false&stat=instructions%3Au)
7+
8+
**Summary**:
9+
10+
| (instructions:u) | mean | range | count |
11+
|:----------------------------------:|:-----:|:--------------:|:-----:|
12+
| Regressions ❌ <br /> (primary) | 0.6% | [0.2%, 1.4%] | 38 |
13+
| Regressions ❌ <br /> (secondary) | 1.1% | [0.2%, 4.9%] | 50 |
14+
| Improvements ✅ <br /> (primary) | -1.0% | [-4.8%, -0.2%] | 119 |
15+
| Improvements ✅ <br /> (secondary) | -0.8% | [-2.2%, -0.4%] | 36 |
16+
| All ❌✅ (primary) | -0.6% | [-4.8%, 1.4%] | 157 |
17+
18+
19+
2 Regressions, 5 Improvements, 9 Mixed; ??? of them in rollups
20+
54 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
<UNKNOWN> [#121985](https://github.com/rust-lang/rust/pull/121985) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=8c9a75b3238b66592779d6b240dbf78eacefebb8&end=52f8aec14c616387c5f793687f2d9026de6c78ca&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:----:|:------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | 0.3% | [0.3%, 0.3%] | 1 |
29+
| Regressions ❌ <br /> (secondary) | 3.0% | [0.2%, 4.5%] | 8 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | 0.3% | [0.3%, 0.3%] | 1 |
33+
34+
35+
<UNKNOWN> [#121752](https://github.com/rust-lang/rust/pull/121752) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=cd81f5b27ee00b49d413db50b5e6af871cebcf23&end=c69fda7dc664e62f8920a02a4e55d6207b212c24&stat=instructions:u)
36+
37+
| (instructions:u) | mean | range | count |
38+
|:----------------------------------:|:----:|:------------:|:-----:|
39+
| Regressions ❌ <br /> (primary) | 0.4% | [0.2%, 0.5%] | 6 |
40+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
41+
| Improvements ✅ <br /> (primary) | - | - | 0 |
42+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
43+
| All ❌✅ (primary) | 0.4% | [0.2%, 0.5%] | 6 |
44+
45+
46+
#### Improvements
47+
48+
<UNKNOWN> [#122111](https://github.com/rust-lang/rust/pull/122111) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=bfe762e0ed2e95041cc12c02c5565c4368f2cc9f&end=7d3702e472b99be0f5de6608dd87af1df8f99428&stat=instructions:u)
49+
50+
| (instructions:u) | mean | range | count |
51+
|:----------------------------------:|:-----:|:--------------:|:-----:|
52+
| Regressions ❌ <br /> (primary) | - | - | 0 |
53+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
54+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.4%, -0.3%] | 7 |
55+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.6%, -0.3%] | 5 |
56+
| All ❌✅ (primary) | -0.4% | [-0.4%, -0.3%] | 7 |
57+
58+
59+
<UNKNOWN> [#122117](https://github.com/rust-lang/rust/pull/122117) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=7d3702e472b99be0f5de6608dd87af1df8f99428&end=d03b986db1f4146b58078c9dde5b0fa6d808f031&stat=instructions:u)
60+
61+
| (instructions:u) | mean | range | count |
62+
|:----------------------------------:|:-----:|:--------------:|:-----:|
63+
| Regressions ❌ <br /> (primary) | - | - | 0 |
64+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
65+
| Improvements ✅ <br /> (primary) | -2.1% | [-3.9%, -0.4%] | 12 |
66+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
67+
| All ❌✅ (primary) | -2.1% | [-3.9%, -0.4%] | 12 |
68+
69+
70+
<UNKNOWN> [#121500](https://github.com/rust-lang/rust/pull/121500) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=42825768b103c28b10ce0407749acb21d32abeec&end=74acabe9b042ea8c42862ee29aca2a8b7d333644&stat=instructions:u)
71+
72+
| (instructions:u) | mean | range | count |
73+
|:----------------------------------:|:-----:|:--------------:|:-----:|
74+
| Regressions ❌ <br /> (primary) | - | - | 0 |
75+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
76+
| Improvements ✅ <br /> (primary) | -0.6% | [-0.8%, -0.2%] | 4 |
77+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.6%, -0.5%] | 2 |
78+
| All ❌✅ (primary) | -0.6% | [-0.8%, -0.2%] | 4 |
79+
80+
81+
<UNKNOWN> [#122010](https://github.com/rust-lang/rust/pull/122010) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=01d73d4041969cde4a79bf9793521ef323248a24&end=4d4bb491b65c300835442f6cb4f34fc9a5685c26&stat=instructions:u)
82+
83+
| (instructions:u) | mean | range | count |
84+
|:----------------------------------:|:-----:|:--------------:|:-----:|
85+
| Regressions ❌ <br /> (primary) | - | - | 0 |
86+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
87+
| Improvements ✅ <br /> (primary) | -0.5% | [-1.0%, -0.2%] | 74 |
88+
| Improvements ✅ <br /> (secondary) | -0.7% | [-2.1%, -0.2%] | 26 |
89+
| All ❌✅ (primary) | -0.5% | [-1.0%, -0.2%] | 74 |
90+
91+
92+
<UNKNOWN> [#122064](https://github.com/rust-lang/rust/pull/122064) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=5bc7b9ac8ace5312e1d2cdc2722715cf58d4f926&end=094a6204f590e6b4770b5f26359dd17a07897adf&stat=instructions:u)
93+
94+
| (instructions:u) | mean | range | count |
95+
|:----------------------------------:|:-----:|:--------------:|:-----:|
96+
| Regressions ❌ <br /> (primary) | - | - | 0 |
97+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
98+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.3%, -0.2%] | 19 |
99+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.4%, -0.2%] | 12 |
100+
| All ❌✅ (primary) | -0.3% | [-0.3%, -0.2%] | 19 |
101+
102+
103+
#### Mixed
104+
105+
<UNKNOWN> [#122059](https://github.com/rust-lang/rust/pull/122059) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=79d246112dc95bbd67848f7546f3fd1aca516b82&end=9fb91aa2e70bfcc1c0adaad79711f0321ea81ece&stat=instructions:u)
106+
107+
| (instructions:u) | mean | range | count |
108+
|:----------------------------------:|:-----:|:--------------:|:-----:|
109+
| Regressions ❌ <br /> (primary) | - | - | 0 |
110+
| Regressions ❌ <br /> (secondary) | 1.1% | [0.3%, 1.9%] | 2 |
111+
| Improvements ✅ <br /> (primary) | -0.8% | [-1.2%, -0.4%] | 2 |
112+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.3%] | 1 |
113+
| All ❌✅ (primary) | -0.8% | [-1.2%, -0.4%] | 2 |
114+
115+
116+
<UNKNOWN> [#120268](https://github.com/rust-lang/rust/pull/120268) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=9fb91aa2e70bfcc1c0adaad79711f0321ea81ece&end=14fbc3c00525b41a3a3ee2c90e9ab6fd3b05274f&stat=instructions:u)
117+
118+
| (instructions:u) | mean | range | count |
119+
|:----------------------------------:|:-----:|:--------------:|:-----:|
120+
| Regressions ❌ <br /> (primary) | 0.7% | [0.2%, 1.8%] | 4 |
121+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.2%, 0.3%] | 7 |
122+
| Improvements ✅ <br /> (primary) | -0.8% | [-1.2%, -0.3%] | 5 |
123+
| Improvements ✅ <br /> (secondary) | -0.9% | [-2.2%, -0.3%] | 3 |
124+
| All ❌✅ (primary) | -0.1% | [-1.2%, 1.8%] | 9 |
125+
126+
127+
<UNKNOWN> [#122182](https://github.com/rust-lang/rust/pull/122182) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=14fbc3c00525b41a3a3ee2c90e9ab6fd3b05274f&end=1b2c53a15dba7962cfc284c3b6d61a0341ffa27a&stat=instructions:u)
128+
129+
| (instructions:u) | mean | range | count |
130+
|:----------------------------------:|:-----:|:--------------:|:-----:|
131+
| Regressions ❌ <br /> (primary) | 1.3% | [1.3%, 1.3%] | 1 |
132+
| Regressions ❌ <br /> (secondary) | 0.8% | [0.2%, 1.3%] | 2 |
133+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.7%, -0.2%] | 17 |
134+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.9%, -0.2%] | 15 |
135+
| All ❌✅ (primary) | -0.3% | [-0.7%, 1.3%] | 18 |
136+
137+
138+
<UNKNOWN> [#122150](https://github.com/rust-lang/rust/pull/122150) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=9d272a1b0501f96da0ed10caa1b2eb6dbb653686&end=b054da815501bafb24a08284151d32862f7a3a13&stat=instructions:u)
139+
140+
| (instructions:u) | mean | range | count |
141+
|:----------------------------------:|:-----:|:--------------:|:-----:|
142+
| Regressions ❌ <br /> (primary) | - | - | 0 |
143+
| Regressions ❌ <br /> (secondary) | 0.7% | [0.3%, 1.3%] | 6 |
144+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.4%, -0.2%] | 6 |
145+
| Improvements ✅ <br /> (secondary) | -0.2% | [-0.3%, -0.2%] | 3 |
146+
| All ❌✅ (primary) | -0.3% | [-0.4%, -0.2%] | 6 |
147+
148+
149+
<UNKNOWN> [#122241](https://github.com/rust-lang/rust/pull/122241) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=b054da815501bafb24a08284151d32862f7a3a13&end=8401645716b26a8b4c6974dc0680e55e81e9e8a1&stat=instructions:u)
150+
151+
| (instructions:u) | mean | range | count |
152+
|:----------------------------------:|:-----:|:--------------:|:-----:|
153+
| Regressions ❌ <br /> (primary) | - | - | 0 |
154+
| Regressions ❌ <br /> (secondary) | 0.9% | [0.2%, 1.6%] | 2 |
155+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.3%, -0.3%] | 2 |
156+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.3%] | 1 |
157+
| All ❌✅ (primary) | -0.3% | [-0.3%, -0.3%] | 2 |
158+
159+
160+
<UNKNOWN> [#120985](https://github.com/rust-lang/rust/pull/120985) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=8401645716b26a8b4c6974dc0680e55e81e9e8a1&end=25ee3c6a2f429a97ff4ad239e3f42409cd71fe0a&stat=instructions:u)
161+
162+
| (instructions:u) | mean | range | count |
163+
|:----------------------------------:|:-----:|:--------------:|:-----:|
164+
| Regressions ❌ <br /> (primary) | 0.3% | [0.1%, 1.0%] | 88 |
165+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.1%, 0.5%] | 21 |
166+
| Improvements ✅ <br /> (primary) | -1.0% | [-1.6%, -0.4%] | 54 |
167+
| Improvements ✅ <br /> (secondary) | -0.8% | [-1.2%, -0.6%] | 8 |
168+
| All ❌✅ (primary) | -0.2% | [-1.6%, 1.0%] | 142 |
169+
170+
171+
<UNKNOWN> [#122256](https://github.com/rust-lang/rust/pull/122256) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=25ee3c6a2f429a97ff4ad239e3f42409cd71fe0a&end=2d24fe591f30386d6d5fc2bb941c78d7266bf10f&stat=instructions:u)
172+
173+
| (instructions:u) | mean | range | count |
174+
|:----------------------------------:|:-----:|:--------------:|:-----:|
175+
| Regressions ❌ <br /> (primary) | 0.6% | [0.2%, 1.6%] | 21 |
176+
| Regressions ❌ <br /> (secondary) | 0.6% | [0.3%, 1.6%] | 7 |
177+
| Improvements ✅ <br /> (primary) | -0.7% | [-1.0%, -0.5%] | 3 |
178+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
179+
| All ❌✅ (primary) | 0.4% | [-1.0%, 1.6%] | 24 |
180+
181+
182+
<UNKNOWN> [#121662](https://github.com/rust-lang/rust/pull/121662) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=2d24fe591f30386d6d5fc2bb941c78d7266bf10f&end=768408af123a455fb27ad8af8055becd5b95d36f&stat=instructions:u)
183+
184+
| (instructions:u) | mean | range | count |
185+
|:----------------------------------:|:-----:|:--------------:|:-----:|
186+
| Regressions ❌ <br /> (primary) | 1.1% | [0.3%, 1.7%] | 4 |
187+
| Regressions ❌ <br /> (secondary) | 1.1% | [1.1%, 1.1%] | 1 |
188+
| Improvements ✅ <br /> (primary) | -0.9% | [-1.7%, -0.4%] | 4 |
189+
| Improvements ✅ <br /> (secondary) | -0.2% | [-0.2%, -0.2%] | 1 |
190+
| All ❌✅ (primary) | 0.1% | [-1.7%, 1.7%] | 8 |
191+
192+
193+
<UNKNOWN> [#122050](https://github.com/rust-lang/rust/pull/122050) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=c69fda7dc664e62f8920a02a4e55d6207b212c24&end=a6d93acf5fdeb020ab86cc0d30d5672c23a7dba6&stat=instructions:u)
194+
195+
| (instructions:u) | mean | range | count |
196+
|:----------------------------------:|:-----:|:--------------:|:-----:|
197+
| Regressions ❌ <br /> (primary) | - | - | 0 |
198+
| Regressions ❌ <br /> (secondary) | 1.9% | [0.5%, 3.3%] | 2 |
199+
| Improvements ✅ <br /> (primary) | -2.1% | [-2.4%, -1.9%] | 2 |
200+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
201+
| All ❌✅ (primary) | -2.1% | [-2.4%, -1.9%] | 2 |
202+
203+
204+
#### Untriaged Pull Requests
205+
206+
- [#122241 Rollup of 12 pull requests](https://github.com/rust-lang/rust/pull/122241)
207+
- [#122182 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/122182)
208+
- [#122150 Replace `TypeWalker` usage with `TypeVisitor` in `wf.rs`](https://github.com/rust-lang/rust/pull/122150)
209+
- [#122140 Run a single huge par_body_owners instead of many small ones after each other.](https://github.com/rust-lang/rust/pull/122140)
210+
- [#122059 Optimize write with as_const_str for shorter code](https://github.com/rust-lang/rust/pull/122059)
211+
- [#121985 interpret: avoid a long-lived PlaceTy in stack frames](https://github.com/rust-lang/rust/pull/121985)
212+
- [#121955 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/121955)
213+
- [#121804 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/121804)
214+
- [#121752 Detect unused struct impls pub trait](https://github.com/rust-lang/rust/pull/121752)
215+
- [#121662 Distinguish between library and lang UB in assert_unsafe_precondition](https://github.com/rust-lang/rust/pull/121662)
216+
- [#121462 Combine `Sub` and `Equate`](https://github.com/rust-lang/rust/pull/121462)
217+
- [#121345 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/121345)
218+
- [#120985 Update host LLVM on x64 Linux to LLVM 18](https://github.com/rust-lang/rust/pull/120985)
219+
- [#120863 Use intrinsics::debug_assertions in debug_assert_nounwind](https://github.com/rust-lang/rust/pull/120863)
220+
- [#120862 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/120862)
221+
- [#120809 Use `transmute_unchecked` in `NonZero::new`.](https://github.com/rust-lang/rust/pull/120809)
222+
- [#120588 wasm: Store rlib metadata in wasm object files](https://github.com/rust-lang/rust/pull/120588)
223+
- [#120504 Vec::try_with_capacity](https://github.com/rust-lang/rust/pull/120504)
224+
- [#120401 Rollup of 12 pull requests](https://github.com/rust-lang/rust/pull/120401)
225+
- [#120335 Rollup of 10 pull requests](https://github.com/rust-lang/rust/pull/120335)
226+
- [#120268 Replace the default branch with an unreachable branch If it is the last variant](https://github.com/rust-lang/rust/pull/120268)
227+
- [#119662 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/119662)
228+
- [#119204 macro_rules: Less hacky heuristic for using `tt` metavariable spans](https://github.com/rust-lang/rust/pull/119204)
229+
- [#119002 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/119002)
230+
- [#118661 Restore `const PartialEq`](https://github.com/rust-lang/rust/pull/118661)
231+
- [#118473 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/118473)
232+
- [#118420 Introduce support for `async gen` blocks](https://github.com/rust-lang/rust/pull/118420)
233+
- [#118405 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/118405)
234+
- [#118319 Rollup of 4 pull requests](https://github.com/rust-lang/rust/pull/118319)
235+
- [#118308 Don't warn an empty pattern unreachable if we're not sure the data is valid](https://github.com/rust-lang/rust/pull/118308)
236+
237+
#### Nags requiring follow up
238+
239+
TODO: Nags
240+

0 commit comments

Comments
 (0)