Skip to content

Commit 3124ce2

Browse files
pnkfelixpnkfelix
committed
Initial triage report template.
1 parent 8036b12 commit 3124ce2

File tree

1 file changed

+174
-0
lines changed

1 file changed

+174
-0
lines changed

‎triage/2024-02-20.md

Lines changed: 174 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,174 @@
1+
# 2024-02-20 Triage Log
2+
3+
TODO: Summary
4+
5+
Triage done by **@???**.
6+
Revision range: [74c3f5a146860c94ff4d179fc3bfa34f879adf41..5af2130440c198afefbe5b8099342057cf272ef4](https://perf.rust-lang.org/?start=74c3f5a146860c94ff4d179fc3bfa34f879adf41&end=5af2130440c198afefbe5b8099342057cf272ef4&absolute=false&stat=instructions%3Au)
7+
8+
**Summary**:
9+
10+
| (instructions:u) | mean | range | count |
11+
|:----------------------------------:|:-----:|:---------------:|:-----:|
12+
| Regressions ❌ <br /> (primary) | 0.5% | [0.5%, 0.5%] | 1 |
13+
| Regressions ❌ <br /> (secondary) | 7.1% | [0.5%, 78.5%] | 17 |
14+
| Improvements ✅ <br /> (primary) | -2.4% | [-13.9%, -0.4%] | 222 |
15+
| Improvements ✅ <br /> (secondary) | -2.0% | [-9.8%, -0.3%] | 155 |
16+
| All ❌✅ (primary) | -2.4% | [-13.9%, 0.5%] | 223 |
17+
18+
19+
3 Regressions, 1 Improvements, 6 Mixed; ??? of them in rollups
20+
65 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
Tracking import use types for more accurate redundant import checking [#117772](https://github.com/rust-lang/rust/pull/117772) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=6f726205a1b7992537ddec96c83f2b054b03e04f&end=8b21296b5db6d5724d6b8440dcf459fa82fd88b5&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:----:|:------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | 0.4% | [0.2%, 1.0%] | 44 |
29+
| Regressions ❌ <br /> (secondary) | 0.7% | [0.4%, 1.1%] | 13 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | 0.4% | [0.2%, 1.0%] | 44 |
33+
34+
35+
macro_rules: Preserve all metavariable spans in a global side table [#119673](https://github.com/rust-lang/rust/pull/119673) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=8a497723e311a62fccb1f0bf40e79c6519744a12&end=2bf78d12d33ae02d10010309a0d85dd04e7cff72&stat=instructions:u)
36+
37+
| (instructions:u) | mean | range | count |
38+
|:----------------------------------:|:----:|:------------:|:-----:|
39+
| Regressions ❌ <br /> (primary) | 0.4% | [0.1%, 1.3%] | 26 |
40+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.1%, 3.3%] | 12 |
41+
| Improvements ✅ <br /> (primary) | - | - | 0 |
42+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
43+
| All ❌✅ (primary) | 0.4% | [0.1%, 1.3%] | 26 |
44+
45+
46+
Always evaluate free constants and statics, even if previous errors occurred [#121087](https://github.com/rust-lang/rust/pull/121087) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=5af2130440c198afefbe5b8099342057cf272ef4&end=cce6a6e22e715bd74455f2560a956ab920c3a914&stat=instructions:u)
47+
48+
| (instructions:u) | mean | range | count |
49+
|:----------------------------------:|:----:|:------------:|:-----:|
50+
| Regressions ❌ <br /> (primary) | 0.8% | [0.4%, 2.0%] | 4 |
51+
| Regressions ❌ <br /> (secondary) | 1.0% | [0.3%, 5.2%] | 11 |
52+
| Improvements ✅ <br /> (primary) | - | - | 0 |
53+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
54+
| All ❌✅ (primary) | 0.8% | [0.4%, 2.0%] | 4 |
55+
56+
57+
#### Improvements
58+
59+
pattern_analysis: Move constructor selection logic to `PlaceInfo` [#120692](https://github.com/rust-lang/rust/pull/120692) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=0b9f6ad99482c9fc35baa5f40cebf21be4fd98b3&end=bcea3cb748040aa507f44abbd66c50725f35ea4f&stat=instructions:u)
60+
61+
| (instructions:u) | mean | range | count |
62+
|:----------------------------------:|:-----:|:--------------:|:-----:|
63+
| Regressions ❌ <br /> (primary) | - | - | 0 |
64+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
65+
| Improvements ✅ <br /> (primary) | - | - | 0 |
66+
| Improvements ✅ <br /> (secondary) | -1.8% | [-1.9%, -1.7%] | 6 |
67+
| All ❌✅ (primary) | - | - | 0 |
68+
69+
70+
#### Mixed
71+
72+
Merge `impl_polarity` and `impl_trait_ref` queries [#120919](https://github.com/rust-lang/rust/pull/120919) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=0a5b998c57a8681acc13206b5917340b053b3a30&end=d26b41711282042c4ea0c5733e7332b07cfa4933&stat=instructions:u)
73+
74+
| (instructions:u) | mean | range | count |
75+
|:----------------------------------:|:-----:|:--------------:|:-----:|
76+
| Regressions ❌ <br /> (primary) | 0.6% | [0.5%, 0.7%] | 3 |
77+
| Regressions ❌ <br /> (secondary) | 1.5% | [1.5%, 1.5%] | 1 |
78+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.7%, -0.2%] | 43 |
79+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.5%, -0.2%] | 5 |
80+
| All ❌✅ (primary) | -0.3% | [-0.7%, 0.7%] | 46 |
81+
82+
83+
Update to LLVM 18 [#120055](https://github.com/rust-lang/rust/pull/120055) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=bc1b9e0e9a813d27a09708b293dc2d41c472f0d0&end=eaff1af8fdd18ee3eb05167b2836042b7d4315f6&stat=instructions:u)
84+
85+
| (instructions:u) | mean | range | count |
86+
|:----------------------------------:|:-----:|:---------------:|:-----:|
87+
| Regressions ❌ <br /> (primary) | - | - | 0 |
88+
| Regressions ❌ <br /> (secondary) | 1.1% | [0.7%, 3.5%] | 7 |
89+
| Improvements ✅ <br /> (primary) | -2.4% | [-14.1%, -0.5%] | 233 |
90+
| Improvements ✅ <br /> (secondary) | -1.6% | [-8.0%, -0.3%] | 160 |
91+
| All ❌✅ (primary) | -2.4% | [-14.1%, -0.5%] | 233 |
92+
93+
94+
Rollup of 8 pull requests [#121055](https://github.com/rust-lang/rust/pull/121055) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=37b65339c8cf1d18e331f184dbf70bbddcb1e4f7&end=7508c3e4c1349e3dd405547bc7dd8d9549e105b6&stat=instructions:u)
95+
96+
| (instructions:u) | mean | range | count |
97+
|:----------------------------------:|:-----:|:--------------:|:-----:|
98+
| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.2%] | 2 |
99+
| Regressions ❌ <br /> (secondary) | 0.9% | [0.8%, 0.9%] | 2 |
100+
| Improvements ✅ <br /> (primary) | -0.9% | [-1.8%, -0.2%] | 9 |
101+
| Improvements ✅ <br /> (secondary) | -0.6% | [-1.1%, -0.3%] | 21 |
102+
| All ❌✅ (primary) | -0.7% | [-1.8%, 0.2%] | 11 |
103+
104+
105+
`cargo update` [#120454](https://github.com/rust-lang/rust/pull/120454) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=7508c3e4c1349e3dd405547bc7dd8d9549e105b6&end=cc1c0990ab6f7136d1d54fd008598095b2c53c66&stat=instructions:u)
106+
107+
| (instructions:u) | mean | range | count |
108+
|:----------------------------------:|:-----:|:--------------:|:-----:|
109+
| Regressions ❌ <br /> (primary) | - | - | 0 |
110+
| Regressions ❌ <br /> (secondary) | 1.4% | [0.8%, 1.9%] | 10 |
111+
| Improvements ✅ <br /> (primary) | - | - | 0 |
112+
| Improvements ✅ <br /> (secondary) | -0.9% | [-3.4%, -0.2%] | 15 |
113+
| All ❌✅ (primary) | - | - | 0 |
114+
115+
116+
Store static initializers in metadata instead of the MIR of statics. [#116564](https://github.com/rust-lang/rust/pull/116564) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=4ae1e79876fcee94a56c1edf7c029a677084d7fc&end=6a4222b5119bce8c24e74dd3ad44006ce0c803e6&stat=instructions:u)
117+
118+
| (instructions:u) | mean | range | count |
119+
|:----------------------------------:|:-----:|:--------------:|:-----:|
120+
| Regressions ❌ <br /> (primary) | - | - | 0 |
121+
| Regressions ❌ <br /> (secondary) | 15.9% | [0.4%, 81.2%] | 8 |
122+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.5%, -0.2%] | 8 |
123+
| Improvements ✅ <br /> (secondary) | -2.5% | [-8.9%, -0.4%] | 18 |
124+
| All ❌✅ (primary) | -0.4% | [-0.5%, -0.2%] | 8 |
125+
126+
127+
Clean up potential_query_instability with FxIndexMap and UnordMap [#120931](https://github.com/rust-lang/rust/pull/120931) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=6a4222b5119bce8c24e74dd3ad44006ce0c803e6&end=fa9f77ff35b4b63ed0cef9a9642c8f881b33f14f&stat=instructions:u)
128+
129+
| (instructions:u) | mean | range | count |
130+
|:----------------------------------:|:-----:|:--------------:|:-----:|
131+
| Regressions ❌ <br /> (primary) | - | - | 0 |
132+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.2%, 0.2%] | 4 |
133+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.2%, -0.2%] | 2 |
134+
| Improvements ✅ <br /> (secondary) | -6.6% | [-6.6%, -6.6%] | 1 |
135+
| All ❌✅ (primary) | -0.2% | [-0.2%, -0.2%] | 2 |
136+
137+
138+
#### Untriaged Pull Requests
139+
140+
- [#121087 Always evaluate free constants and statics, even if previous errors occurred](https://github.com/rust-lang/rust/pull/121087)
141+
- [#120931 Clean up potential_query_instability with FxIndexMap and UnordMap](https://github.com/rust-lang/rust/pull/120931)
142+
- [#120862 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/120862)
143+
- [#120809 Use `transmute_unchecked` in `NonZero::new`.](https://github.com/rust-lang/rust/pull/120809)
144+
- [#120401 Rollup of 12 pull requests](https://github.com/rust-lang/rust/pull/120401)
145+
- [#120335 Rollup of 10 pull requests](https://github.com/rust-lang/rust/pull/120335)
146+
- [#119673 macro_rules: Preserve all metavariable spans in a global side table](https://github.com/rust-lang/rust/pull/119673)
147+
- [#119662 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/119662)
148+
- [#119204 macro_rules: Less hacky heuristic for using `tt` metavariable spans](https://github.com/rust-lang/rust/pull/119204)
149+
- [#119002 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/119002)
150+
- [#118661 Restore `const PartialEq`](https://github.com/rust-lang/rust/pull/118661)
151+
- [#118473 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/118473)
152+
- [#118420 Introduce support for `async gen` blocks](https://github.com/rust-lang/rust/pull/118420)
153+
- [#118405 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/118405)
154+
- [#118319 Rollup of 4 pull requests](https://github.com/rust-lang/rust/pull/118319)
155+
- [#118308 Don't warn an empty pattern unreachable if we're not sure the data is valid](https://github.com/rust-lang/rust/pull/118308)
156+
- [#117772 Tracking import use types for more accurate redundant import checking](https://github.com/rust-lang/rust/pull/117772)
157+
- [#117769 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/117769)
158+
- [#117736 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/117736)
159+
- [#117213 Reorder check_item_type diagnostics so they occur next to the corresponding `check_well_formed` diagnostics](https://github.com/rust-lang/rust/pull/117213)
160+
- [#117180 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/117180)
161+
- [#116940 Rollup of 4 pull requests](https://github.com/rust-lang/rust/pull/116940)
162+
- [#116915 Add an assume that the index is inbounds to slice::get_unchecked](https://github.com/rust-lang/rust/pull/116915)
163+
- [#116889 Eat close paren if capture_cfg to avoid unbalanced parens](https://github.com/rust-lang/rust/pull/116889)
164+
- [#116492 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/116492)
165+
- [#116391 exhaustiveness: Rework constructor splitting](https://github.com/rust-lang/rust/pull/116391)
166+
- [#116183 Always preserve DebugInfo in DeadStoreElimination.](https://github.com/rust-lang/rust/pull/116183)
167+
- [#116033 report `unused_import` for empty reexports even it is pub](https://github.com/rust-lang/rust/pull/116033)
168+
- [#115762 Explain revealing of opaque types in layout_of ParamEnv](https://github.com/rust-lang/rust/pull/115762)
169+
- [#115751 some inspect improvements](https://github.com/rust-lang/rust/pull/115751)
170+
171+
#### Nags requiring follow up
172+
173+
TODO: Nags
174+

0 commit comments

Comments
 (0)