Skip to content

Commit 2a84f60

Browse files
Add triage for this week
This also adjusts the weekly_report script to avoid generating results for changes that are only in the coercions println benchmark; it is quite noisy.
1 parent ed7db22 commit 2a84f60

File tree

2 files changed

+37
-2
lines changed

2 files changed

+37
-2
lines changed

triage/2021-04-13.md

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
# 2021-04-13 Triage Log
2+
3+
A very quiet week overall.
4+
5+
Triage done by **@simulacrum**.
6+
Revision range: [d32238532138485c80db4f2cd596372bce214e00..5258a74c887f8ae14717e1f98b652b470877ce4e](https://perf.rust-lang.org/?start=d32238532138485c80db4f2cd596372bce214e00&end=5258a74c887f8ae14717e1f98b652b470877ce4e&absolute=false&stat=instructions%3Au)
7+
8+
1 Regressions, 0 Improvements, 0 Mixed
9+
??? of them in rollups
10+
11+
#### Regressions
12+
13+
Update stdarch submodule (to before it switched to const generics) [#83776](https://github.com/rust-lang/rust/issues/83776)
14+
- Large regression in [instruction counts](https://perf.rust-lang.org/compare.html?start=1284da34da56a17ae368e4673920ec4120562cbd&end=d0695c9081b16077d0aed368bccaf437d77ff497&stat=instructions:u) (up to 6.3% on `incr-unchanged` builds of `deeply-nested-closures-debug`)
15+
- Mostly a regression for doc benchmarks, but also a 1.5% regression in memory
16+
usage on check, debug, and opt builds across all benchmarks.
17+
18+
#### Improvements
19+
20+
- None
21+
22+
#### Mixed
23+
24+
- None
25+
26+
#### Nags requiring follow up
27+
28+
- The [issue](https://github.com/rust-lang/rust/pull/82964#issuecomment-800663588) from three weeks ago has stalled.
29+
Likely this needs someone to mentor the author, or to take over the
30+
investigation.

triage/weekly_report.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ def eprint(*args, **kwargs):
6161

6262

6363
def get_username():
64-
usernames = {'mackendy': 'ecstaticmorse', 'joshua': 'jyn514'}
64+
usernames = {'mackendy': 'ecstaticmorse', 'joshua': 'jyn514', 'mark': 'simulacrum'}
6565

6666
home_dir = Path.home().name
6767

@@ -123,7 +123,12 @@ def relative_change(self):
123123
return relative_change(*self.results)
124124

125125
def is_significant(self):
126-
return abs(self.log_change()) > self.__class__.SIGNIFICANCE_THRESHOLD
126+
if self.bench_name.startswith("coercions-debug") and self.cache_state == "incr-patched: println":
127+
# This particular (benchmark, cache) combination frequently varies
128+
# by up to 2% up and down.
129+
return abs(self.relative_change()) > 2
130+
else:
131+
return abs(self.log_change()) > self.__class__.SIGNIFICANCE_THRESHOLD
127132

128133
def is_increase(self):
129134
return self.results[1] > self.results[0]

0 commit comments

Comments
 (0)