Skip to content

Commit 27db467

Browse files
committed
Pluralize improvements/regressions in triage report correctly
1 parent 755f62c commit 27db467

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

site/src/comparison.rs

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1564,6 +1564,12 @@ async fn generate_report(
15641564
e
15651565
),
15661566
};
1567+
let num_regressions = regressions.len();
1568+
let regressions_suffix = if num_regressions == 1 { "" } else { "s" };
1569+
1570+
let num_improvements = improvements.len();
1571+
let improvements_suffix = if num_improvements == 1 { "" } else { "s" };
1572+
15671573
format!(
15681574
r#####"# {date} Triage Log
15691575
@@ -1574,7 +1580,7 @@ Revision range: [{first_commit}..{last_commit}](https://perf.rust-lang.org/?star
15741580
15751581
{summary}
15761582
1577-
{num_regressions} Regressions, {num_improvements} Improvements, {num_mixed} Mixed; ??? of them in rollups
1583+
{num_regressions} Regression{regressions_suffix}, {num_improvements} Improvement{improvements_suffix}, {num_mixed} Mixed; ??? of them in rollups
15781584
{num_comparisons} artifact comparisons made in total
15791585
15801586
#### Regressions
@@ -1602,8 +1608,6 @@ TODO: Nags
16021608
first_commit = start,
16031609
last_commit = end,
16041610
num_comparisons = num_comparisons,
1605-
num_regressions = regressions.len(),
1606-
num_improvements = improvements.len(),
16071611
num_mixed = mixed.len(),
16081612
regressions = regressions.join("\n\n"),
16091613
improvements = improvements.join("\n\n"),

0 commit comments

Comments
 (0)