Skip to content

Commit 1bf6662

Browse files
Add triage report for this week
1 parent 931ac43 commit 1bf6662

File tree

1 file changed

+35
-0
lines changed

1 file changed

+35
-0
lines changed

triage/2021-06-22.md

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
# 2021-06-22 Triage Log
2+
3+
A few small regressions on smaller benchmarks (e.g., helloworld), likely
4+
centered around more IR being generated in a few cases.
5+
6+
Triage done by **@simulacrum**.
7+
Revision range: [d192c80d2284ba6b5146bb3da586354c3762c72b..3912083821c5072f700a75589c8af6a9d3e20a21](https://perf.rust-lang.org/?start=d192c80d2284ba6b5146bb3da586354c3762c72b&end=3912083821c5072f700a75589c8af6a9d3e20a21&absolute=false&stat=instructions%3Au)
8+
9+
2 Regressions, 1 Improvements, 0 Mixed
10+
11+
1 of them in rollups
12+
13+
#### Regressions
14+
15+
Rollup of 6 pull requests [#86417](https://github.com/rust-lang/rust/issues/86417)
16+
- Moderate regression in [instruction counts](https://perf.rust-lang.org/compare.html?start=149f4836dd6d9e789a26dca16dc034588866894e&end=a6bc43ea846ee568ef4e890d4ac2a4cc03475bfc&stat=instructions:u) (up to 2.0% on `incr-unchanged` builds of `helloworld-opt`)
17+
- Not really clear what the cause here is, but the regression is concentrated on
18+
small benchmarks.
19+
20+
Change entry point to 🛡️ against 💥 💥-payloads [#86034](https://github.com/rust-lang/rust/issues/86034)
21+
- Moderate regression in [instruction counts](https://perf.rust-lang.org/compare.html?start=29cd70d40722930e66a8b726fe58a7bd1d64a22b&end=6b354a13820a444f834a33365ae4a8d97d7d27ce&stat=instructions:u) (up to 4.5% on `incr-full` builds of `helloworld-opt`)
22+
- Seems to be more code getting generated into binaries, leading to
23+
regressions on the smaller benchmarks.
24+
25+
#### Improvements
26+
27+
optimize Eq implementation for paths [#86179](https://github.com/rust-lang/rust/issues/86179)
28+
- Moderate improvement in [instruction counts](https://perf.rust-lang.org/compare.html?start=8daad743c4bb941536860b4df20111cb71b8c777&end=9fef8d91b4a6c5bfe07c025c434f2d623ad83337&stat=instructions:u) (up to -3.3% on `incr-patched: println` builds of `cargo-opt`)
29+
- Mostly wins on incremental benchmarks.
30+
31+
#### Nags requiring follow up
32+
33+
Backlog:
34+
35+
* Follow up on regression in [#85343](https://github.com/rust-lang/rust/pull/85343#issuecomment-856819536)

0 commit comments

Comments
 (0)