Skip to content

Commit 0188edc

Browse files
Triage for week of October 12th
This also includes an adjustment to the triage script to break in a nicer way on non-contiguous data.
1 parent e90b9b6 commit 0188edc

File tree

2 files changed

+47
-1
lines changed

2 files changed

+47
-1
lines changed

triage/2020-10-13.md

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
# 2020-10-13 Triage Log
2+
3+
Overall, fairly busy week, but without major regressions that need to be
4+
addressed.
5+
6+
Triage done by **@simulacrum**.
7+
Revision range: [ea7e131435a960d154e9a5d6a9297039574ffd7d..06a079c43efb062e335e6e6c9dabd3c750619980](https://perf.rust-lang.org/?start=ea7e131435a960d154e9a5d6a9297039574ffd7d&end=06a079c43efb062e335e6e6c9dabd3c750619980&absolute=false&stat=instructions%3Au)
8+
9+
3 Regressions, 5 Improvements, 4 Mixed
10+
1 mixed improement of them in rollups
11+
12+
#### Regressions
13+
14+
#### Improvements
15+
16+
[#73905](https://github.com/rust-lang/rust/issues/73905)
17+
- Very large improvement in [instruction counts](https://perf.rust-lang.org/compare.html?start=5849a7eca90582ee59b67eb09548a2aa424d7f52&end=08e2d4616613716362b4b49980ff303f2b9ae654&stat=instructions:u) (up to -90.5% on `full` builds of `wf-projection-stress-65510-check`)
18+
19+
[#77597](https://github.com/rust-lang/rust/issues/77597)
20+
- Moderate improvement in [instruction counts](https://perf.rust-lang.org/compare.html?start=91a79fb29ac78d057d04dbe86be13d5dcc64309a&end=e055f87cdfcac1f4da6c518a547dee459de0aa26&stat=instructions:u) (up to -3.5% on `full` builds of `match-stress-enum-debug`)
21+
22+
[#77793](https://github.com/rust-lang/rust/issues/77793)
23+
- Moderate improvement in [instruction counts](https://perf.rust-lang.org/compare.html?start=bc74dd711fd154555dea3b110dfed39c4dc37bc6&end=8cc82ee340ed96099680ec1165cf5e192d658d0f&stat=instructions:u) (up to -2.3% on `full` builds of `piston-image-debug`)
24+
25+
#### Mixed
26+
27+
[#77594](https://github.com/rust-lang/rust/issues/77594)
28+
- Very large regression in [instruction counts](https://perf.rust-lang.org/compare.html?start=5ded394553296d56bb66e925d7001ab3271979ce&end=5849a7eca90582ee59b67eb09548a2aa424d7f52&stat=instructions:u) (up to 46.0% on `full` builds of `deeply-nested-opt`)
29+
- Moderate improvement in [instruction counts](https://perf.rust-lang.org/compare.html?start=5ded394553296d56bb66e925d7001ab3271979ce&end=5849a7eca90582ee59b67eb09548a2aa424d7f52&stat=instructions:u) (up to -1.6% on `incr-unchanged` builds of `deeply-nested-opt`)
30+
31+
[#77630](https://github.com/rust-lang/rust/issues/77630)
32+
- Large improvement in [instruction counts](https://perf.rust-lang.org/compare.html?start=98edd1fbf8a68977a2a7c1312eb1ebff80515a92&end=59dafb876e125c49fca93820c5ef22da3fcb8644&stat=instructions:u) (up to -5.2% on `full` builds of `match-stress-enum-check`)
33+
- Moderate regression in [instruction counts](https://perf.rust-lang.org/compare.html?start=98edd1fbf8a68977a2a7c1312eb1ebff80515a92&end=59dafb876e125c49fca93820c5ef22da3fcb8644&stat=instructions:u) (up to 1.6% on `full` builds of `style-servo-opt`)
34+
35+
[#77771](https://github.com/rust-lang/rust/issues/77771)
36+
- Moderate improvement in [instruction counts](https://perf.rust-lang.org/compare.html?start=cae8bc1f2324e31c98cb32b8ed37032fc9cef405&end=87b71ed68b69361ab0d45653a972ad4cf7a65cba&stat=instructions:u) (up to -2.5% on `incr-patched: Job` builds of `regex-opt`)
37+
- Moderate regression in [instruction counts](https://perf.rust-lang.org/compare.html?start=cae8bc1f2324e31c98cb32b8ed37032fc9cef405&end=87b71ed68b69361ab0d45653a972ad4cf7a65cba&stat=instructions:u) (up to 1.3% on `full` builds of `match-stress-enum-check`)
38+
39+
#### Nags requiring follow up
40+
41+
- #77594
42+
- [#77630](https://github.com/rust-lang/rust/pull/77630#issuecomment-707713702)

triage/weekly_report.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,6 +223,10 @@ def handle_compare(res):
223223

224224

225225
def make_request_payload(start, end):
226+
if start is None:
227+
start = ""
228+
if end is None:
229+
end = ""
226230
payload = {
227231
'start': start,
228232
'end': end,
@@ -260,7 +264,7 @@ def do_triage(start, end):
260264
break
261265

262266
if not response['is_contiguous']:
263-
eprint('Reached a commit whose perf run is not yet complete')
267+
eprint(f"Reached pair {start} to {initial_response['next']} whose perf run is not yet complete")
264268
break
265269

266270
handle_compare(response)

0 commit comments

Comments
 (0)