Auto merge of #142869 - nnethercote:join_path-mini, r=camelid

Use `join_with_double_colon` in `write_shared.rs`.

For consistency. Also, it's faster because `join_with_double_colon` does a better job estimating the allocation size than `join` from `itertools`.

r? `@camelid`

Author: bors