Skip to content

Commit fb53a5f

Browse files
committed
Remove //@ ignore-windows-gnu from tests that need the profiler runtime
The profiler runtime is no longer built in mingw test jobs, so these tests should naturally be skipped by `//@ needs-profiler-support`.
1 parent c01cfae commit fb53a5f

File tree

8 files changed

+0
-28
lines changed

8 files changed

+0
-28
lines changed

src/tools/compiletest/src/header.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -947,9 +947,6 @@ fn iter_header(
947947
if mode == Mode::CoverageRun {
948948
let extra_directives: &[&str] = &[
949949
"needs-profiler-support",
950-
// FIXME(mati865): MinGW GCC miscompiles compiler-rt profiling library but with Clang it works
951-
// properly. Since we only have GCC on the CI ignore the test for now.
952-
"ignore-windows-gnu",
953950
// FIXME(pietroalbini): this test currently does not work on cross-compiled
954951
// targets because remote-test is not capable of sending back the *.profraw
955952
// files generated by the LLVM instrumentation.

tests/run-make/optimization-remarks-dir-pgo/Makefile

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
# needs-profiler-support
2-
# ignore-windows-gnu
32
# ignore-cross-compile
43

5-
# FIXME(mati865): MinGW GCC miscompiles compiler-rt profiling library but with Clang it works
6-
# properly. Since we only have GCC on the CI ignore the test for now.
7-
84
include ../tools.mk
95

106
PROFILE_DIR=$(TMPDIR)/profiles

tests/run-make/pgo-branch-weights/Makefile

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
# needs-profiler-support
2-
# ignore-windows-gnu
32
# ignore-cross-compile
43

5-
# FIXME(mati865): MinGW GCC miscompiles compiler-rt profiling library but with Clang it works
6-
# properly. Since we only have GCC on the CI ignore the test for now.
7-
84
include ../tools.mk
95

106
# For some very small programs GNU ld seems to not properly handle

tests/run-make/pgo-gen-lto/Makefile

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
# needs-profiler-support
2-
# ignore-windows-gnu
32
# ignore-cross-compile
43

5-
# FIXME(mati865): MinGW GCC miscompiles compiler-rt profiling library but with Clang it works
6-
# properly. Since we only have GCC on the CI ignore the test for now.
7-
84
include ../tools.mk
95

106
COMPILE_FLAGS=-Copt-level=3 -Clto=fat -Cprofile-generate="$(TMPDIR)"

tests/run-make/pgo-gen/Makefile

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
# needs-profiler-support
2-
# ignore-windows-gnu
32
# ignore-cross-compile
43

5-
# FIXME(mati865): MinGW GCC miscompiles compiler-rt profiling library but with Clang it works
6-
# properly. Since we only have GCC on the CI ignore the test for now.
7-
84
include ../tools.mk
95

106
COMPILE_FLAGS=-g -Cprofile-generate="$(TMPDIR)"

tests/run-make/pgo-indirect-call-promotion/Makefile

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
# needs-profiler-support
2-
# ignore-windows-gnu
32
# ignore-cross-compile
43

5-
# FIXME(mati865): MinGW GCC miscompiles compiler-rt profiling library but with Clang it works
6-
# properly. Since we only have GCC on the CI ignore the test for now.
7-
84
include ../tools.mk
95

106
all:

tests/run-make/pgo-use/Makefile

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
# needs-profiler-support
2-
# ignore-windows-gnu
32
# ignore-cross-compile
43

5-
# FIXME(mati865): MinGW GCC miscompiles compiler-rt profiling library but with Clang it works
6-
# properly. Since we only have GCC on the CI ignore the test for now.
7-
84
include ../tools.mk
95

106
# This test makes sure that PGO profiling data leads to cold functions being

tests/run-make/track-pgo-dep-info/Makefile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
# needs-profiler-support
2-
# ignore-windows-gnu
32

43
include ../tools.mk
54

0 commit comments

Comments
 (0)