Skip to content

Commit f1741aa

Browse files
committed
Remove duplicate information from interned::Slot
1 parent 9770d01 commit f1741aa

File tree

1 file changed

+18
-11
lines changed

1 file changed

+18
-11
lines changed

src/tools/rust-analyzer/crates/salsa/src/interned.rs

Lines changed: 18 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,8 @@ impl InternValueTrivial for String {}
121121

122122
#[derive(Debug)]
123123
struct Slot<V> {
124-
/// DatabaseKeyIndex for this slot.
125-
database_key_index: DatabaseKeyIndex,
124+
/// key index for this slot.
125+
key_index: u32,
126126

127127
/// Value that was interned.
128128
value: V,
@@ -199,13 +199,8 @@ where
199199
};
200200

201201
let create_slot = |index: InternId| {
202-
let database_key_index = DatabaseKeyIndex {
203-
group_index: self.group_index,
204-
query_index: Q::QUERY_INDEX,
205-
key_index: index.as_u32(),
206-
};
207202
Arc::new(Slot {
208-
database_key_index,
203+
key_index: index.as_u32(),
209204
value: insert(Q::Value::from_intern_id(index)),
210205
interned_at: revision_now,
211206
})
@@ -242,7 +237,11 @@ where
242237
};
243238
let changed_at = slot.interned_at;
244239
db.salsa_runtime().report_query_read_and_unwind_if_cycle_resulted(
245-
slot.database_key_index,
240+
DatabaseKeyIndex {
241+
group_index: self.group_index,
242+
query_index: Q::QUERY_INDEX,
243+
key_index: slot.key_index,
244+
},
246245
INTERN_DURABILITY,
247246
changed_at,
248247
);
@@ -294,7 +293,11 @@ where
294293
};
295294
let changed_at = slot.interned_at;
296295
db.salsa_runtime().report_query_read_and_unwind_if_cycle_resulted(
297-
slot.database_key_index,
296+
DatabaseKeyIndex {
297+
group_index: self.group_index,
298+
query_index: Q::QUERY_INDEX,
299+
key_index: slot.key_index,
300+
},
298301
INTERN_DURABILITY,
299302
changed_at,
300303
);
@@ -414,7 +417,11 @@ where
414417
let value = slot.value.clone();
415418
let interned_at = slot.interned_at;
416419
db.salsa_runtime().report_query_read_and_unwind_if_cycle_resulted(
417-
slot.database_key_index,
420+
DatabaseKeyIndex {
421+
group_index: interned_storage.group_index,
422+
query_index: Q::QUERY_INDEX,
423+
key_index: slot.key_index,
424+
},
418425
INTERN_DURABILITY,
419426
interned_at,
420427
);

0 commit comments

Comments
 (0)