Skip to content

Commit e3f2edc

Browse files
committed
Rename Abort terminator to Terminate
Unify terminology used in unwind action and terminator, and reflect the fact that a nounwind panic is triggered instead of an immediate abort is triggered for this terminator.
1 parent 0a5dac3 commit e3f2edc

File tree

36 files changed

+112
-67
lines changed

36 files changed

+112
-67
lines changed

compiler/rustc_borrowck/src/invalidation.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ impl<'cx, 'tcx> Visitor<'tcx> for InvalidationGenerator<'cx, 'tcx> {
198198
}
199199
}
200200
TerminatorKind::Goto { target: _ }
201-
| TerminatorKind::Abort
201+
| TerminatorKind::Terminate
202202
| TerminatorKind::Unreachable
203203
| TerminatorKind::FalseEdge { real_target: _, imaginary_target: _ }
204204
| TerminatorKind::FalseUnwind { real_target: _, unwind: _ } => {

compiler/rustc_borrowck/src/lib.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -801,7 +801,7 @@ impl<'cx, 'tcx> rustc_mir_dataflow::ResultsVisitor<'cx, 'tcx> for MirBorrowckCtx
801801
}
802802

803803
TerminatorKind::Goto { target: _ }
804-
| TerminatorKind::Abort
804+
| TerminatorKind::Terminate
805805
| TerminatorKind::Unreachable
806806
| TerminatorKind::Resume
807807
| TerminatorKind::Return
@@ -845,7 +845,7 @@ impl<'cx, 'tcx> rustc_mir_dataflow::ResultsVisitor<'cx, 'tcx> for MirBorrowckCtx
845845
}
846846
}
847847

848-
TerminatorKind::Abort
848+
TerminatorKind::Terminate
849849
| TerminatorKind::Assert { .. }
850850
| TerminatorKind::Call { .. }
851851
| TerminatorKind::Drop { .. }

compiler/rustc_borrowck/src/type_check/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1300,7 +1300,7 @@ impl<'a, 'tcx> TypeChecker<'a, 'tcx> {
13001300
match &term.kind {
13011301
TerminatorKind::Goto { .. }
13021302
| TerminatorKind::Resume
1303-
| TerminatorKind::Abort
1303+
| TerminatorKind::Terminate
13041304
| TerminatorKind::Return
13051305
| TerminatorKind::GeneratorDrop
13061306
| TerminatorKind::Unreachable
@@ -1584,7 +1584,7 @@ impl<'a, 'tcx> TypeChecker<'a, 'tcx> {
15841584
span_mirbug!(self, block_data, "resume on non-cleanup block!")
15851585
}
15861586
}
1587-
TerminatorKind::Abort => {
1587+
TerminatorKind::Terminate => {
15881588
if !is_cleanup {
15891589
span_mirbug!(self, block_data, "abort on non-cleanup block!")
15901590
}

compiler/rustc_codegen_cranelift/src/base.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -488,7 +488,7 @@ fn codegen_fn_body(fx: &mut FunctionCx<'_, '_, '_>, start_block: Block) {
488488
*destination,
489489
);
490490
}
491-
TerminatorKind::Abort => {
491+
TerminatorKind::Terminate => {
492492
codegen_panic_cannot_unwind(fx, source_info);
493493
}
494494
TerminatorKind::Resume => {

compiler/rustc_codegen_cranelift/src/constant.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -549,7 +549,7 @@ pub(crate) fn mir_operand_get_const_val<'tcx>(
549549
TerminatorKind::Goto { .. }
550550
| TerminatorKind::SwitchInt { .. }
551551
| TerminatorKind::Resume
552-
| TerminatorKind::Abort
552+
| TerminatorKind::Terminate
553553
| TerminatorKind::Return
554554
| TerminatorKind::Unreachable
555555
| TerminatorKind::Drop { .. }

compiler/rustc_codegen_ssa/src/mir/analyze.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ pub fn cleanup_kinds(mir: &mir::Body<'_>) -> IndexVec<mir::BasicBlock, CleanupKi
284284
match data.terminator().kind {
285285
TerminatorKind::Goto { .. }
286286
| TerminatorKind::Resume
287-
| TerminatorKind::Abort
287+
| TerminatorKind::Terminate
288288
| TerminatorKind::Return
289289
| TerminatorKind::GeneratorDrop
290290
| TerminatorKind::Unreachable

compiler/rustc_codegen_ssa/src/mir/block.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -630,7 +630,7 @@ impl<'a, 'tcx, Bx: BuilderMethods<'a, 'tcx>> FunctionCx<'a, 'tcx, Bx> {
630630
MergingSucc::False
631631
}
632632

633-
fn codegen_abort_terminator(
633+
fn codegen_terminate_terminator(
634634
&mut self,
635635
helper: TerminatorCodegenHelper<'tcx>,
636636
bx: &mut Bx,
@@ -1263,8 +1263,8 @@ impl<'a, 'tcx, Bx: BuilderMethods<'a, 'tcx>> FunctionCx<'a, 'tcx, Bx> {
12631263
MergingSucc::False
12641264
}
12651265

1266-
mir::TerminatorKind::Abort => {
1267-
self.codegen_abort_terminator(helper, bx, terminator);
1266+
mir::TerminatorKind::Terminate => {
1267+
self.codegen_terminate_terminator(helper, bx, terminator);
12681268
MergingSucc::False
12691269
}
12701270

compiler/rustc_codegen_ssa/src/mir/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ pub struct FunctionCx<'a, 'tcx, Bx: BuilderMethods<'a, 'tcx>> {
7373
/// Cached unreachable block
7474
unreachable_block: Option<Bx::BasicBlock>,
7575

76-
/// Cached double unwind guarding block
76+
/// Cached terminate upon unwinding block
7777
terminate_block: Option<Bx::BasicBlock>,
7878

7979
/// The location where each MIR arg/var/tmp/ret is stored. This is

compiler/rustc_const_eval/src/interpret/machine.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ pub trait Machine<'mir, 'tcx>: Sized {
218218
unwind: mir::UnwindAction,
219219
) -> InterpResult<'tcx>;
220220

221-
/// Called to evaluate `Abort` MIR terminator.
221+
/// Called to abort evaluation.
222222
fn abort(_ecx: &mut InterpCx<'mir, 'tcx, Self>, _msg: String) -> InterpResult<'tcx, !> {
223223
throw_unsup_format!("aborting execution is not supported")
224224
}

compiler/rustc_const_eval/src/interpret/terminator.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ impl<'mir, 'tcx: 'mir, M: Machine<'mir, 'tcx>> InterpCx<'mir, 'tcx, M> {
144144
}
145145
}
146146

147-
Abort => {
147+
Terminate => {
148148
M::abort(self, "the program aborted execution".to_owned())?;
149149
}
150150

0 commit comments

Comments
 (0)