Skip to content

Commit ded9cc3

Browse files
remove unnecassary type alias of MacroData
1 parent 4df32ed commit ded9cc3

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

compiler/rustc_resolve/src/build_reduced_graph.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ use crate::def_collector::collect_definitions;
3232
use crate::imports::{ImportData, ImportKind};
3333
use crate::macros::{MacroRulesBinding, MacroRulesScope, MacroRulesScopeRef};
3434
use crate::{
35-
BindingKey, Determinacy, ExternPreludeEntry, Finalize, Macro, MacroData, Module, ModuleKind,
35+
BindingKey, Determinacy, ExternPreludeEntry, Finalize, MacroData, Module, ModuleKind,
3636
ModuleOrUniformRoot, NameBinding, NameBindingData, NameBindingKind, ParentScope, PathResult,
3737
ResolutionError, Resolver, ResolverArenas, Segment, ToNameBinding, Used, VisResolutionError,
3838
errors,
@@ -162,15 +162,15 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
162162
}
163163
}
164164

165-
pub(crate) fn get_macro(&self, res: Res) -> Option<Macro<'ra>> {
165+
pub(crate) fn get_macro(&self, res: Res) -> Option<&'ra MacroData> {
166166
match res {
167167
Res::Def(DefKind::Macro(..), def_id) => Some(self.get_macro_by_def_id(def_id)),
168168
Res::NonMacroAttr(_) => Some(self.non_macro_attr),
169169
_ => None,
170170
}
171171
}
172172

173-
pub(crate) fn get_macro_by_def_id(&self, def_id: DefId) -> Macro<'ra> {
173+
pub(crate) fn get_macro_by_def_id(&self, def_id: DefId) -> &'ra MacroData {
174174
match def_id.as_local() {
175175
Some(local_def_id) => {
176176
// local macros are always compiled.

compiler/rustc_resolve/src/lib.rs

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1025,8 +1025,6 @@ impl MacroData {
10251025
}
10261026
}
10271027

1028-
type Macro<'ra> = &'ra MacroData;
1029-
10301028
/// The main resolver class.
10311029
///
10321030
/// This is the visitor that walks the whole crate.
@@ -1130,12 +1128,12 @@ pub struct Resolver<'ra, 'tcx> {
11301128
builtin_macros: FxHashMap<Symbol, SyntaxExtensionKind>,
11311129
registered_tools: &'tcx RegisteredTools,
11321130
macro_use_prelude: FxIndexMap<Symbol, NameBinding<'ra>>,
1133-
local_macro_map: FxHashMap<LocalDefId, Macro<'ra>>,
1131+
local_macro_map: FxHashMap<LocalDefId, &'ra MacroData>,
11341132
/// Lazily populated cache of macros loaded from external crates.
1135-
extern_macro_map: RefCell<FxHashMap<DefId, Macro<'ra>>>,
1133+
extern_macro_map: RefCell<FxHashMap<DefId, &'ra MacroData>>,
11361134
dummy_ext_bang: Arc<SyntaxExtension>,
11371135
dummy_ext_derive: Arc<SyntaxExtension>,
1138-
non_macro_attr: Macro<'ra>,
1136+
non_macro_attr: &'ra MacroData,
11391137
local_macro_def_scopes: FxHashMap<LocalDefId, Module<'ra>>,
11401138
ast_transform_scopes: FxHashMap<LocalExpnId, Module<'ra>>,
11411139
unused_macros: FxIndexMap<LocalDefId, (NodeId, Ident)>,
@@ -1303,7 +1301,7 @@ impl<'ra> ResolverArenas<'ra> {
13031301
fn alloc_ast_paths(&'ra self, paths: &[ast::Path]) -> &'ra [ast::Path] {
13041302
self.ast_paths.alloc_from_iter(paths.iter().cloned())
13051303
}
1306-
fn alloc_macro(&'ra self, macro_data: MacroData) -> Macro<'ra> {
1304+
fn alloc_macro(&'ra self, macro_data: MacroData) -> &'ra MacroData {
13071305
self.macros.alloc(macro_data)
13081306
}
13091307
fn alloc_pattern_spans(&'ra self, spans: impl Iterator<Item = Span>) -> &'ra [Span] {
@@ -1626,7 +1624,7 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
16261624
)
16271625
}
16281626

1629-
fn new_local_macro(&mut self, def_id: LocalDefId, macro_data: MacroData) -> Macro<'ra> {
1627+
fn new_local_macro(&mut self, def_id: LocalDefId, macro_data: MacroData) -> &'ra MacroData {
16301628
let mac = self.arenas.alloc_macro(macro_data);
16311629
self.local_macro_map.insert(def_id, mac);
16321630
mac

0 commit comments

Comments
 (0)