Skip to content

Commit dae6b19

Browse files
committed
Remove ignore-uefi from tests
Do not ignore any tests for UEFI unless they do not fail gracefully. This should help reduce the surface area of this PR by a lot. Maybe think about ignoring them once this PR is merged. Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
1 parent d343822 commit dae6b19

File tree

210 files changed

+32
-231
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

210 files changed

+32
-231
lines changed

library/std/src/sys/uefi/stdio.rs

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -159,12 +159,6 @@ impl Stderr {
159159

160160
impl io::Write for Stderr {
161161
fn write(&mut self, buf: &[u8]) -> io::Result<usize> {
162-
// Since wrtiting to stderr might be tried due to a panic caused by unintialized GLOBALS,
163-
// this check ensures we do not cause an inifinte panic loop.
164-
if !uefi::env::GLOBALS.is_completed() {
165-
return Err(io::const_io_error!(io::ErrorKind::Other, "Globals not intialized"));
166-
}
167-
168162
if let Some(command_protocol) = common::get_current_handle_protocol::<
169163
uefi_command_protocol::Protocol,
170164
>(uefi_command_protocol::PROTOCOL_GUID)
@@ -193,7 +187,7 @@ pub fn is_ebadf(err: &io::Error) -> bool {
193187

194188
#[inline]
195189
pub fn panic_output() -> Option<impl io::Write> {
196-
Some(Stderr::new())
190+
if uefi::env::GLOBALS.is_completed() { Some(Stderr::new()) } else { None }
197191
}
198192

199193
fn utf8_to_ucs2(buf: &[u8], output: &mut [u16]) -> io::Result<usize> {

src/test/ui/abi/abi-sysv64-arg-passing.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
// ignore-arm
2929
// ignore-aarch64
3030
// ignore-windows
31-
// ignore-uefi rust_test_helpers do not work
3231

3332
// note: windows is ignored as rust_test_helpers does not have the sysv64 abi on windows
3433

src/test/ui/abi/anon-extern-mod.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// run-pass
22
// pretty-expanded FIXME #23616
33
// ignore-wasm32-bare no libc to test ffi with
4-
// ignore-uefi no libc to test ffi with
54

65
#![feature(rustc_private)]
76

src/test/ui/abi/c-stack-as-value.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// run-pass
22
// pretty-expanded FIXME #23616
33
// ignore-wasm32-bare no libc to test ffi with
4-
// ignore-uefi no libc to test ffi with
54

65
#![feature(rustc_private)]
76

src/test/ui/abi/c-stack-returning-int64.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// run-pass
22
// ignore-wasm32-bare no libc to test with
33
// ignore-sgx no libc
4-
// ignore-uefi no libc
54

65
#![feature(rustc_private)]
76

src/test/ui/abi/cabi-int-widening.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
// run-pass
22
// ignore-wasm32-bare no libc to test ffi with
3-
// ignore-uefi no rust_test_helpers
43

54
#[link(name = "rust_test_helpers", kind = "static")]
65
extern "C" {

src/test/ui/abi/cross-crate/anon-extern-mod-cross-crate-2.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
// aux-build:anon-extern-mod-cross-crate-1.rs
33
// pretty-expanded FIXME #23616
44
// ignore-wasm32-bare no libc to test ffi with
5-
// ignore-uefi no libc to test ffi with
65

76
extern crate anonexternmod;
87

src/test/ui/abi/cross-crate/duplicated-external-mods.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
// aux-build:anon-extern-mod-cross-crate-1.rs
44
// pretty-expanded FIXME #23616
55
// ignore-wasm32-bare no libc to test ffi with
6-
// ignore-uefi no libc to test ffi with
76

87
extern crate anonexternmod;
98

src/test/ui/abi/extern/extern-call-deep.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
// run-pass
22
// ignore-wasm32-bare no libc to test ffi with
3-
// ignore-uefi no libc to test ffi with
43
// ignore-emscripten blows the JS stack
54

65
#![feature(rustc_private)]

src/test/ui/abi/extern/extern-call-deep2.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// run-pass
22
#![allow(unused_must_use)]
33
// ignore-emscripten no threads support
4-
// ignore-uefi no threads support
54
#![feature(rustc_private)]
65

76
extern crate libc;

0 commit comments

Comments
 (0)