Add more information link to orphan impls

Author: cafce25

compiler/rustc_hir_analysis/messages.ftl

@@ -351,7 +351,9 @@ hir_analysis_only_current_traits_arbitrary = only traits defined in the current
 
 hir_analysis_only_current_traits_foreign = this is not defined in the current crate because this is a foreign trait
 
-hir_analysis_only_current_traits_label = impl doesn't use any uncovered types from inside the current crate
+hir_analysis_only_current_traits_label = impl doesn't have any local type before any uncovered type parameters
+
+hir_analysis_only_current_traits_label_more_info = for more information see https://doc.rust-lang.org/reference/items/implementations.html#orphan-rules
 
 hir_analysis_only_current_traits_name = this is not defined in the current crate because {$name} are always foreign
 

compiler/rustc_hir_analysis/src/errors.rs

@@ -1441,6 +1441,7 @@ pub enum OnlyCurrentTraits {
     Outside {
         #[primary_span]
         #[label(hir_analysis_only_current_traits_label)]
+        #[label(hir_analysis_only_current_traits_label_more_info)]
         span: Span,
         #[note(hir_analysis_only_current_traits_note)]
         note: (),
@@ -1449,6 +1450,7 @@ pub enum OnlyCurrentTraits {
     Primitive {
         #[primary_span]
         #[label(hir_analysis_only_current_traits_label)]
+        #[label(hir_analysis_only_current_traits_label_more_info)]
         span: Span,
         #[note(hir_analysis_only_current_traits_note)]
         note: (),
@@ -1457,6 +1459,7 @@ pub enum OnlyCurrentTraits {
     Arbitrary {
         #[primary_span]
         #[label(hir_analysis_only_current_traits_label)]
+        #[label(hir_analysis_only_current_traits_label_more_info)]
         span: Span,
         #[note(hir_analysis_only_current_traits_note)]
         note: (),

tests/ui/coherence/coherence-cow.re_a.stderr

@@ -5,7 +5,8 @@ LL | impl<T> Remote for Pair<T,Cover<T>> { }
    | ^^^^^^^^^^^^^^^^^^^----------------
    | |                  |
    | |                  `Pair` is not defined in the current crate
-   | impl doesn't use any uncovered types from inside the current crate
+   | impl doesn't have any local type before any uncovered type parameters
+   | for more information see https://doc.rust-lang.org/reference/items/implementations.html#orphan-rules
    |
    = note: define and implement a trait or new type instead
 

tests/ui/coherence/coherence-cow.re_b.stderr

@@ -5,7 +5,8 @@ LL | impl<T> Remote for Pair<Cover<T>,T> { }
    | ^^^^^^^^^^^^^^^^^^^----------------
    | |                  |
    | |                  `Pair` is not defined in the current crate
-   | impl doesn't use any uncovered types from inside the current crate
+   | impl doesn't have any local type before any uncovered type parameters
+   | for more information see https://doc.rust-lang.org/reference/items/implementations.html#orphan-rules
    |
    = note: define and implement a trait or new type instead
 

tests/ui/coherence/coherence-cow.re_c.stderr

@@ -5,7 +5,8 @@ LL | impl<T,U> Remote for Pair<Cover<T>,U> { }
    | ^^^^^^^^^^^^^^^^^^^^^----------------
    | |                    |
    | |                    `Pair` is not defined in the current crate
-   | impl doesn't use any uncovered types from inside the current crate
+   | impl doesn't have any local type before any uncovered type parameters
+   | for more information see https://doc.rust-lang.org/reference/items/implementations.html#orphan-rules
    |
    = note: define and implement a trait or new type instead
 

tests/ui/coherence/coherence-fundamental-trait-objects.stderr

@@ -5,7 +5,8 @@ LL | impl Misc for dyn Fundamental<Local> {}
    | ^^^^^^^^^^^^^^----------------------
    | |             |
    | |             `dyn Fundamental<Local>` is not defined in the current crate
-   | impl doesn't use any uncovered types from inside the current crate
+   | impl doesn't have any local type before any uncovered type parameters
+   | for more information see https://doc.rust-lang.org/reference/items/implementations.html#orphan-rules
    |
    = note: define and implement a trait or new type instead
 

tests/ui/coherence/coherence-impl-trait-for-marker-trait-negative.stderr

@@ -41,7 +41,8 @@ LL | impl !Send for dyn Marker2 {}
    | ^^^^^^^^^^^^^^^-----------
    | |              |
    | |              `dyn Marker2` is not defined in the current crate
-   | impl doesn't use any uncovered types from inside the current crate
+   | impl doesn't have any local type before any uncovered type parameters
+   | for more information see https://doc.rust-lang.org/reference/items/implementations.html#orphan-rules
    |
    = note: define and implement a trait or new type instead
 

tests/ui/coherence/coherence-impl-trait-for-marker-trait-positive.stderr

@@ -41,7 +41,8 @@ LL | unsafe impl Send for dyn Marker2 {}
    | ^^^^^^^^^^^^^^^^^^^^^-----------
    | |                    |
    | |                    `dyn Marker2` is not defined in the current crate
-   | impl doesn't use any uncovered types from inside the current crate
+   | impl doesn't have any local type before any uncovered type parameters
+   | for more information see https://doc.rust-lang.org/reference/items/implementations.html#orphan-rules
    |
    = note: define and implement a trait or new type instead
 

tests/ui/coherence/coherence-impls-copy.stderr

@@ -15,7 +15,8 @@ LL | impl Copy for &'static [NotSync] {}
    | ^^^^^^^^^^^^^^------------------
    | |             |
    | |             this is not defined in the current crate because slices are always foreign
-   | impl doesn't use any uncovered types from inside the current crate
+   | impl doesn't have any local type before any uncovered type parameters
+   | for more information see https://doc.rust-lang.org/reference/items/implementations.html#orphan-rules
    |
    = note: define and implement a trait or new type instead
 
@@ -26,7 +27,8 @@ LL | impl Copy for i32 {}
    | ^^^^^^^^^^^^^^---
    | |             |
    | |             `i32` is not defined in the current crate
-   | impl doesn't use any uncovered types from inside the current crate
+   | impl doesn't have any local type before any uncovered type parameters
+   | for more information see https://doc.rust-lang.org/reference/items/implementations.html#orphan-rules
    |
    = note: define and implement a trait or new type instead
 
@@ -43,7 +45,8 @@ LL | impl Copy for (MyType, MyType) {}
    | ^^^^^^^^^^^^^^----------------
    | |             |
    | |             this is not defined in the current crate because tuples are always foreign
-   | impl doesn't use any uncovered types from inside the current crate
+   | impl doesn't have any local type before any uncovered type parameters
+   | for more information see https://doc.rust-lang.org/reference/items/implementations.html#orphan-rules
    |
    = note: define and implement a trait or new type instead
 
@@ -60,7 +63,8 @@ LL | impl Copy for [MyType] {}
    | ^^^^^^^^^^^^^^--------
    | |             |
    | |             this is not defined in the current crate because slices are always foreign
-   | impl doesn't use any uncovered types from inside the current crate
+   | impl doesn't have any local type before any uncovered type parameters
+   | for more information see https://doc.rust-lang.org/reference/items/implementations.html#orphan-rules
    |
    = note: define and implement a trait or new type instead
 

tests/ui/coherence/coherence-impls-send.stderr

@@ -5,7 +5,8 @@ LL | unsafe impl Send for &'static [NotSync] {}
    | ^^^^^^^^^^^^^^^^^^^^^------------------
    | |                    |
    | |                    this is not defined in the current crate because slices are always foreign
-   | impl doesn't use any uncovered types from inside the current crate
+   | impl doesn't have any local type before any uncovered type parameters
+   | for more information see https://doc.rust-lang.org/reference/items/implementations.html#orphan-rules
    |
    = note: define and implement a trait or new type instead
 
@@ -16,7 +17,8 @@ LL | unsafe impl Send for (MyType, MyType) {}
    | ^^^^^^^^^^^^^^^^^^^^^----------------
    | |                    |
    | |                    this is not defined in the current crate because tuples are always foreign
-   | impl doesn't use any uncovered types from inside the current crate
+   | impl doesn't have any local type before any uncovered type parameters
+   | for more information see https://doc.rust-lang.org/reference/items/implementations.html#orphan-rules
    |
    = note: define and implement a trait or new type instead
 
@@ -33,7 +35,8 @@ LL | unsafe impl Send for [MyType] {}
    | ^^^^^^^^^^^^^^^^^^^^^--------
    | |                    |
    | |                    this is not defined in the current crate because slices are always foreign
-   | impl doesn't use any uncovered types from inside the current crate
+   | impl doesn't have any local type before any uncovered type parameters
+   | for more information see https://doc.rust-lang.org/reference/items/implementations.html#orphan-rules
    |
    = note: define and implement a trait or new type instead