Skip to content

Commit bb867d3

Browse files
committed
Add additional test case to unused_label lint
1 parent 7c4aa73 commit bb867d3

File tree

2 files changed

+35
-22
lines changed

2 files changed

+35
-22
lines changed

src/test/ui/lint/unused_label.rs

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -33,22 +33,29 @@ fn main() {
3333
break 'used_loop_label;
3434
}
3535

36-
'used_loop_label_outer: loop {
37-
'used_loop_label_inner: loop {
38-
break 'used_loop_label_inner;
36+
'used_loop_label_outer_1: loop {
37+
'used_loop_label_inner_1: loop {
38+
break 'used_loop_label_inner_1;
3939
}
40-
break 'used_loop_label_outer;
40+
break 'used_loop_label_outer_1;
4141
}
4242

43-
'unused_loop_label_outer: loop {
44-
'unused_loop_label_inner: loop {
43+
'used_loop_label_outer_2: loop {
44+
'unused_loop_label_inner_2: loop {
4545
//~^ WARN unused loop label
46-
break 'unused_loop_label_outer;
46+
break 'used_loop_label_outer_2;
4747
}
4848
}
4949

50-
// This is diverging, so put it at the end so we don't get unreachable_code errors everywhere
51-
// else
50+
'unused_loop_label_outer_3: loop {
51+
'used_loop_label_inner_3: loop {
52+
//~^ WARN unused loop label
53+
break 'used_loop_label_inner_3;
54+
}
55+
}
56+
57+
// This is diverging, so put it at the end so we don't get
58+
// unreachable_code errors everywhere else
5259
'unused_loop_label: loop {
5360
//~^ WARN unused loop label
5461
}

src/test/ui/lint/unused_label.stderr

Lines changed: 19 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,37 @@
1-
warning: unused loop label
2-
--> $DIR/unused_loop_label.rs:19:5
1+
warning: unused label
2+
--> $DIR/unused_label.rs:19:5
33
|
44
LL | 'unused_while_label: while 0 == 0 {
55
| ^^^^^^^^^^^^^^^^^^^
66
|
7-
= note: requested on the command line with `-W unused-loop-label`
7+
= note: requested on the command line with `-W unused-label`
88

9-
warning: unused loop label
10-
--> $DIR/unused_loop_label.rs:24:5
9+
warning: unused label
10+
--> $DIR/unused_label.rs:24:5
1111
|
1212
LL | 'unused_while_let_label: while let Some(_) = opt {
1313
| ^^^^^^^^^^^^^^^^^^^^^^^
1414

15-
warning: unused loop label
16-
--> $DIR/unused_loop_label.rs:28:5
15+
warning: unused label
16+
--> $DIR/unused_label.rs:28:5
1717
|
1818
LL | 'unused_for_label: for _ in 0..10 {
1919
| ^^^^^^^^^^^^^^^^^
2020

21-
warning: unused loop label
22-
--> $DIR/unused_loop_label.rs:44:9
21+
warning: unused label
22+
--> $DIR/unused_label.rs:44:9
2323
|
24-
LL | 'unused_loop_label_inner: loop {
25-
| ^^^^^^^^^^^^^^^^^^^^^^^^
24+
LL | 'unused_loop_label_inner_2: loop {
25+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
2626

27-
warning: unused loop label
28-
--> $DIR/unused_loop_label.rs:52:5
27+
warning: unused label
28+
--> $DIR/unused_label.rs:50:9
29+
|
30+
LL | 'unused_loop_label_outer_3: loop {
31+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
32+
33+
warning: unused label
34+
--> $DIR/unused_label.rs:52:5
2935
|
3036
LL | 'unused_loop_label: loop {
3137
| ^^^^^^^^^^^^^^^^^^

0 commit comments

Comments
 (0)