Skip to content

Commit b4dfd51

Browse files
committed
Do not allow defaults for Mode and Config
They do not have sensible defaults, and it is crucial that we get them right.
1 parent 832b627 commit b4dfd51

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

src/tools/compiletest/src/common.rs

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,6 @@ string_enum! {
3434
}
3535
}
3636

37-
impl Default for Mode {
38-
fn default() -> Self {
39-
Mode::Ui
40-
}
41-
}
42-
4337
impl Mode {
4438
pub fn aux_dir_disambiguator(self) -> &'static str {
4539
// Pretty-printing tests could run concurrently, and if they do,
@@ -151,7 +145,7 @@ pub enum Sanitizer {
151145
///
152146
/// FIXME: audit these options to make sure we are not hashing less than necessary for build stamp
153147
/// (for changed test detection).
154-
#[derive(Debug, Default, Clone)]
148+
#[derive(Debug, Clone)]
155149
pub struct Config {
156150
/// Some test [`Mode`]s support [snapshot testing], where a *reference snapshot* of outputs (of
157151
/// `stdout`, `stderr`, or other form of artifacts) can be compared to the *actual output*.

0 commit comments

Comments
 (0)