Skip to content

Commit b14323a

Browse files
committed
Also test LldWrapper and remove llvm-config override from tests
1 parent fd37722 commit b14323a

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

src/bootstrap/src/core/build_steps/tool.rs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -910,6 +910,13 @@ impl Step for LldWrapper {
910910

911911
tool_result
912912
}
913+
914+
fn metadata(&self) -> Option<StepMetadata> {
915+
Some(
916+
StepMetadata::build("LldWrapper", self.target_compiler.host)
917+
.built_by(self.build_compiler),
918+
)
919+
}
913920
}
914921

915922
#[derive(Debug, Clone, Hash, PartialEq, Eq)]

src/bootstrap/src/core/builder/tests.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -764,13 +764,15 @@ mod snapshot {
764764
ctx
765765
.config("build")
766766
.stage(2)
767-
.args(&["--set", "rust.llvm-bitcode-linker=true"])
767+
.args(&["--set", "rust.lld=true", "--set", "rust.llvm-bitcode-linker=true"])
768768
.render_steps(), @r"
769769
[build] llvm <host>
770770
[build] rustc 0 <host> -> rustc 1 <host>
771+
[build] rustc 0 <host> -> LldWrapper 1 <host>
771772
[build] rustc 1 <host> -> LlvmBitcodeLinker 2 <host>
772773
[build] rustc 1 <host> -> std 1 <host>
773774
[build] rustc 1 <host> -> rustc 2 <host>
775+
[build] rustc 1 <host> -> LldWrapper 2 <host>
774776
[build] rustc 2 <host> -> LlvmBitcodeLinker 3 <host>
775777
[build] rustc 2 <host> -> std 2 <host>
776778
[build] rustdoc 1 <host>

src/bootstrap/src/utils/tests/mod.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,6 @@ impl ConfigBuilder {
9696
// in-tree LLVM from sources.
9797
self.args.push("--set".to_string());
9898
self.args.push("llvm.download-ci-llvm=false".to_string());
99-
self.args.push("--set".to_string());
100-
self.args.push(format!("target.'{}'.llvm-config=false", get_host_target()));
10199

102100
// Do not mess with the local rustc checkout build directory
103101
self.args.push("--build-dir".to_string());

0 commit comments

Comments
 (0)